It also happens in 4.15, but not 4.14.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1198#issuecomment-619785696___
Having a separate repo here is actually not a compromise but IMHO the preferred
option. rpm-extras was thought more as an interim solution for scripts that
don't have a large enough contributor base to be projects on their own.
Even better if people from multiple distributions can share the
> Ultimately, the problem is that it not being in the rpm tarball means I have
> no hammer to get people to discover it and use it. Unfortunately, the only
> standardization point is in rpm itself.
I would argue the opposite: people interested in Python are more likely to find
and contribute
@Conan-Kudo commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group =
2nd commit has been droped
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1157#issuecomment-619849387___
Rpm-maint mailing
@hroncok Ultimately, the problem is that it not being in the rpm tarball means
I have no hammer to get people to discover it and use it. Unfortunately, the
only standardization point is in rpm itself. I hesitate to split it out after
spending so much work integrating it into rpm upstream to get
```
Name: hello
Version: 1
Release: 1%{?dist}
Summary: Hello
License: Public Domain
URL: https://google.com
%if 0%{?foo} >= 8
%define test() \
%if 1\
BUG\
%endif\
%{nil}
%endif
%description
%{summary}.
%prep
%autosetup -c -T
%files
```
Make sure that `foo` is not defined in your
Ack, thanks for chasing that down.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1198#issuecomment-619789939___
Rpm-maint
> We talk about upstreaming changes like this, but to me the situation looks
> pretty much the opposite: this has an active upstream of its own and we're
> merely syncing it from time to time, which is doing double work for ... I
> don't know what.
We are happy to maintain this ourselves. The
@pmatilai I wish you were right, but in practice that is not what has happened.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@hroncok commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the commit
@torsava commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group =
5f4fdce3041b80ef26e3a87db07ecdbd2041a9b2 is the first bad commit
commit 5f4fdce3041b80ef26e3a87db07ecdbd2041a9b2
Author: Pavlina Moravcova Varekova
Date: Mon Jul 1 13:06:35 2019 +0200
Parse multiline conditional and %include parameters correctly (#775)
Trailing '\' after multiline
Merged #1157 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1157#event-3274920498___
Rpm-maint mailing list
Thanks for the patch!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1157#issuecomment-619865055___
Rpm-maint mailing list
@pmatilai approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1157#pullrequestreview-400792284___
@Conan-Kudo commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group =
@hroncok commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group =
Totally fine by me. @torsava @Conan-Kudo @gordonmessmer @ignatenkobrain
@s-t-e-v-e-n-k WDYT?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Any new sources need to be EXTRA_DIST in Makefile.am's. For a moment I was
> puzzling as to how come this is passing dist-check when the added sources are
> missing in the release tarball, but then realized the added tests are not
> getting run in _our_ test-suite. Which to me kinda steps
Any new sources need to be EXTRA_DIST in Makefile.am's. For a moment I was
puzzling as to how come this is passing dist-check when the added sources are
missing in the release tarball, but then realized the added tests are not
getting run in *our* test-suite. Which to me kinda steps over a
@Conan-Kudo commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the
@Conan-Kudo commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group =
> Maybe there might be a compromise by having a separate repo in the
> rpm-software-management namespace?
That could be an option, and would be absolutely fine by me if it makes sense
for the Python "SIG" around here. rpm-extras was supposed to be the place for
scripts like these, but it's not
@torsava commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group =
@torsava pushed 1 commit.
96be70abdb8f5b7633fb41829a8b5d496a466e03 fixup! scripts/pythondistdeps: Add
option to generate major-version provides only for specified Python versions
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@torsava commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the commit
This pull request **introduces 1 alert** when merging
96be70abdb8f5b7633fb41829a8b5d496a466e03 into
9a30bcdacca365a6d8c4078dc6b6f8014d31d66f - [view on
LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-37240692b220d858f7c84048312ded371ecb5b9f)
**new alerts:**
* 1 for
@torsava pushed 1 commit.
e7cc87a083366439c0450c720ed36475b09d fixup! scripts/pythondistdeps: Add
the tests to the readme and makefile
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@torsava commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the commit
This pull request **introduces 1 alert** when merging
e7cc87a083366439c0450c720ed36475b09d into
9a30bcdacca365a6d8c4078dc6b6f8014d31d66f - [view on
LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-6a72d51c59c7dece06617335d467976326e344fd)
**new alerts:**
* 1 for
@hroncok commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the commit
@Conan-Kudo commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the
> Any new sources need to be EXTRA_DIST in Makefile.am's.
I've added the checked-in files to the `EXTRA_DIST` in the fixup commit. I
didn't add the automatically-downloaded metadata, as the test script will
automatically fetch them if missing. If it's desirable to have them inside
EXTRA_DIST
@torsava commented on this pull request.
> @@ -11,6 +11,10 @@
# RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
#
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+# 2020 can be found in the message of the commit
35 matches
Mail list logo
