Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Replace gzip/bzip2/xz with pigz/pbzip2/pxz for multicore (#126)
As the multithreaded (de)compression support for pigz isn't implemented in the binary, the benefits from aren't really there as it won't be possible to implement multithreaded (de)compression for using in the rpmio library. Same goes for pbzip2. For xz, multithreaded compression support has been implemented into liblzma and since added to librpmio xz payload support. Unless pxz supports parallell decompression (IIRC it does't, I borrowed the code for the initial python liblzma extension, where the support for was implemented through use of openmp. Then again, as support was implemented by compressing every block in separate thread, one might imagine that multithreaded compression would be possibly by doing -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/126#issuecomment-272426714___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Replace gzip/bzip2/xz with pigz/pbzip2/pxz for multicore (#126)
Closed #126. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/126#event-922126663___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Replace gzip/bzip2/xz with pigz/pbzip2/pxz for multicore (#126)
@pmatilai , Sorry for the inconvenience caused to you. I will propose the a PR after finding the complete solution to support xz as well as gzip/bzip2. This WIP will be closed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/126#issuecomment-272422896___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Replace gzip/bzip2/xz with pigz/pbzip2/pxz for multicore (#126)
ldv-alt requested changes on this pull request. The idea is wrong: you cannot *replace* gzip, bzip2, and xz because they are much more widespread. The implementation is wrong: it does not achieve the declared goal. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/126#pullrequestreview-16543932___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Replace gzip/bzip2/xz with pigz/pbzip2/pxz for multicore (#126)
After wasting time looking at the obviously completely untested patch against an imaginary library in PR #117 ... to put it really really politely, I'm not in a very positive mood towards this work. I'm not going to look at a single patch until you show me some numbers to back up the change, for each compression type/program separately on traditional spinning harddisk, SSD numbers as an added bonus. In rpmbuild context to show you've actually tested it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/126#issuecomment-272401511___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
