Re: [Rpm-maint] [rpm-software-management/rpm] Better detection of I/O errors (#1566)
Merged #1566 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1566#event-4460234433___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Better detection of I/O errors (#1566)
Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1566#issuecomment-799620888___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Better detection of I/O errors (#1566)
@DemiMarie pushed 1 commit. ecb2a94bc31ca18722f0331c92933af81df59f30 Better detection of I/O errors -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1566/files/d1d2dde4aa58ba64a9429b4be8e57d03839ca901..ecb2a94bc31ca18722f0331c92933af81df59f30 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Better detection of I/O errors (#1566)
Done -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1566#issuecomment-799612887___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Better detection of I/O errors (#1566)
Oh, indeed. Thanks for spotting this! Also kudos for checking for the `fprintf()` return value - although it still returns a positive value in case of an `ENOSPC`, there could be other errors, so why not check for them right away. That said, I realized I should've moved the `free(val)` statement above the new conditional in my original patch. So while at it, could you please incorporate that, too? Either storing the return value of `fprintf()` in a variable and then doing the `free(val)`, or just putting another `free(val)` call just before the `exit(EXIT_FAILURE)` statement should be fine. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1566#issuecomment-799603408___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
