Re: [Rpm-maint] [rpm-software-management/rpm] Error if a macro in a comment is expanded to multiple lines (#124)

2017-02-24 Thread Florian Festi
Closed #124. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/124#event-975979205___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Error if a macro in a comment is expanded to multiple lines (#124)

2017-02-24 Thread Florian Festi
While there is a real issue here. The proposed solution is not quite right. Making commenting out a multiline macro illegal is kida silly. Still this need some solution. We opened #158 for discussing this issue and to come up with a better solution. Still thank you very much for your work and

Re: [Rpm-maint] [rpm-software-management/rpm] Error if a macro in a comment is expanded to multiple lines (#124)

2017-01-13 Thread Panu Matilainen
pmatilai commented on this pull request. rpmlog(RPMLOG_ERR, ...) does not stop the build any more than the rpmlog(RPMLO_WARNING, ...) does a few lines below. As you should've noticed when testing it. Another possible (not saying it's good or what I want, just enumerating) approach would be

Re: [Rpm-maint] [rpm-software-management/rpm] Error if a macro in a comment is expanded to multiple lines (#124)

2017-01-12 Thread Igor Gnatenko
I like idea of this patchset. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/124#issuecomment-272172751___ Rpm-maint mailing