[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 Nicolas Chauvet changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 Ben Rosser changed: What|Removed |Added Blocks|3 |4 Flags|fedora-review? |fedora-review+ --- Comment #8 from Ben Rosser --- Great! Other rpmlint output looks sane: qtox.x86_64: W: only-non-binary-in-usr-lib qtox.x86_64: W: no-manual-page-for-binary qtox qtox-debugsource.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Everything else seems to look good as well. Package is APPROVED. Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=3 [Bug 3] Tracker: Packages under review. https://bugzilla.rpmfusion.org/show_bug.cgi?id=4 [Bug 4] Tracker: Accepted packages. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #7 from Robert-André Mauchin --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/494f927/qtox.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00719747-qtox/qtox-1.13.0-2.fc28.src.rpm SPEC diff: https://github.com/eclipseo/packaging/commit/494f92793cbee6be488c00b653ff9740a5243edb#diff-932a19a3821f6280b49127cc886044f2 It should be good now. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 Ben Rosser changed: What|Removed |Added Blocks|2 |3 Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2 [Bug 2] Tracker: New packages awaiting review https://bugzilla.rpmfusion.org/show_bug.cgi?id=3 [Bug 3] Tracker: Packages under review. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #6 from Ben Rosser --- Great, glad the licensing issue is resolved. In addition to the icons, licensecheck says that there are some BSD files in the source tree too: > qTox-1.13.0/src/widget/flowlayout.cpp: BSD (3 clause) > qTox-1.13.0/src/widget/flowlayout.h: BSD (3 clause) So I guess you should add an "and BSD" to the license tag. rpmlint also complains about a gzipped SVG file: qtox.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/qtox.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. So I would unzip the file and install it as plain SVG, like the message says. Otherwise I think the passage looks good. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 Ben Rosser changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #5 from Robert-André Mauchin --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/1db7d19/qtox.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00716506-qtox/qtox-1.13.0-2.fc28.src.rpm SPEC diff: https://github.com/eclipseo/packaging/commit/1db7d19090bee6655024d5bf10069c6ac2bedb32#diff-932a19a3821f6280b49127cc886044f2 I added the correct licenses for the smileys and refreshed the SPEC file a bit (removed old scriplets and move Appdata file to the correct location). -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #4 from Robert-André Mauchin --- I manage to get the smileys to be CC-BY-SA https://github.com/qTox/qTox/pull/4956 -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #3 from Robert-André Mauchin --- I should add CC BY for others icons packs anyway. I've asked upstream for a relicensing: https://github.com/qTox/qTox/issues/4954 I don't really want to put this in non-free for a handful of icons. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #2 from Ben Rosser --- Doing some initial checking. It looks as if there are some CC-BY-NC licensed files... I don't know exactly what this means for the package. qTox-1.13.0/smileys/Classic/angry.png: CC by-nc qTox-1.13.0/smileys/Classic/cool.png: CC by-nc qTox-1.13.0/smileys/Classic/crying.png: CC by-nc qTox-1.13.0/smileys/Classic/happy.png: CC by-nc qTox-1.13.0/smileys/Classic/laugh.png: CC by-nc qTox-1.13.0/smileys/Classic/laugh_closed_eyes.png: CC by-nc qTox-1.13.0/smileys/Classic/plain.png: CC by-nc qTox-1.13.0/smileys/Classic/sad.png: CC by-nc qTox-1.13.0/smileys/Classic/scared.png: CC by-nc qTox-1.13.0/smileys/Classic/smile.png: CC by-nc qTox-1.13.0/smileys/Classic/stunned.png: CC by-nc qTox-1.13.0/smileys/Classic/tongue.png: CC by-nc qTox-1.13.0/smileys/Classic/uncertain.png: CC by-nc qTox-1.13.0/smileys/Classic/wink.png: CC by-nc Are these used in the package? They don't appear in the RPM itself, but given that they are referenced in smileys/smileys.qrc, I'm assuming they get compiled into the binary. If nothing else, I would think this makes the package "nonfree" and not "free". But I don't know for sure... I've asked on IRC for clarification. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 Ben Rosser changed: What|Removed |Added CC||rosser@gmail.com Assignee|rpmfusion-package-review@rp |rosser@gmail.com |mfusion.org | -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4769] Review Request: qtox - Feature-rich Tox client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4769 --- Comment #1 from Robert-André Mauchin --- Koji scratch build: http://koji.rpmfusion.org/koji/taskinfo?taskID=191843 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
