Re: MD4 bug in rsync for lengths = 64 * n

2002-09-03 Thread Donovan Baarda
On Mon, Sep 02, 2002 at 12:44:48AM -0700, Craig Barratt wrote: [...] I can submit patches if required for the md4code as tweaked/fixed for librsync. The fixed code is faster as well as correct :-) Sure, that would be great. Otherwise, I would be happy to recreate and test a patch. I

Re: MD4 bug in rsync for lengths = 64 * n

2002-09-03 Thread Dave Dykstra
Donovan or Craig, can you please post it as a patch to the current rsync source (including an increase in the protocol version and checks to do the old behavior when talking to an old version client). Probably we wouldn't want to incorporate it until a major release anyway (2.6.0) but if it

Re: MD4 bug in rsync for lengths = 64 * n

2002-09-03 Thread Donovan Baarda
Quoting Dave Dykstra [EMAIL PROTECTED]: Donovan or Craig, can you please post it as a patch to the current rsync source (including an increase in the protocol version and checks to do the old behavior when talking to an old version client). I'm not the person to do this, as I don't know

Re: MD4 bug in rsync for lengths = 64 * n

2002-09-02 Thread Craig Barratt
This is the first detailed description of the problem I've seen. I've heard it mentioned several times before, and thought that the md4 code in librsync was the same as in rsync. I've looked and tweaked the md4 code in librsync and could never see the bug so I thought it was a myth. I also

Re: MD4 bug in rsync for lengths = 64 * n

2002-09-01 Thread Donovan Baarda
On Thu, Aug 29, 2002 at 03:17:34PM -0500, Dave Dykstra wrote: On Sun, Aug 04, 2002 at 01:19:43PM -0700, Craig Barratt wrote: [...] However, as I'm sure is well-known, the Adler crc32 and MD4 computed by librsync don't match those in rsync 2.5.5. I do not recall hearing anybody mention

Re: MD4 bug in rsync for lengths = 64 * n

2002-08-29 Thread Dave Dykstra
On Sun, Aug 04, 2002 at 01:19:43PM -0700, Craig Barratt wrote: I am the author of BackupPC (http://backuppc.sourceforge.net) and I am working on adding rsync support to BackupPC. I am implementing the server-side in perl, and the client will run vanilla rsync. (BTW, is there the protocol