Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-29 Thread Adam Tingle
On Thu, Jan 29, 2009 at 7:26 PM, Jo Rhett wrote: > On Jan 29, 2009, at 10:01 AM, Jerrad Pierce wrote: > >> I don't think this should be merged into base, as it promotes top-posting. >> > > The patch adds blank lines before the signature. The signature is at the > bottom of the message... > > Th

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-29 Thread Jo Rhett
On Jan 29, 2009, at 10:01 AM, Jerrad Pierce wrote: > I don't think this should be merged into base, as it promotes top- > posting. The patch adds blank lines before the signature. The signature is at the bottom of the message... The only time this would qualify as "top-posting" is when the r

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-29 Thread Mike Peachey
Jerrad Pierce wrote: > I don't think this should be merged into base, as it promotes top-posting. Not to be a "me-too" or anything, but I want to whole-heartedly agree with the above. Top-posting has seriously gotten out of hand (thanks Outlook(!!)) and should be discouraged at all times. -- Kin

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-29 Thread Jerrad Pierce
I don't think this should be merged into base, as it promotes top-posting. ___ http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users Community help: http://wiki.bestpractical.com Commercial support: sa...@bestpractical.com Discover RT's hidd

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-29 Thread Jesse Vincent
On Wed, Jan 28, 2009 at 11:54:41PM -0800, Jo Rhett wrote: > In specific, I believe that this would be the better patch: Jo, lib/RT/Interface/Web.pm sub ProcessUpdateMessage is the code I was thinking of. -jesse > > --- html/Elements/MessageBox_orig 2009-01-28 23:48:34.0 >

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-28 Thread Jo Rhett
In specific, I believe that this would be the better patch: --- html/Elements/MessageBox_orig 2009-01-28 23:48:34.0 -0800 +++ html/Elements/MessageBox2009-01-28 23:48:45.0 -0800 @@ -60,7 +60,7 @@ my $signature = ''; if ( $IncludeSignature and my $text = $session{'C

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-28 Thread Jo Rhett
This is patching the wrong way, but it's the right decision. I'm hating having to manually move the cursor in front of the signature and end a newline before typing. I think the right patch would be to add the whitespace at the same place that "-- \n" is added to the beginning of the signa

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-28 Thread Adam Tingle
Thanks for the heads-up, but how does the empty reply detection work? It doesn't seem to do anything if I remove the patch. I click reply, click update ticket, and my 'empty reply' is recorded. Is it an option I have to turn on? - Adam On Wed, Jan 28, 2009 at 10:58 PM, Jesse Vincent wrote: > Be

Re: [rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-28 Thread Jesse Vincent
Be careful. This patch will break rt's empty reply detection. Adam Tingle wrote: >Hi rt-users, > >Here's a quick patch I made to add some whitespace to the top of the message >when replying to a message. It makes it easier to just start typing if you >have FCKeditor set to StartupFocus. > > >---

[rt-users] UI Patch - Add whitespace at top of MessageBox if it's a reply/comment

2009-01-28 Thread Adam Tingle
Hi rt-users, Here's a quick patch I made to add some whitespace to the top of the message when replying to a message. It makes it easier to just start typing if you have FCKeditor set to StartupFocus. --- MessageBox 2009-01-28 21:37:01.0 -0500 +++ /usr/local/share/request-tracker3.8/htm