[rtc-linux] Re: [PATCH] rtc: asm9260: fix module autoload

2016-10-19 Thread Alexandre Belloni
; alias: of:N*T*Calphascale,asm9260-rtc > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> > --- > > drivers/rtc/rtc-asm9260.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedd

[rtc-linux] Re: [PATCH v3] rtc-cmos: Reject unsupported alarm values

2016-10-19 Thread Alexandre Belloni
t; > --- > drivers/rtc/rtc-cmos.c | 72 > ++ > 1 file changed, 72 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because

[rtc-linux] Re: [PATCH 1/1] rtc: add century field data boundary

2016-10-19 Thread Alexandre Belloni
inux/mc146818rtc.h b/include/linux/mc146818rtc.h > index a585b4b..199065a 100644 > --- a/include/linux/mc146818rtc.h > +++ b/include/linux/mc146818rtc.h > @@ -122,6 +122,8 @@ struct cmos_rtc_board_info { > #define RTC_IO_EXTENT_USED RTC_IO_EXTENT > #endif /* ARCH_RTC_LOCATION */ > &g

[rtc-linux] Re: [PATCH] rtc: add support for rtc NXP pca21125

2016-10-18 Thread Alexandre Belloni
PCA21125_STATUS_REG, ); > + dev_info(>dev, "PCA21125 RTC Status Reg = 0x%02x\n", data); > + ditto > + rtc = devm_rtc_device_register(>dev, "pca21125", > + _rtc_ops, > THIS_MODULE

[rtc-linux] Re: [4.9-rc1] kernel panic from `cat /proc/driver/rtc`

2016-10-18 Thread Alexandre Belloni
- > > From: "CAI Qian" <caiq...@redhat.com> > > To: rtc-linux@googlegroups.com, "linux-kernel" > > <linux-ker...@vger.kernel.org> > > Cc: "Alessandro Zummo" <a.zu...@towertech.it>, "Alexandre Belloni" > >

[rtc-linux] [GIT PULL] RTC fixes for 4.9

2016-11-14 Thread Alexandre Belloni
/rtc/rtc-cmos.c| 15 --- drivers/rtc/rtc-omap.c| 38 ++ 3 files changed, 39 insertions(+), 15 deletions(-) -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message

[rtc-linux] Re: [PATCH 1/2] drivers: rtc: rtc-tps65910: Add RTC calibration support

2016-11-25 Thread Alexandre Belloni
On 25/11/2016 at 13:20:05 +0200, Vesa Jääskeläinen wrote : > On 2016-11-25 12:32, Alexandre Belloni wrote: > > Hi, > > > > On 25/11/2016 at 11:52:17 +0200, Vesa Jääskeläinen wrote : > > > Texas Instrument's TPS65910 has support for compensating RTC crystal > >

[rtc-linux] Re: [PATCH 1/2] drivers: rtc: rtc-tps65910: Add RTC calibration support

2016-11-25 Thread Alexandre Belloni
f (ret < 0) { > + dev_err(>dev, "Failed to register to sysfs\n"); > + return ret; > + } > + > return 0; > } > > @@ -294,6 +412,8 @@ static int tps65910_rtc_probe(struct platform_device > *pdev) > */ > static in

[rtc-linux] Re: [PATCH] rtc: rtc-ds3232: add device tree support

2016-11-28 Thread Alexandre Belloni
On 28/11/2016 at 08:31:20 +, Peter Robinson wrote : > On Mon, Nov 28, 2016 at 8:24 AM, Alexandre Belloni > <alexandre.bell...@free-electrons.com> wrote: > > Hi, > > > > On 28/11/2016 at 07:06:44 +, Peter Robinson wrote : > >> Set the of_match_ta

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Alexandre Belloni
add a warning for the user in this case ? > > There is exactly one driver ever checking the return value of device_init_wakeup(). It basically always succeeds. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because

[rtc-linux] Re: [PATCH v3] rtc: add support for EPSON TOYOCOM RTC-7301SF/DG

2016-12-07 Thread Alexandre Belloni
Artix7 FPGA board with my own > custom IP for RTC-7301. > > Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com> > Acked-by: Rob Herring <r...@kernel.org> > Cc: Alessandro Zummo <a.zu...@towertech.it> > Cc: Alexandre Belloni <alexandre.bell...@free-electrons

[rtc-linux] Re: [PATCH] rtc: ds1374: Merge conditional + WARN_ON()

2016-12-07 Thread Alexandre Belloni
1 insertion(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.googl

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Alexandre Belloni
+ return PTR_ERR(rtc->base); > + > + dbp = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "st,syscfg"); > + if (IS_ERR(dbp)) { > + dev_err(>dev, "no st,syscfg\n"); > + return PTR_ERR(dbp); > + } > + > + spin_lock

[rtc-linux] Re: [PATCH v2 0/6] Provides bug fixes for rtc-mcp795.c

2016-12-07 Thread Alexandre Belloni
- > 1 file changed, 100 insertions(+), 22 deletions(-) > All applied, thanks! -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership optio

[rtc-linux] Re: [PATCH 1/3] rtc: stm32: remove __exit annotation on remove callback

2017-01-13 Thread Alexandre Belloni
> drivers/rtc/rtc-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Members

[rtc-linux] Re: [PATCHv3 3/8] rtc: add STM32 RTC driver

2017-01-10 Thread Alexandre Belloni
tm is already checked multiple times (up to three) in the core before this function can be called. > + } > + You don't need to resend the whole series, just this patch. I'll take 2/8 and 3/8, the other ones can go through the stm32 tree. -- Alexandre Belloni, Free Electrons Embedded Linux and

[rtc-linux] Re: [PATCH] rtc: add const to rtc_class_ops structures

2017-01-10 Thread Alexandre Belloni
pilation was terminated while compiling the .o files for all the > changed .c files. Therefore file size details of the .o files > could not be obtained. > > drivers/rtc/rtc-au1xxx.c | 2 +- > drivers/rtc/rtc-bfin.c | 2 +- > drivers/rtc/rtc-ls1x.c | 2 +- > drivers/rtc/rtc-s

[rtc-linux] Re: [PATCH v3] rtc: armada38x: Follow the new recommendation for errata implementation

2017-01-09 Thread Alexandre Belloni
gt; - Then I optimize the way to find the correct value. > > Gregory > > drivers/rtc/rtc-armada38x.c | 118 > +++- > 1 file changed, 95 insertions(+), 23 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Em

[rtc-linux] Re: [PATCH v2 0/2] Provides support for alarm.

2017-01-09 Thread Alexandre Belloni
arm on weekday, how awful... Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . P

[rtc-linux] Re: [PATCH v3 1/2] drivers: rtc: rtc-tps65910: Add RTC calibration support

2017-01-09 Thread Alexandre Belloni
terface > > drivers/rtc/rtc-tps65910.c | 143 > +++ > include/linux/mfd/tps65910.h | 1 + > 2 files changed, 144 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this mes

[rtc-linux] Re: [PATCH v3 2/2] drivers: rtc: rtc-tps65910: use 'unsigned int' instead of 'unsigned' in arguments

2017-01-09 Thread Alexandre Belloni
file changed, 2 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.googl

[rtc-linux] Re: [PATCHv5 3/8] rtc: add STM32 RTC driver

2017-01-12 Thread Alexandre Belloni
your patches on 4.9 instead of 4.10-rc1. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http:

[rtc-linux] Re: [PATCH] rtc: armada38x: avoid unused-function warning

2017-01-12 Thread Alexandre Belloni
ce *dev) > { > if (device_may_wakeup(dev)) { > struct armada38x_rtc *rtc = dev_get_drvdata(dev); > @@ -363,7 +362,6 @@ static int armada38x_rtc_resume(struct device *dev) > > return 0; > } > -#endif > > static SIMPLE_DEV_PM_OPS(armada38

[rtc-linux] Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro

2017-01-13 Thread Alexandre Belloni
's no longer a simple expression. > Yes, at least checkpatch complains about it. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at

[rtc-linux] Re: [PATCH 3/3] Documentation: dt: rtc-imxdi: security violation interrupt

2017-01-10 Thread Alexandre Belloni
1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read htt

[rtc-linux] Re: [PATCHv3 3/8] rtc: add STM32 RTC driver

2017-01-11 Thread Alexandre Belloni
On 11/01/2017 at 11:42:50 +0100, Amelie DELAUNAY wrote : > > On 01/11/2017 11:17 AM, Alexandre Belloni wrote: > > On 11/01/2017 at 11:07:16 +0100, Amelie DELAUNAY wrote : > > > > This will never happen, tm is already checked multiple times (up to > > > > thr

[rtc-linux] Re: [PATCH] rtc: add support for EPSON TOYOCOM RTC-7301SF/DG

2016-11-30 Thread Alexandre Belloni
rtc7301_alarm_irq(priv, false); > + If the RTC is battery backed, it may still run with the core power off and maybe someone will actually expect the alarm to trigger at a later time. I don't mind much as you are probably the only user anyway. -- Alexandre Belloni, Free Electrons Embed

[rtc-linux] Re: [PATCH v2 0/2] rtc: rtc-twl: cleanup

2016-11-30 Thread Alexandre Belloni
nly > > drivers/rtc/Kconfig | 1 + > drivers/rtc/rtc-twl.c | 202 > ++ > 2 files changed, 122 insertions(+), 81 deletions(-) > Both applied, thanks -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.

[rtc-linux] Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Alexandre Belloni
& 0x0f); > > > tim->tm_mday= ((data[4] & 0x30) >> 4) * 10 + (data[4] & 0x0f); > > > - tim->tm_mon = ((data[5] & 0x10) >> 4) * 10 + (data[5] & > > > 0x0f); > > > + tim->tm_mon = ((data[5] & 0x10) >> 4) *

[rtc-linux] Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1.

2016-12-05 Thread Alexandre Belloni
value 0. > What do you think? > That is one way but maybe some people are setting that bit in the bootloader. It doesn't matter much. If you are not using the feature, let it that way. If anybody needs it at some point they can still send a patch :) -- Alexandre Belloni, Free Electro

[rtc-linux] Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Alexandre Belloni
tim->tm_mday= ((data[4] & 0x30) >> 4) * 10 + (data[4] & 0x0f); > - tim->tm_mon = ((data[5] & 0x10) >> 4) * 10 + (data[5] & > 0x0f); > + tim->tm_mon = ((data[5] & 0x10) >> 4) * 10 + (data[5] & 0x0f); All tho

[rtc-linux] Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1.

2016-12-05 Thread Alexandre Belloni
; + if (!(data & MCP795_OSCON_BIT)) > + break; > + > + } while (--retries); > + > + return !retries ? -EIO : ret; > +} > + > +static int mcp795_start_oscillator(struct device *dev) > +{ > + return mcp795_rtcc_set_bits(dev, MCP795_REG_S

[rtc-linux] Re: [PATCH 1/2] drivers: rtc: rtc-tps65910: Add RTC calibration support

2016-11-30 Thread Alexandre Belloni
On 28/11/2016 at 16:42:05 +0200, Vesa Jääskeläinen wrote : > On 2016-11-25 17:37, Alexandre Belloni wrote: > > On 25/11/2016 at 13:20:05 +0200, Vesa Jääskeläinen wrote : > > > On 2016-11-25 12:32, Alexandre Belloni wrote: > > > > Hi, > > > > >

Re: [rtc-linux] Re: [RFC PATCH 2/3] rtc: Add Amlogic Virtual Wake RTC

2016-11-30 Thread Alexandre Belloni
e the kernel. I think it may be fine to handle that in the RTC subsystem for now. The same issue can be seen with the flextimer on LS1021A: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/365597.html -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel enginee

[rtc-linux] Re: [PATCH v2 1/1] rtc: rx8010: change lock mechanism

2017-01-04 Thread Alexandre Belloni
3:~# > Message from syslogd@GE004097290448 at Dec 3 11:17:08 ... > kernel:[ 82.108175] BUG: spinlock wrong CPU on CPU#0, hwclock/855 > > Message from syslogd@GE004097290448 at Dec 3 11:17:08 ... > kernel:[ 82.113660] lock: 0xedb4899c, .magic: dead4ead, .owner: > hwclock/855,

[rtc-linux] Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops

2017-01-04 Thread Alexandre Belloni
ile_operations pointer in the kernel, or the thousand other operations > > > structure pointers that a running kernel has. > > I'm not sure to understand the question and the response. A quick check > with grep suggests that most rtc_class_ops pointers are already const. >

Re: [rtc-linux] [PATCH] rtc: Add support for RX4035

2017-01-04 Thread Alexandre Belloni
date[RX4035_REG_DW] & 0x7F; > + tm->tm_mday = bcd2bin(date[RX4035_REG_DM] & 0x3F); > + tm->tm_mon = bcd2bin(date[RX4035_REG_MO] & 0x1F) - 1; /* rtc mn 1-12 */ > + tm->tm_year = bcd2bin(date[RX4035_REG_YR]); > + if (tm->tm_year < 70) > +

[rtc-linux] Re: [PATCH v2] rtc: armada38x: Followed the new recommendation for errata implementation

2016-12-20 Thread Alexandre Belloni
{ > @@ -260,6 +329,7 @@ static __init int armada38x_rtc_probe(struct > platform_device *pdev) > dev_err(>dev, "Failed to register RTC device: %d\n", ret); > return ret; > } > + Unrelated change. > return 0; > } > > @@ -280,6 +350,9 @

[rtc-linux] Re: [PATCH v2] rtc: armada38x: Followed the new recommendation for errata implementation

2016-12-21 Thread Alexandre Belloni
On 21/12/2016 at 10:02:54 +0100, Gregory CLEMENT wrote : > Hi Alexandre, > > On mer., déc. 21 2016, Alexandre Belloni > <alexandre.bell...@free-electrons.com> wrote: > > > I agree with all your remark expect one, see below: > [...] > >>

[rtc-linux] Re: [PATCH v2 2/2] drivers: rtc: rtc-tps65910: use 'unsigned int' instead of 'unsigned' in arguments

2016-12-18 Thread Alexandre Belloni
_MULT (10LL) > > -static int tps65910_rtc_alarm_irq_enable(struct device *dev, unsigned > enabled) > +static int tps65910_rtc_alarm_irq_enable(struct device *dev, > + unsigned int enabled) > { > struct tps65910 *tps = dev_get_drvdata(de

[rtc-linux] Re: [PATCH v2 0/2] drivers: rtc: rtc-tps65910: Add RTC calibration support

2016-12-18 Thread Alexandre Belloni
On 19/12/2016 at 01:38:54 +0100, Alexandre Belloni wrote : > On 11/12/2016 at 00:21:02 +0200, Vesa Jääskeläinen wrote : > > > > On 2016-12-10 23:50, Vesa Jääskeläinen wrote: > > > Texas Instrument's TPS65910 has support for compensating RTC crystal > > > inaccura

Re: [rtc-linux] [PATCH] rtc: pcf8563: Do not disable clk out by default

2016-12-18 Thread Alexandre Belloni
s rtc node. > Actually, the commit description is misleading. The CCF is the one disabling the clock if it is not used. If any user of the clock is declared, it will not be disabled so it already works in both cases (provided you have a proper driver getting the clock). -- Alexandre Belloni, F

[rtc-linux] Re: [PATCH 2/2] rtc: jz4740: make the driver builtin only

2016-12-19 Thread Alexandre Belloni
Hi, On 19/12/2016 at 09:03:17 +0100, Geert Uytterhoeven wrote : > On Wed, Nov 9, 2016 at 1:37 AM, Alexandre Belloni > <alexandre.bell...@free-electrons.com> wrote: > > Since the driver is now calling machine_halt() that is not exported, it has > > to be built

[rtc-linux] Re: [PATCH 1/2] rtc: imxdi: (trivial) fix a typo

2016-12-07 Thread Alexandre Belloni
On 19/11/2016 at 14:03:33 +0100, Martin Kaiser wrote : > Signed-off-by: Martin Kaiser <mar...@kaiser.cx> > --- > drivers/rtc/rtc-imxdi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Ke

[rtc-linux] Re: [PATCH 2/2] rtc: imxdi: use the security violation interrupt

2016-12-07 Thread Alexandre Belloni
platform_set_drvdata(pdev, imxdi); > imxdi->rtc = devm_rtc_device_register(>dev, pdev->name, > _rtc_ops, THIS_MODULE); > -- > 1.7.10.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electr

[rtc-linux] Re: [PATCH V1] rtc: ds1307: Add ACPI support

2016-12-07 Thread Alexandre Belloni
sertions(+), 8 deletions(-) > Applied after fixing a few alignment issues, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at htt

[rtc-linux] Re: Question: Linux changes required for off control board RTC

2017-03-21 Thread Alexandre Belloni
? > The kernel will work, the RTC is not required. > 4) Is there a configurable kernel option to allow for such a change, > or have these or similar changes already been added to the kernel? > More details are needed to answer that but basically if your FPGa emulates an RTC that is

[rtc-linux] Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules

2017-03-26 Thread Alexandre Belloni
to use devm_*()" has been > verified on 96boards Hikey. Other patches can pass building but have > not really tested on hardware. > If your plan is to actually remove usage of amba_request_regions() and amba_release_regions(), you should do so in its own patch sets instead of hiding

[rtc-linux] Re: [PATCH 1/5] rtc: rtc-sh: add support for rza series

2017-03-17 Thread Alexandre Belloni
Mostly good, one nitpick: On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote: > res = platform_get_resource(pdev, IORESOURCE_IO, 0); > + if (res == NULL) if (!res) is preferred here -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electro

[rtc-linux] Re: [PATCH 3/5] ARM: dts: r7s72100: add rtc clock to device tree

2017-03-17 Thread Alexandre Belloni
lock.h > index cd2ed51..bc256d3 100644 > --- a/include/dt-bindings/clock/r7s72100-clock.h > +++ b/include/dt-bindings/clock/r7s72100-clock.h > @@ -29,6 +29,9 @@ > #define R7S72100_CLK_OSTM0 1 > #define R7S72100_CLK_OSTM1 0 > > +/* MSTP6 */ > +#define R7S7

[rtc-linux] Re: [PATCH 2/5] rtc: Add rtc-sh

2017-03-17 Thread Alexandre Belloni
e them in the future. > E.g. to select among X1, X3, or EXTAL, depending on availability. > I'm on Geert's side here, I wouldn't rely on the bootloader to set everything up correctly. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You recei

[rtc-linux] Re: [PATCH 2/5] rtc: Add rtc-sh

2017-03-20 Thread Alexandre Belloni
stuff go if not in the DT? > If you want you can leave the clock selection logic out of the driver as long as the DT binding is complete. You dont have to use everything that is described in the DT. Regarding the selection, I'd say take the first that is present and not 0 however, if something has

[rtc-linux] Re: [PATCH] rtc: rtc-wm8350: Remove unused to_wm8350_from_rtc_dev

2017-03-16 Thread Alexandre Belloni
, 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read

[rtc-linux] Re: [PATCH v3 0/7] rtc: Reuse rtc-sh driver to support RZ/A1

2017-04-03 Thread Alexandre Belloni
s: rtc: document the rtc-sh bindings I applied those two, I'll let Simon take the device tree patches. Thanks! > ARM: dts: r7s72100: add rtc clock to device tree > ARM: dts: r7s72100: add RTC_X clock inputs to device tree > ARM: dts: r7s72100: add rtc to device tree > ARM:

[rtc-linux] [PATCH] rtc: ds1307: Add m41t0 to OF device ID table

2017-04-08 Thread Alexandre Belloni
m41t0 was added to the I2C device ID table but not the OF table. Fix that. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-ds1307.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c

[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-13 Thread Alexandre Belloni
> +EXPORT_SYMBOL_GPL(legacy_pic); > > static int __init i8259A_init_ops(void) > { > -- > 2.9.3 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-

[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-14 Thread Alexandre Belloni
BOL > --- > arch/x86/kernel/i8259.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux&quo

[rtc-linux] [PATCH] rtc: m41t80: Add proper compatible for rv4162

2017-04-19 Thread Alexandre Belloni
The correct compatible for the rv4162 (microcrystal,rv4162) was not used upstream and so was not added by eb235c561d04e. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-m41t80.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/r

[rtc-linux] Re: [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ

2017-04-22 Thread Alexandre Belloni
s1307_can_wakeup_device)) { irq_handler = mcp794xx_irq; This seems right but your mailer as mangled the patch. Can you resend? > want_irq = true; > } -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electron

[rtc-linux] Re: [PATCH] rtc: sh: mark PM functions as unused

2017-04-22 Thread Alexandre Belloni
there is no reference. > > Fixes: dab5aec64bf5 ("rtc: sh: add support for rza series") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > drivers/rtc/rtc-sh.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Bel

[rtc-linux] Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are missing it

2017-03-03 Thread Alexandre Belloni
On 03/03/2017 at 12:27:23 -0300, Javier Martinez Canillas wrote: > On 03/03/2017 12:01 PM, Alexandre Belloni wrote: > > On 03/03/2017 at 11:29:11 -0300, Javier Martinez Canillas wrote: > >> This series add OF device ID tables to RTC I2C drivers whose devices are > >>

[rtc-linux] Re: Kernel without RTC

2017-03-08 Thread Alexandre Belloni
e source so it can already work without an RTC. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux

[rtc-linux] Re: [PATCHv4 1/2] dt-bindings: Add vendor prefix for Motorola

2017-03-08 Thread Alexandre Belloni
Herring > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscri

[rtc-linux] Re: [PATCH] rtc: omap: mark PM methods as __maybe_unused

2017-03-08 Thread Alexandre Belloni
khov <dmitry.torok...@gmail.com> > --- > drivers/rtc/rtc-omap.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received thi

[rtc-linux] Re: [PATCHv4 2/2] rtc: cpcap: new rtc driver

2017-03-08 Thread Alexandre Belloni
| 1 + > drivers/rtc/rtc-cpcap.c| 332 > + > 4 files changed, 358 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/cpcap-rtc.txt > create mode 100644 drivers/rtc/rtc-cpcap.c > Applied, thanks. -- Alexa

Re: [rtc-linux] RTC used as a module

2017-03-03 Thread Alexandre Belloni
if in this situation > driver should be modular or not. > If driver can be modular then somewhere should be put_device(). > >From a quick look, I'd say the issue is coming from 8bc0dafb5cf38a19484dfb16e2c6d29e85820046 which removed the call to rtc_class_open so you can actually unload t

[rtc-linux] Re: [PATCH] rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs

2017-04-08 Thread Alexandre Belloni
e Goede <hdego...@redhat.com> > --- > drivers/rtc/rtc-cmos.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received th

[rtc-linux] Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq

2017-04-08 Thread Alexandre Belloni
Cc: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Tony Lindgren <t...@atomide.com> > --- > drivers/rtc/rtc-cpcap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c Applied, thanks. -- Alex

[rtc-linux] Re: [PATCH] rtc: ds1374: Add trickle charger device tree binding

2017-04-24 Thread Alexandre Belloni
thing, > make setting the timeout actually work (right now it the timeout to > tick conversion is > hosed). > I think I would do something with MFD as you were suggesting on IRC. You can have a look at the flexcom driver (atmel-flexcom.c) which is simply selecting a mode and then using whatev

[rtc-linux] Re: [RFC] rtc: ds1307: add square wave output from ds1308

2017-07-31 Thread Alexandre Belloni
S1308_BIT_BBCLK); That should not be needed, the CCF will disable any unused clock. > case ds_1338: > /* clock halted? turn it on, so clock can tick. */ > if (tmp & DS1307_BIT_CH) > -- > 2.13.3 > -- Alexandre Belloni, Free Electrons Embedd

[rtc-linux] Re: [PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug

2017-07-09 Thread Alexandre Belloni
6 > 4 files changed, 212 insertions(+), 16 deletions(-) > create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c > Applied, thanks. I've fixed up the date to meaningful ones in patch 2. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engi

[rtc-linux] Re: [PATCHv2 0/2] rtc: add support for STM32H7 RTC

2017-07-06 Thread Alexandre Belloni
gt; rtc: stm32: add STM32H7 RTC support > > .../devicetree/bindings/rtc/st,stm32-rtc.txt | 32 +++-- > drivers/rtc/rtc-stm32.c| 82 > +- > 2 files changed, 92 insertions(+), 22 deletions(-) > Applied, thanks. -- Ale

[rtc-linux] Re: [PATCH 1/2] RTC: s35390a: handle invalid RTC time

2017-07-04 Thread Alexandre Belloni
On 04/07/2017 at 10:55:52 +0200, Fabien Lahoudere wrote: > On Thu, 2017-06-29 at 09:56 +0200, Alexandre Belloni wrote: > > On 26/06/2017 at 11:51:13 +0200, Fabien Lahoudere wrote: > > > > Actually, after reading the datasheet, I realize it is only POC that is > > >

Re: [rtc-linux] [PATCH 1/2] rtc: ds1307: add ds1308 variant

2017-07-06 Thread Alexandre Belloni
rs/rtc/rtc-ds1307.c | 12 > 1 file changed, 12 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership optio

Re: [rtc-linux] [PATCH 2/2] rtc: ds1307: disable square wave output from ds1308

2017-07-06 Thread Alexandre Belloni
" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rtc-linux+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[rtc-linux] Re: [PATCH 1/2] RTC: s35390a: handle invalid RTC time

2017-06-29 Thread Alexandre Belloni
s. One that does the initialization and another one that reads > > status1 and immediately doest the initialization when POC is set. If BLD > > is set, then we can wait for set_time to happen before initializing. > > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel

[rtc-linux] Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support

2017-07-05 Thread Alexandre Belloni
"); > - return PTR_ERR(rtc->ck_rtc); > + match = of_match_device(stm32_rtc_of_match, >dev); > + if (match && match->data) > + rtc->data = (struct stm32_rtc_data *)match->data; > + else > + return -EINVAL; This wi

[rtc-linux] Re: [PATCH 2/3 v2] rtc: gemini: Augment DT bindings for Faraday

2017-07-05 Thread Alexandre Belloni
txt | 14 --- > .../devicetree/bindings/rtc/faraday,ftrtc010.txt | 28 > ++ > 2 files changed, 28 insertions(+), 14 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rtc/cortina,gemini.txt > create mode 100644 Documentation/d

[rtc-linux] Re: [PATCH 3/3 v2] rtc: gemini/ftrtc010: rename driver and symbols

2017-07-05 Thread Alexandre Belloni
| 2 +- > drivers/rtc/Kconfig | 10 +-- > drivers/rtc/Makefile | 2 +- > drivers/rtc/{rtc-gemini.c => rtc-ftrtc010.c} | 91 > ++-- > 4 files changed, 53 insertions(+), 52 deletions

[rtc-linux] Re: [PATCH] rtc: hid-sensor-time: remove some dead code

2017-04-25 Thread Alexandre Belloni
On 12/04/2017 at 11:32:53 +0300, Dan Carpenter wrote: > devm_rtc_device_register() doesn't ever return NULL so there is no need > to check. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux a

[rtc-linux] Re: [PATCH v2 1/2] RTC: s35390a: handle invalid RTC time

2017-07-30 Thread Alexandre Belloni
information will be lost. > > Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> > --- > drivers/rtc/rtc-s35390a.c | 72 > +++ > 1 file changed, 42 insertions(+), 30 deletions(-) > Applied, thanks. -- Ale

[rtc-linux] Re: [PATCH v2 2/2] RTC: s35390a: implement ioctls

2017-07-30 Thread Alexandre Belloni
nsertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.c

[rtc-linux] Re: [PATCH] rtc: m41t80: enable wakealarm when "wakeup-source" is specified

2017-08-22 Thread Alexandre Belloni
sertions(+), 6 deletions(-) > I've applied it but it didn't apply cleanly, please check rtc-next or linux-next, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-li

[rtc-linux] [PATCH] MAINTAINERS: update RTC mailing list

2017-05-16 Thread Alexandre Belloni
The RTC subsystem mailing list is moving to vger. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f7d568b8f133..b3863ec142d7 100644 --- a/MAINT

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
roll <ulli.kr...@googlemail.com> > CC: Vladimir Zapolskiy <v...@mleia.com> > CC: Sylvain Lemieux <slemieux.t...@gmail.com> > CC: Barry Song <bao...@kernel.org> > CC: Maxime Ripard <maxime.rip...@free-electrons.com> > CC: Chen-Yu Tsai <w...@

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
e unusual. > Or not, having an RTC set in the past is actually quite common. I'd find it weird to have a new device boot and be set to a date in the future. Also note that the threshold or offset thing may seem like a good idea but fails with many RTCs because of how they handle leap years. --

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
On 21/06/2017 at 10:19:49 +0100, Russell King - ARM Linux wrote: > On Wed, Jun 21, 2017 at 10:39:07AM +0200, Alexandre Belloni wrote: > > On 21/06/2017 at 09:51:52 +0200, Pavel Machek wrote: > > > If someone uses different threshold, well, there will be > > > co

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > > rely on 32bits varia

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
fixups once > per class, not once per driver. Yes, I'm in the middle of the whole rework that allows that. I don't understand the sudden urgency of fixing that and the amount of bikeshedding, seeing that the closest cutoff date is actually 31st of december 2069 in the rtc subsystem and tha

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > <alexandre.bell...@free-electrons.com>: > > >> Yes, that's argument against ch

[rtc-linux] Re: [PATCH] rtc: opal: Implement rtc_class_ops.alarm_irq_enable callback

2017-06-23 Thread Alexandre Belloni
2 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Me

[rtc-linux] Re: [PATCH V2] rtc: ds1307: Add support for Epson RX8130CE

2017-06-24 Thread Alexandre Belloni
the chip, Alarm and > Timer is not supported. > > Signed-off-by: Marek Vasut <ma...@denx.de> > Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Felipe Balbi <ba...@ti.com> > Cc: Nishanth Menon <

[rtc-linux] Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-24 Thread Alexandre Belloni
disabled\n", __func__); > + } else { > + /* Alarm is enabled */ > + alarm->enabled = 1; > + rtc_time_to_tm(sec, >time); > + dev_dbg(dev, "%s: alarm is enabled\n", __func__); > + } > + > + reg = readl_r

[rtc-linux] Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-26 Thread Alexandre Belloni
s you removed it from v2. I'll applay that but it is ok if you change your mind. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http:/

[rtc-linux] Re: [PATCH v2 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-26 Thread Alexandre Belloni
te mode 100644 drivers/rtc/rtc-brcmstb-waketimer.c > Both applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.

[rtc-linux] Re: [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm

2017-05-22 Thread Alexandre Belloni
On 22/05/2017 at 00:02:08 +0200, Wolfram Sang wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang <w...@the-dreams.de> Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.c

[rtc-linux] Re: [PATCH v2] rtc: ds1307: convert driver to regmap

2017-05-25 Thread Alexandre Belloni
test as > well. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > --- > v2: > - rebased on top of latest rtc tree > --- > drivers/rtc/rtc-ds1307.c | 603 > +-- > 1 file changed, 221 insertions(+), 382 deletions(

[rtc-linux] Re: [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ

2017-05-30 Thread Alexandre Belloni
ds1307_can_wakeup_device)) { > irq_handler = mcp794xx_irq; > want_irq = true; > } I applied it now but it didn't applied cleanly. Can you check tomorrow's linux-next? Thanks! -- Alexandre Belloni, Fre

[rtc-linux] Re: [PATCH 0/4] rtc: m41t80: improve SQW support

2017-05-30 Thread Alexandre Belloni
: m41t80: remove sqw sysfs entry > rtc: m41t80: add clock provider support > > drivers/rtc/rtc-m41t80.c | 251 > +-- > 1 file changed, 175 insertions(+), 76 deletions(-) > All applied now, I had to rebase the last patch on top of v4.12-

<    1   2   3   >