Re: [Rails-core] Pull request: fix SQL generation bug in Postgres / Oracle

2011-12-28 Thread Jon Leighton
On 27/12/11 14:32, Matt jones wrote: https://github.com/rails/rails/pull/4082 I've commented on the PR. On a related note, the current mechanism for handling 'reorder' seems pretty strange; what's the design motivation behind keeping the values passed to reorder separate from order? The

[Rails-core] Re: Change fixtures API and internal code

2011-12-28 Thread Alexey
On Dec 28, 1:27 am, Alexey alexey.mura...@gmail.com wrote: I am fixing bugs in fixtures.rb, and would like to propose some API and internal code changes. 1. Make TestFixtures::fixture_table_names hold a hash? I would like to make the (undocumented?) class attribute

Re: [Rails-core] Pull request: fix SQL generation bug in Postgres / Oracle

2011-12-28 Thread Matt Jones
On Dec 28, 2011, at 5:55 AM, Jon Leighton wrote: On 27/12/11 14:32, Matt jones wrote: https://github.com/rails/rails/pull/4082 I've commented on the PR. Updated PR against master: https://github.com/rails/rails/pull/4216 On a related note, the current mechanism for handling 'reorder'