On Fri, May 18, 2012 at 06:42:18AM +0900, FUJITA Tomonori wrote:
> On Thu, 17 May 2012 23:28:37 +0900
> FUJITA Tomonori wrote:
>
> > body_cls_size assmes that a stats reply body has the fixed-size
> > length. But it's not the case. So we can't use it and it's not used
> > anymore so kill it.
> >
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0_parser.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0_parser.py
b/ryu/ofproto/ofproto_v1_0_parser.py
index dd1bebf..c44117f 100644
--- a/ryu/ofproto/ofproto_v1_0_parser.py
+++ b/ryu
- __str__ method: needs to pass a tuple to msg_str_attr
- parser method: rate shouldn't be a tuple.
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0_parser.py |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0_parser.py
b/ryu/ofpro
On Fri, 18 May 2012 10:11:10 +0900
Isaku Yamahata wrote:
> I chose this inconsistency because the spec is inconsistent. :-(
>
>>From the spec 1.0,
> struct ofp_desc_stats
> struct ofp_flow_stats
> struct ofp_aggregate_stats_reply
> struct ofp_table_stats
> struct ofp_port_sta
On Fri, 18 May 2012 10:02:33 +0900
Isaku Yamahata wrote:
> Oops. The length value is class-wide constants.
>
> class OFPXXXStats(...)
> length = ..._SIZE
> def parser...
I like to make the way all the OFPXXStats (include set the length
consistent. But either is fine.
--
On Fri, 18 May 2012 10:01:21 +0900
Isaku Yamahata wrote:
> On Thu, May 17, 2012 at 11:28:36PM +0900, FUJITA Tomonori wrote:
>> OFPStatsReply needs to handle variable-length bodys (flow stats) so
>> having two parsers (parser_stats_body_array and parser_stats_body)
>> doesn't make sense. Just kill
I chose this inconsistency because the spec is inconsistent. :-(
>From the spec 1.0,
struct ofp_desc_stats
struct ofp_flow_stats
struct ofp_aggregate_stats_reply
struct ofp_table_stats
struct ofp_port_stats
struct ofp_queue_stats
Later versions also keep this inconsistency
Oops. The length value is class-wide constants.
class OFPXXXStats(...)
length = ..._SIZE
def parser...
On Thu, May 17, 2012 at 11:28:35PM +0900, FUJITA Tomonori wrote:
> OFPStatsReply parser_stats_body_array needs body classes to have
> length field.
>
> Signed-off-by: FUJITA Tomon
On Thu, May 17, 2012 at 11:28:36PM +0900, FUJITA Tomonori wrote:
> OFPStatsReply needs to handle variable-length bodys (flow stats) so
> having two parsers (parser_stats_body_array and parser_stats_body)
> doesn't make sense. Just kill parser_stats_body_array().
The returned type for struct ofp_st
On Thu, 17 May 2012 23:28:37 +0900
FUJITA Tomonori wrote:
> body_cls_size assmes that a stats reply body has the fixed-size
> length. But it's not the case. So we can't use it and it's not used
> anymore so kill it.
>
> Signed-off-by: FUJITA Tomonori
> ---
> ryu/ofproto/ofproto_v1_0_parser.py
body_cls_size assmes that a stats reply body has the fixed-size
length. But it's not the case. So we can't use it and it's not used
anymore so kill it.
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0_parser.py | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
di
OFPStatsReply needs to handle variable-length bodys (flow stats) so
having two parsers (parser_stats_body_array and parser_stats_body)
doesn't make sense. Just kill parser_stats_body_array().
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0_parser.py | 14 --
1 files cha
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py|7 +++
ryu/ofproto/ofproto_v1_0_parser.py |4 ++--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index a757e13..a458b9b 100644
--- a/ryu/of
OFPStatsReply parser_stats_body_array needs body classes to have
length field.
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0_parser.py | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0_parser.py
b/ryu/ofproto/ofproto_
Hi,
We created a VM image file that enables you to easily set up
multi-node Nova environment with Ryu in your desktop machine:
https://github.com/osrg/ryu/wiki/RYU-OpenStack-environment-VM-image-file-HOWTO
This might be useful for the MCL team that works on OpenStack
L3. Please let us know if yo
Sorry for the delay.
On Fri, 11 May 2012 08:33:13 -0500
Salman Malik wrote:
> Great! looking forward to test it with OpenStack :-)
The VM image file is finally ready:
https://github.com/osrg/ryu/wiki/RYU-OpenStack-environment-VM-image-file-HOWTO
---
Hi,
We created a VM image file that enables you to easily set up
multi-node Nova environment with Ryu in your desktop machine:
https://github.com/osrg/ryu/wiki/RYU-OpenStack-environment-VM-image-file-HOWTO
Enjoy!
--
Liv
17 matches
Mail list logo
