[Ryu-devel] [PATCH 1/4] tweak packet_data_generator

2013-09-12 Thread YAMAMOTO Takashi
to reproduce a problem reported by Nitin Sharma on ryu-devel. Signed-off-by: YAMAMOTO Takashi --- ryu/tests/packet_data_generator/src/x3.erl | 7 ++- ryu/tests/packet_data_generator/src/x4.erl | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/ryu/tests/packet_data_

Re: [Ryu-devel] OFPActionSetField issues - OFPT_FLOW_MOD with incorrect length 116

2013-09-12 Thread YAMAMOTO Takashi
> hi, > > thanks for a report. > i will fix. done. YAMAMOTO Takashi > > YAMAMOTO Takashi > >> Here are the actions/instructions I am trying to set using , >> >> me.ofproto.OFPIT_APPLY_ACTIONS >> >> [OFPActionOutput(len=16,max_len=0,port=5,type=0), >> OFPActionSetField(eth_dst='00:25:90:9b:b

Re: [Ryu-devel] [PATCH v2 4/8] packet lib: ipv6: support destination header

2013-09-12 Thread YAMAMOTO Takashi
hi, > +class dst_opts(hop_opts): this seems wired to me. how about: class opt_header(header): class dst_opts(opt_header): class hop_opts(opt_header): YAMAMOTO Takashi -- How ServiceNow helps IT people trans

[Ryu-devel] [PATCH 2/4] packet_data: regen

2013-09-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/packet_data/of12/3-2-ofp_flow_mod.packet | Bin 104 -> 128 bytes ryu/tests/packet_data/of13/4-2-ofp_flow_mod.packet | Bin 104 -> 128 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/ryu/tests/packet_data/of12/3-2-ofp_flow_mod.pack

[Ryu-devel] [PATCH 3/4] test: update expected json outputs

2013-09-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- .../ofproto/json/of12/3-2-ofp_flow_mod.packet.json| 19 +++ .../ofproto/json/of13/4-2-ofp_flow_mod.packet.json| 19 +++ 2 files changed, 38 insertions(+) diff --git a/ryu/tests/unit/ofproto/json/of12/3-2-ofp_flow_mod.pac

[Ryu-devel] [PATCH 4/4] of12, of13: fix OFPActionSetField padding

2013-09-12 Thread YAMAMOTO Takashi
the problem reported by Nitin Sharma on ryu-devel. Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2_parser.py | 2 +- ryu/ofproto/ofproto_v1_3_parser.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofproto_v1

Re: [Ryu-devel] OFPActionSetField issues - OFPT_FLOW_MOD with incorrect length 116

2013-09-12 Thread YAMAMOTO Takashi
hi, thanks for a report. i will fix. YAMAMOTO Takashi > Here are the actions/instructions I am trying to set using , > > me.ofproto.OFPIT_APPLY_ACTIONS > > [OFPActionOutput(len=16,max_len=0,port=5,type=0), > OFPActionSetField(eth_dst='00:25:90:9b:b8:47')] > > [OFPInstructionActions(actions=[O

Re: [Ryu-devel] OFPActionSetField issues - OFPT_FLOW_MOD with incorrect length 116

2013-09-12 Thread Satoshi Kobayashi
Hi Nitin, ActionList is applied in order. Please refer to the section 5.8 of OpenFlow1.2 spec for details. It is meaningless that OFPActionOutput is before OFPActionSetField. IMHO, the switch recognizes OFPActionOutput to be the last action. All the best, Satoshi 2013/9/13 Nitin Sharma > Here

[Ryu-devel] Multithread dispatching of a event in RyuApp

2013-09-12 Thread Satoshi Kobayashi
Hi all, I noticed that RyuApp dispatched an event in singlethread. But it can not work the cooperation of threads between events. For example, it is to wait for PacketIn in a certain event using Event or Queue. I think that it is useful. I think that one necessary for it is to assign a greenthrea

[Ryu-devel] OFPActionSetField issues - OFPT_FLOW_MOD with incorrect length 116

2013-09-12 Thread Nitin Sharma
Here are the actions/instructions I am trying to set using , me.ofproto.OFPIT_APPLY_ACTIONS [OFPActionOutput(len=16,max_len=0,port=5,type=0), OFPActionSetField(eth_dst='00:25:90:9b:b8:47')] [OFPInstructionActions(actions=[OFPActionOutput(len=16,max_len=0,port=5,type=0), OFPActionSetField(eth_dst

[Ryu-devel] [PATCH v2 7/8] packet lib: ipv6: add test for multi extension headers

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/tests/unit/packet/test_ipv6.py | 67 1 file changed, 67 insertions(+) diff --git a/ryu/tests/unit/packet/test_ipv6.py b/ryu/tests/unit/packet/test_ipv6.py index f39247f..8ca7bda 100644 --- a/ryu/tests/unit/packet/test_ipv6.

[Ryu-devel] [PATCH v2 8/8] packet lib: ipv6: TODO: support routing header

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py |7 +++ 1 file changed, 7 insertions(+) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index 28d6a23..4909af7 100644 --- a/ryu/lib/packet/ipv6.py +++ b/ryu/lib/packet/ipv6.py @@ -315,6 +315,13 @@ class option(stringify.Str

[Ryu-devel] [PATCH v2 6/8] packet lib: ipv6: support IP Authentication header

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py | 59 ++ ryu/tests/unit/packet/test_ipv6.py | 94 2 files changed, 153 insertions(+) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index 49ad9b8..28d6a23 10

[Ryu-devel] [PATCH v2 5/8] packet lib: ipv6: support fragment header

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py | 52 + ryu/tests/unit/packet/test_ipv6.py | 89 2 files changed, 141 insertions(+) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index a8eb630..49ad9b8 100

[Ryu-devel] [PATCH v2 4/8] packet lib: ipv6: support destination header

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py | 26 ryu/tests/unit/packet/test_ipv6.py | 126 2 files changed, 152 insertions(+) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index 4b4256a..a8eb630 100644 --- a/ryu

[Ryu-devel] [PATCH v2 2/8] packet lib: ipv6: support options for Hop-by-Hop Options header and destination header

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py | 59 + ryu/tests/unit/packet/test_ipv6.py | 72 2 files changed, 131 insertions(+) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index 6abc2b7..19a

[Ryu-devel] [PATCH v2 3/8] packet lib: ipv6: support Hop-by-Hop Options header

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py | 62 ++ ryu/tests/unit/packet/test_ipv6.py | 126 2 files changed, 188 insertions(+) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index 19a2d3f..4b4256a 100644

[Ryu-devel] [PATCH v2 1/8] packet lib: ipv6: prepare to support extension headers

2013-09-12 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/ipv6.py | 81 ++-- ryu/tests/unit/packet/test_ipv6.py | 89 +--- 2 files changed, 149 insertions(+), 21 deletions(-) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.p

[Ryu-devel] [PATCH v2 0/8] packet lib: ipv6: support extension headers

2013-09-12 Thread Yuichi Ito
Changes v1 -> v2: - divide a patch by related categories - simplify test codes itoyuichi (8): packet lib: ipv6: prepare to support extension headers packet lib: ipv6: support options for Hop-by-Hop Options header and destination header packet lib: ipv6: support Hop-by-Hop Options heade