Re: [Ryu-devel] [PATCH 0/4] tests: fix the value of multipart "more" flag

2013-10-23 Thread FUJITA Tomonori
On Thu, 24 Oct 2013 11:11:56 +0900 YAMAMOTO Takashi wrote: > this is a merely rebased resend. > > this set fixes the value of multipart "more" flag in > an expected json output used by ofproto.test_parser test. > > YAMAMOTO Takashi (4): > packet_data_generator: change of_protocol upstream >

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-10-23 Thread Satoshi Kobayashi
2013/10/24 YAMAMOTO Takashi > > 2013/10/24 Chen Chen > > > >> The max_len is not really a bug. But I suggest one line of warning can > be > >> added in __init__ of OFPActionOutput: > >> > >> if (port == OFPP_CONTROLLER and max_len == 0): > >> LOG.warning("Port is set to controller but max_le

[Ryu-devel] [PATCH 2/4] packet_data_generator: adapt to of_protocol upstream api change

2013-10-23 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/packet_data_generator/src/x3.erl | 2 +- ryu/tests/packet_data_generator/src/x4.erl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/packet_data_generator/src/x3.erl b/ryu/tests/packet_data_generator/src/x3.erl index 7

[Ryu-devel] [PATCH 4/4] ofproto.test_parser: fix an expected json output

2013-10-23 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- .../unit/ofproto/json/of13/4-56-ofp_table_features_reply.packet.json| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/tests/unit/ofproto/json/of13/4-56-ofp_table_features_reply.packet.json b/ryu/tests/unit/ofproto/json/of13/4-56-ofp_

[Ryu-devel] [PATCH 1/4] packet_data_generator: change of_protocol upstream

2013-10-23 Thread YAMAMOTO Takashi
change of_protocol upstream back to a local repo again to include the following fix. https://github.com/FlowForwarding/of_protocol/pull/51 Signed-off-by: YAMAMOTO Takashi --- ryu/tests/packet_data_generator/rebar.config | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --gi

[Ryu-devel] [PATCH 0/4] tests: fix the value of multipart "more" flag

2013-10-23 Thread YAMAMOTO Takashi
this is a merely rebased resend. this set fixes the value of multipart "more" flag in an expected json output used by ofproto.test_parser test. YAMAMOTO Takashi (4): packet_data_generator: change of_protocol upstream packet_data_generator: adapt to of_protocol upstream api change packet_dat

[Ryu-devel] [PATCH 3/4] packet_data: regen

2013-10-23 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- .../of13/4-56-ofp_table_features_reply.packet | Bin 11072 -> 11072 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ryu/tests/packet_data/of13/4-56-ofp_table_features_reply.packet b/ryu/tests/packet_data/of13/4-56-ofp_table_features_r

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-10-23 Thread YAMAMOTO Takashi
> 2013/10/24 Chen Chen > >> The max_len is not really a bug. But I suggest one line of warning can be >> added in __init__ of OFPActionOutput: >> >> if (port == OFPP_CONTROLLER and max_len == 0): >> LOG.warning("Port is set to controller but max_len is 0.") >> >> To give a clue about what's g

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-10-23 Thread Satoshi Kobayashi
2013/10/24 Chen Chen > The max_len is not really a bug. But I suggest one line of warning can be > added in __init__ of OFPActionOutput: > > if (port == OFPP_CONTROLLER and max_len == 0): > LOG.warning("Port is set to controller but max_len is 0.") > > To give a clue about what's going on if

Re: [Ryu-devel] [PATCH] packet lib: sctp: correct comments

2013-10-23 Thread FUJITA Tomonori
On Thu, 24 Oct 2013 09:25:16 +0900 Yuichi Ito wrote: > Signed-off-by: Yuichi Ito > --- > ryu/lib/packet/sctp.py | 59 > +--- > 1 file changed, 41 insertions(+), 18 deletions(-) Applied. ---

[Ryu-devel] [PATCH] packet lib: sctp: correct comments

2013-10-23 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/lib/packet/sctp.py | 59 +--- 1 file changed, 41 insertions(+), 18 deletions(-) diff --git a/ryu/lib/packet/sctp.py b/ryu/lib/packet/sctp.py index 666e1e9..1b5b9e6 100644 --- a/ryu/lib/packet/sctp.py +++ b/ryu/lib/pa

Re: [Ryu-devel] [PATCH 0/4] tests: fix the value of multipart "more" flag

2013-10-23 Thread FUJITA Tomonori
On Wed, 23 Oct 2013 15:44:10 +0900 YAMAMOTO Takashi wrote: > this set fixes the value of multipart "more" flag in > an expected json output used by ofproto.test_parser test. > > YAMAMOTO Takashi (4): > packet_data_generator: change of_protocol upstream > packet_data_generator: adapt to of_pr

Re: [Ryu-devel] [PATCH] of13: support PUSH_PBB/POP_PBB actions

2013-10-23 Thread FUJITA Tomonori
On Wed, 23 Oct 2013 14:36:28 +0900 Yuichi Ito wrote: > Signed-off-by: Yuichi Ito > --- > ryu/ofproto/ofproto_v1_3_parser.py | 54 > > 1 file changed, 54 insertions(+) Applied, thanks. -

Re: [Ryu-devel] [PATCH v2] of1.0, of1.2, of1.3: Modify the default of max_len in OFPActionOutput

2013-10-23 Thread FUJITA Tomonori
On Wed, 23 Oct 2013 17:45:56 +0900 Satoshi Kobayashi wrote: > The new default will send a packet to a controller. > > Signed-off-by: Satoshi Kobayashi > --- > Change for v2: > - of1.0 is modified by the same value in of1.2 and of1.3 > > ryu/ofproto/ofproto_v1_0_parser.py|5 -

Re: [Ryu-devel] [PATCH 0/4] packet lib: sctp: support the auto calculation of lengths of parameters and causes

2013-10-23 Thread FUJITA Tomonori
On Wed, 23 Oct 2013 19:38:36 +0900 Yuichi Ito wrote: > Yuichi Ito (4): > packet lib: sctp: reduce computation > packet lib: sctp: remove unnecessary __init__() > packet lib: sctp: fill up lack of decolators > packet lib: sctp: support the auto calculation of lengths of > parameters an

Re: [Ryu-devel] Limiting bandwidth

2013-10-23 Thread FUJITA Tomonori
On Wed, 23 Oct 2013 20:58:13 +0200 Gabriele Gerbino wrote: > is there any way to change the bandwidth of a link if a certain event > occour? (I want to limit the bandwidth when a certain number of alerts is > reached) > I know you can do so in mininet with the tc command, but I don't know how > t

[Ryu-devel] Limiting bandwidth

2013-10-23 Thread Gabriele Gerbino
Hi all, is there any way to change the bandwidth of a link if a certain event occour? (I want to limit the bandwidth when a certain number of alerts is reached) I know you can do so in mininet with the tc command, but I don't know how to use it into my app. Thanks in advance Gabriele -

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-10-23 Thread Chen Chen
The max_len is not really a bug. But I suggest one line of warning can be added in __init__ of OFPActionOutput: if (port == OFPP_CONTROLLER and max_len == 0): LOG.warning("Port is set to controller but max_len is 0.") To give a clue about what's going on if developers accidentally forget to s

[Ryu-devel] [PATCH 4/4] packet lib: sctp: support the auto calculation of lengths of parameters and causes

2013-10-23 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/lib/packet/sctp.py | 89 ++-- ryu/tests/unit/packet/test_sctp.py | 100 ++-- 2 files changed, 110 insertions(+), 79 deletions(-) diff --git a/ryu/lib/packet/sctp.py b/ryu/lib/packet/sctp.

[Ryu-devel] [PATCH 2/4] packet lib: sctp: remove unnecessary __init__()

2013-10-23 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/lib/packet/sctp.py |9 - 1 file changed, 9 deletions(-) diff --git a/ryu/lib/packet/sctp.py b/ryu/lib/packet/sctp.py index 258dd18..bf6bd09 100644 --- a/ryu/lib/packet/sctp.py +++ b/ryu/lib/packet/sctp.py @@ -1383,9 +1383,6 @@ class cause_unresolvabl

[Ryu-devel] [PATCH 0/4] packet lib: sctp: support the auto calculation of lengths of parameters and causes

2013-10-23 Thread Yuichi Ito
Yuichi Ito (4): packet lib: sctp: reduce computation packet lib: sctp: remove unnecessary __init__() packet lib: sctp: fill up lack of decolators packet lib: sctp: support the auto calculation of lengths of parameters and causes ryu/lib/packet/sctp.py | 146 ++

[Ryu-devel] [PATCH 3/4] packet lib: sctp: fill up lack of decolators

2013-10-23 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/lib/packet/sctp.py |2 ++ 1 file changed, 2 insertions(+) diff --git a/ryu/lib/packet/sctp.py b/ryu/lib/packet/sctp.py index bf6bd09..6a6e89b 100644 --- a/ryu/lib/packet/sctp.py +++ b/ryu/lib/packet/sctp.py @@ -1977,6 +1977,7 @@ class param_supported_addr(pa

[Ryu-devel] [PATCH 1/4] packet lib: sctp: reduce computation

2013-10-23 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/lib/packet/sctp.py | 46 -- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/ryu/lib/packet/sctp.py b/ryu/lib/packet/sctp.py index e935c63..258dd18 100644 --- a/ryu/lib/packet/sctp.py +++ b/ryu/lib/pack

[Ryu-devel] [PATCH v2] of1.0, of1.2, of1.3: Modify the default of max_len in OFPActionOutput

2013-10-23 Thread Satoshi Kobayashi
The new default will send a packet to a controller. Signed-off-by: Satoshi Kobayashi --- Change for v2: - of1.0 is modified by the same value in of1.2 and of1.3 ryu/ofproto/ofproto_v1_0_parser.py|5 - ryu/ofproto/ofproto_v1_2_parser.py|3 ++- ryu/ofproto/ofproto_v1_

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-10-23 Thread YAMAMOTO Takashi
> 2013/10/23 FUJITA Tomonori > >> On Wed, 23 Oct 2013 11:33:53 +0900 (JST) >> [email protected] (YAMAMOTO Takashi) wrote: >> >> >> 2013/10/21 FUJITA Tomonori >> >> >> >>> On Mon, 21 Oct 2013 18:45:23 +0900 >> >>> Satoshi Kobayashi wrote: >> >>> >> >>> > I was also mistaken in it and made t

Re: [Ryu-devel] [PATCH] of1.2, of1.3: Modify the default of max_len in OFPActionOutput

2013-10-23 Thread YAMAMOTO Takashi
> The new default will send a packet to a controller. > of1.0 is not modified yet since there is no good constant. the same value (0xffe5) should be fine. YAMAMOTO Takashi > > Signed-off-by: Satoshi Kobayashi > --- > ryu/ofproto/ofproto_v1_2_parser.py |3 ++- > ryu/ofproto/ofproto_v1_3_pa

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-10-23 Thread Satoshi Kobayashi
2013/10/23 FUJITA Tomonori > On Wed, 23 Oct 2013 11:33:53 +0900 (JST) > [email protected] (YAMAMOTO Takashi) wrote: > > >> 2013/10/21 FUJITA Tomonori > >> > >>> On Mon, 21 Oct 2013 18:45:23 +0900 > >>> Satoshi Kobayashi wrote: > >>> > >>> > I was also mistaken in it and made time useless.

[Ryu-devel] [PATCH] of1.2, of1.3: Modify the default of max_len in OFPActionOutput

2013-10-23 Thread Satoshi Kobayashi
The new default will send a packet to a controller. of1.0 is not modified yet since there is no good constant. Signed-off-by: Satoshi Kobayashi --- ryu/ofproto/ofproto_v1_2_parser.py |3 ++- ryu/ofproto/ofproto_v1_3_parser.py |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff