Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-10 Thread Johan S . H . Rosenkilde
Volker Braun writes: > Thats ok for reviewing tickets, and implemented as "git trac try > ". OK. I had a chat with Thierry Monteil and we agreed there were some subtle differences I don't remember - but I'll take a look at "git trac try". > But if you want to actually make changes then this

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-10 Thread Volker Braun
Thats ok for reviewing tickets, and implemented as "git trac try ". But if you want to actually make changes then this creates a new merge commit which furthermore is against the conventional order (where the feature branch is the first parent). So it makes the commit history harder to

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-10 Thread Johan S . H . Rosenkilde
Jeroen Demeyer writes: > On 2016-09-10 00:03, Paul Masson wrote: >> Why would recythonizing be necessary when only changing the same file on >> the same branch? > > You are not changing just one file. When you checkout a new branch, a > lot of files get changed. When you checkout the old branch

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-10 Thread Volker Braun
There is cycache, but its currently disabled in Sage as we ran into some bugs. On Saturday, September 10, 2016 at 12:20:54 AM UTC+2, William wrote: > > On Fri, Sep 9, 2016 at 3:08 PM, Volker Braun > wrote: > > Whenever you switch to a branch with a different working set

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Paul Masson
+1 That would save on time and confusion. On Friday, September 9, 2016 at 3:20:54 PM UTC-7, William wrote: > > On Fri, Sep 9, 2016 at 3:08 PM, Volker Braun > wrote: > > Whenever you switch to a branch with a different working set you change > > timestamps of modified

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread William Stein
On Fri, Sep 9, 2016 at 3:08 PM, Volker Braun wrote: > Whenever you switch to a branch with a different working set you change > timestamps of modified files. Git does not track timestamps. Updated > timestamps cause recompilation. So... instead of using timestamps, maybe

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Volker Braun
Whenever you switch to a branch with a different working set you change timestamps of modified files. Git does not track timestamps. Updated timestamps cause recompilation. On Saturday, September 10, 2016 at 12:03:36 AM UTC+2, Paul Masson wrote: > > A little over a week ago I made a new

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Jeroen Demeyer
On 2016-09-10 00:03, Paul Masson wrote: Why would recythonizing be necessary when only changing the same file on the same branch? You are not changing just one file. When you checkout a new branch, a lot of files get changed. When you checkout the old branch again, a lot of files get changed

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Paul Masson
A little over a week ago I made a new branch from 7.4.beta2 for Trac 21370. I initially ran make on this branch. For the last week, I have made changes to one file, graphs/graph_plot.py, for that ticket. For the last week, every time I run sage -b after modifying that one file, the process

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Jeroen Demeyer
On 2016-09-09 23:34, Paul Masson wrote: I'm a bit confused by your answer, because I've been seeing the same sort of behavior. For the last week I've been rebuilding a branch based on 7.4.beta2. With minor changes to one file, sage -b has been running very quickly. Today I made one minor change

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Paul Masson
I'm a bit confused by your answer, because I've been seeing the same sort of behavior. For the last week I've been rebuilding a branch based on 7.4.beta2. With minor changes to one file, sage -b has been running very quickly. Today I made one minor change and the recythonizing kicked in. In

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Marco Cognetta
It seems there are some differences that were not showing up when I was checking status. On Saturday, September 10, 2016 at 1:17:31 AM UTC+9, Marco Cognetta wrote: > > One public branch is the trac ticket #21423. I just tested the turning on > and off again and it happened and then failed. It

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Marco Cognetta
One public branch is the trac ticket #21423. I just tested the turning on and off again and it happened and then failed. It may be something weird with that branch, but it said it was up to date with the sage repo and I didn't change anything outside of the graph/generators/families.py file.

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Jeroen Demeyer
On 2016-09-09 12:56, Marco Cognetta wrote: It has happened to me where I build sage, turn off my computer, turn it back on, and build it again. There were no changes made in the meantime and it still does the cythonizing step. Are you really sure that you remember this correctly? Turning off

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Marco Cognetta
It has happened to me where I build sage, turn off my computer, turn it back on, and build it again. There were no changes made in the meantime and it still does the cythonizing step. Also, I have had branches that are identical (except for a new file that does not have any dependencies to be

Re: [sage-devel] sage -br rebuilds things that were not changed

2016-09-09 Thread Jeroen Demeyer
On 2016-09-09 08:43, Marco Cognetta wrote: However, if I change to a new branch that has no changes which would necessitate recythonizing code, it will go through the cythonizing step again. What makes you think that there are no changes which would necessitate recythonizing? Cython does