[sage-devel] Re: Trac workflow and needs_review

2016-07-04 Thread leif
Erik Bray wrote: > On Fri, Jul 1, 2016 at 8:11 PM, leif wrote: >> Jori Mäntysalo wrote: >>> On Fri, 1 Jul 2016, Erik Bray wrote: >>> One thing that will help, which has already been discussed up-thread, is having Trac help take care of the little nitty-gritty

Re: [sage-devel] Re: Trac workflow and needs_review

2016-07-04 Thread Erik Bray
On Fri, Jul 1, 2016 at 8:11 PM, leif wrote: > Jori Mäntysalo wrote: >> On Fri, 1 Jul 2016, Erik Bray wrote: >> >>> One thing that will help, which has already been discussed up-thread, >>> is having Trac help take care of the little nitty-gritty checks on >>> tickets. >> >>

[sage-devel] Re: Trac workflow and needs_review

2016-07-02 Thread Volker Braun
No I haven't. Really it should be a trac plugin that prevents you from setting a ticket to positive review without filling out Author and Reviewer fields. A somewhat orthogonal issue is whether to record plain text names or user ids. The advantage of plain text is that anyone can be listed (),

[sage-devel] Re: Trac workflow and needs_review

2016-07-01 Thread kcrisman
> > > I think Jeroen *did* automate the posts regarding empty author and/or > reviewer fields when he was release manager. :-) > I'm pretty sure that Volker automates this too... -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe

Re: [sage-devel] Re: Trac workflow and needs_review

2016-07-01 Thread Jori Mäntysalo
On Fri, 1 Jul 2016, leif wrote: True. It feels extremely stupid to get a message "You forgot reviewer's name.", as this is exactly what computers should do instead of humans. You cannot automatically add these names; all we could do is create some plug-in such that when a ticket is set to

[sage-devel] Re: Trac workflow and needs_review

2016-07-01 Thread leif
Jori Mäntysalo wrote: > On Fri, 1 Jul 2016, Erik Bray wrote: > >> One thing that will help, which has already been discussed up-thread, >> is having Trac help take care of the little nitty-gritty checks on >> tickets. > > True. It feels extremely stupid to get a message "You forgot reviewer's >

Re: [sage-devel] Re: Trac workflow and needs_review

2016-07-01 Thread Jori Mäntysalo
On Fri, 1 Jul 2016, Erik Bray wrote: One thing that will help, which has already been discussed up-thread, is having Trac help take care of the little nitty-gritty checks on tickets. True. It feels extremely stupid to get a message "You forgot reviewer's name.", as this is exactly what

Re: [sage-devel] Re: Trac workflow and needs_review

2016-07-01 Thread Erik Bray
On Thu, Jun 30, 2016 at 11:58 PM, William Stein wrote: > On Thu, Jun 30, 2016 at 8:35 AM, Erik Bray wrote: >> On Tue, Jun 28, 2016 at 7:14 PM, leif wrote: >>> Erik Bray wrote: While we're tinkering with the workflow, I think we

Re: [sage-devel] Re: Trac workflow and needs_review

2016-06-30 Thread William Stein
On Thu, Jun 30, 2016 at 8:35 AM, Erik Bray wrote: > On Tue, Jun 28, 2016 at 7:14 PM, leif wrote: >> Erik Bray wrote: >>> While we're tinkering with the workflow, I think we need to change the >>> workflow associated with testing changes. >>> >>>

[sage-devel] Re: Trac workflow and needs_review

2016-06-30 Thread leif
Erik Bray wrote: > On Tue, Jun 28, 2016 at 7:14 PM, leif wrote: >> Erik Bray wrote: >>> While we're tinkering with the workflow, I think we need to change the >>> workflow associated with testing changes. >>> >>> Currently the release manager *closes* a ticket and marks it

Re: [sage-devel] Re: Trac workflow and needs_review

2016-06-30 Thread Erik Bray
On Tue, Jun 28, 2016 at 7:14 PM, leif wrote: > Erik Bray wrote: >> While we're tinkering with the workflow, I think we need to change the >> workflow associated with testing changes. >> >> Currently the release manager *closes* a ticket and marks it as > > s/currently the

[sage-devel] Re: Trac workflow and needs_review

2016-06-28 Thread leif
leif wrote: > Erik Bray wrote: >> While we're tinkering with the workflow, I think we need to change the >> workflow associated with testing changes. >> >> Currently the release manager *closes* a ticket and marks it as > > s/currently the release manager/the current release manager/ ;-) > >>

[sage-devel] Re: Trac workflow and needs_review

2016-06-28 Thread leif
Erik Bray wrote: > While we're tinkering with the workflow, I think we need to change the > workflow associated with testing changes. > > Currently the release manager *closes* a ticket and marks it as s/currently the release manager/the current release manager/ ;-) > "fixed" when merging the

[sage-devel] Re: trac workflow

2010-07-02 Thread Robert Miller
Ping! I'd like to repeat my request, since I have just discovered yet another edge that needs adding: positive_review -- needs_info On Thu, Jun 24, 2010 at 11:05 AM, Robert Miller r...@rlmiller.org wrote: Hello, I'd like to make some tweaks to the workflow on Sage's trac server, in

Re: [sage-devel] Re: trac workflow

2010-07-02 Thread Mike Hansen
On Fri, Jul 2, 2010 at 3:34 PM, Robert Miller r...@rlmiller.org wrote: Ping! I'd like to repeat my request, since I have just discovered yet another edge that needs adding: positive_review -- needs_info Both should be added. --Mike -- To post to this group, send an email to