svn commit: samba r25493 - in branches: SAMBA_3_2/source/nsswitch SAMBA_3_2_0/source/nsswitch

2007-10-03 Thread jmcd
Author: jmcd Date: 2007-10-03 20:56:29 + (Wed, 03 Oct 2007) New Revision: 25493 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=25493 Log: Fix typo in Jeremy's thread-safe winbind patch: lock-unlock (would have tried to lock a mutex at the end of a function). Cut

svn commit: samba r23643 - in branches/SAMBA_4_0/source: librpc/idl torture/rpc

2007-06-28 Thread jmcd
Author: jmcd Date: 2007-06-28 18:08:04 + (Thu, 28 Jun 2007) New Revision: 23643 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=23643 Log: Fix the build farm tests. We were incorrectly passing the RPC-SAMBA3-GETUSERNAME tests before the previous password

svn commit: samba r23616 - in branches: SAMBA_3_0/source/include SAMBA_3_0/source/rpc_parse SAMBA_3_0/source/rpc_server SAMBA_3_0_25/source/include SAMBA_3_0_25/source/rpc_parse SAMBA_3_0_25/source/rp

2007-06-26 Thread jmcd
Author: jmcd Date: 2007-06-26 20:09:41 + (Tue, 26 Jun 2007) New Revision: 23616 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=23616 Log: Fix bugzilla #4719: must change password is not set from usrmgr.exe. This was only affecting the newer versions of usrmgr.exe

svn commit: samba r23231 - in branches/SAMBA_4_0/source/torture/rpc: .

2007-05-29 Thread jmcd
Author: jmcd Date: 2007-05-29 21:50:17 + (Tue, 29 May 2007) New Revision: 23231 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=23231 Log: Fix make test on build farm for 64-bit hosts. There's no reason this should be any different for 64-bit hosts, but we

svn commit: samba r23041 - in branches: SAMBA_3_0/source/lib SAMBA_3_0_25/source/lib SAMBA_3_0_26/source/lib

2007-05-21 Thread jmcd
Author: jmcd Date: 2007-05-21 16:01:22 + (Mon, 21 May 2007) New Revision: 23041 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=23041 Log: Remainder of fix for 4630: fix special case of unix_to_nt_time() for TIME_T_MAX, and also display of it in http_timestring

svn commit: samba r22504 - in branches: SAMBA_3_0/source/rpc_server SAMBA_3_0_25/source/rpc_server

2007-04-24 Thread jmcd
Author: jmcd Date: 2007-04-24 15:56:02 + (Tue, 24 Apr 2007) New Revision: 22504 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=22504 Log: Fix bug Jerry found during his tutorial. Sorry :-( Allows authorized users (e.g. BUILTIN\Administrators members) to set

svn commit: samba r22148 - in branches: SAMBA_3_0/source/modules SAMBA_3_0_25/source/modules

2007-04-10 Thread jmcd
Author: jmcd Date: 2007-04-10 15:41:22 + (Tue, 10 Apr 2007) New Revision: 22148 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=22148 Log: Fix gpfs module on posix-acl test. Adds gpfsacl_sys_set_fd (calls _file). Thanks to Gomati Mohanan. Modified: branches

svn commit: samba-docs r1066 - in trunk/manpages-3: .

2007-03-20 Thread jmcd
Author: jmcd Date: 2007-03-20 13:05:44 + (Tue, 20 Mar 2007) New Revision: 1066 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=1066 Log: Add nfs4:chown option, and a few formatting changes. Modified: trunk/manpages-3/vfs_gpfs.8.xml Changeset: Modified

svn commit: samba-docs r1063 - in trunk/manpages-3: .

2007-03-19 Thread jmcd
Author: jmcd Date: 2007-03-19 18:29:04 + (Mon, 19 Mar 2007) New Revision: 1063 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=1063 Log: Add manpage for gpfs module. Thanks to Chetan Shringarpure [EMAIL PROTECTED] Added: trunk/manpages-3/vfs_gpfs.8.xml

svn commit: samba-docs r1064 - in trunk/manpages-3: .

2007-03-19 Thread jmcd
Author: jmcd Date: 2007-03-19 18:38:51 + (Mon, 19 Mar 2007) New Revision: 1064 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=1064 Log: A few updates to the gpfs manpage. Clarify some language, list setlease as feature, add vfs objects = gpfs to example

svn commit: samba r21637 - in branches: SAMBA_3_0/source/lib SAMBA_3_0_25/source/lib

2007-03-01 Thread jmcd
Author: jmcd Date: 2007-03-01 20:52:14 + (Thu, 01 Mar 2007) New Revision: 21637 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=21637 Log: Get password never expires account policy working. 0x8000LL is infinity to NT and should not be converted

svn commit: samba r21339 - in branches: SAMBA_3_0/source/modules SAMBA_3_0_25/source/modules

2007-02-14 Thread jmcd
Author: jmcd Date: 2007-02-14 14:25:56 + (Wed, 14 Feb 2007) New Revision: 21339 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=21339 Log: Fix the non-linux build. This is more evidence that this needs to be moved up one layer. Modified: branches/SAMBA_3_0

svn commit: samba r21324 - in branches: SAMBA_3_0/source/include SAMBA_3_0/source/modules SAMBA_3_0/source/profile SAMBA_3_0/source/smbd SAMBA_3_0_25/source/include SAMBA_3_0_25/source/modules SAMBA_3

2007-02-13 Thread jmcd
Author: jmcd Date: 2007-02-14 02:37:14 + (Wed, 14 Feb 2007) New Revision: 21324 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=21324 Log: Add linux setlease to the vfs layer. Next round, as Volker points out, it should be abstracted a little higher up so other

svn commit: samba r21004 - in branches: SAMBA_3_0/source/modules SAMBA_3_0_24/source/modules

2007-01-24 Thread jmcd
Author: jmcd Date: 2007-01-24 15:29:58 + (Wed, 24 Jan 2007) New Revision: 21004 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=21004 Log: Patch from Mathias Dietz [EMAIL PROTECTED] to fix multi-node sharemodes in gpfs. Modified: branches/SAMBA_3_0/source

svn commit: samba r20717 - in branches: SAMBA_3_0/source/modules SAMBA_3_0_24/source/modules

2007-01-12 Thread jmcd
Author: jmcd Date: 2007-01-12 21:56:25 + (Fri, 12 Jan 2007) New Revision: 20717 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=20717 Log: Merge sharemode patch from Mathias Dietz [EMAIL PROTECTED]. The patch fixes the behaviour of GPFS sharemodes when the access

svn commit: samba r20119 - in branches: SAMBA_3_0/source/utils SAMBA_3_0_24/source/utils

2006-12-12 Thread jmcd
Author: jmcd Date: 2006-12-12 16:40:57 + (Tue, 12 Dec 2006) New Revision: 20119 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=20119 Log: Update help info indicating how to use separators (forward slash only) and properly use backslashes in net ads join

svn commit: samba-docs r1003 - in trunk/manpages-3: .

2006-12-12 Thread jmcd
Author: jmcd Date: 2006-12-12 16:52:26 + (Tue, 12 Dec 2006) New Revision: 1003 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=1003 Log: Add ads-only options for net ads join Modified: trunk/manpages-3/net.8.xml Changeset: Modified: trunk/manpages-3/net

svn commit: samba-docs r1004 - in trunk/Samba3-HOWTO: .

2006-12-12 Thread jmcd
Author: jmcd Date: 2006-12-12 19:21:31 + (Tue, 12 Dec 2006) New Revision: 1004 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=1004 Log: Also update the HOWTO with the createcomputer information for net ads join Modified: trunk/Samba3-HOWTO/TOSHARG

svn commit: samba r20136 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_24/source/nsswitch

2006-12-12 Thread jmcd
Author: jmcd Date: 2006-12-12 22:05:48 + (Tue, 12 Dec 2006) New Revision: 20136 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=20136 Log: Fix #4290. Properly compute time to password expiration in message from pam_winbind. Thanks to Andrew Benham [EMAIL

svn commit: samba r20089 - in branches: SAMBA_3_0/source SAMBA_3_0/source/modules SAMBA_3_0_24/source SAMBA_3_0_24/source/modules

2006-12-08 Thread jmcd
Author: jmcd Date: 2006-12-08 18:56:01 + (Fri, 08 Dec 2006) New Revision: 20089 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=20089 Log: Put gpfs acl function into vfs_gpfs module. Thanks to Gomati Mohanan [EMAIL PROTECTED]. Also fix fields for sec_desc

svn commit: samba r19749 - in branches/SAMBA_3_0_24/source: . include lib modules smbd

2006-11-16 Thread jmcd
Author: jmcd Date: 2006-11-16 18:44:26 + (Thu, 16 Nov 2006) New Revision: 19749 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19749 Log: Merge acl vfs changes, including nfs4 acl support, from SAMBA_3_0 Added: branches/SAMBA_3_0_24/source/modules

svn commit: samba r19653 - in branches/SAMBA_3_0_24/source/libsmb: .

2006-11-10 Thread jmcd
Author: jmcd Date: 2006-11-10 15:28:44 + (Fri, 10 Nov 2006) New Revision: 19653 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19653 Log: Fix the non-krb build, a la 3.0.23 Modified: branches/SAMBA_3_0_24/source/libsmb/cliconnect.c Changeset: Modified

svn commit: samba r19654 - in branches/SAMBA_3_0_24/source: . include lib smbd

2006-11-10 Thread jmcd
Author: jmcd Date: 2006-11-10 15:40:48 + (Fri, 10 Nov 2006) New Revision: 19654 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19654 Log: merge GPFS vfs support from 3.0, including adding kernel_flock vfs op. Modified: branches/SAMBA_3_0_24/source/Makefile.in

svn commit: samba r19655 - in branches: SAMBA_3_0/source/include SAMBA_3_0_24/source/include

2006-11-10 Thread jmcd
Author: jmcd Date: 2006-11-10 15:43:29 + (Fri, 10 Nov 2006) New Revision: 19655 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19655 Log: Jeremy, please review: I updated the vfs version in 3.0.24 from 16 to 17, beacuse 16 was the latest released code

svn commit: samba r19658 - in branches/SAMBA_3_0_24/source/modules: .

2006-11-10 Thread jmcd
Author: jmcd Date: 2006-11-10 23:30:07 + (Fri, 10 Nov 2006) New Revision: 19658 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19658 Log: Forgot to add these for the gpfs code Added: branches/SAMBA_3_0_24/source/modules/gpfs.c branches/SAMBA_3_0_24/source

svn commit: samba r19647 - in branches/SAMBA_3_0/source: . include lib modules profile smbd

2006-11-09 Thread jmcd
Author: jmcd Date: 2006-11-09 20:29:31 + (Thu, 09 Nov 2006) New Revision: 19647 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19647 Log: Add some GPFS support in a vfs mod. Also adds the kernel flock op to the vfs layer, since gpfs supports it. Thanks to Volker

svn commit: samba r19648 - in branches/SAMBA_3_0/source/include: .

2006-11-09 Thread jmcd
Author: jmcd Date: 2006-11-09 21:40:40 + (Thu, 09 Nov 2006) New Revision: 19648 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19648 Log: whoops, forgot to increment the vfs version number with the added flock call. Modified: branches/SAMBA_3_0/source/include

svn commit: samba r19057 - in branches/SAMBA_3_0_23/source: passdb rpc_parse rpc_server utils

2006-10-03 Thread jmcd
Author: jmcd Date: 2006-10-03 16:48:02 + (Tue, 03 Oct 2006) New Revision: 19057 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19057 Log: backout 18726, 18748, 18754, 18758 from 3.0.23 until further testing in SAMBA_3_0. password times go back to previous

svn commit: samba r19058 - in branches/SAMBA_3_0/source: auth passdb rpc_server smbd

2006-10-03 Thread jmcd
Author: jmcd Date: 2006-10-03 17:14:18 + (Tue, 03 Oct 2006) New Revision: 19058 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19058 Log: Implement user cannot change password, and complete user must change password at next logon code. The password last set time

svn commit: samba r18722 - in branches/SAMBA_3_0/source: passdb rpc_parse rpc_server

2006-09-20 Thread jmcd
Author: jmcd Date: 2006-09-20 17:25:46 + (Wed, 20 Sep 2006) New Revision: 18722 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18722 Log: Fix up password change times. The can change and must change times are calculated based on the last change time, policies

svn commit: samba r18724 - in branches/SAMBA_3_0/source/rpc_server: .

2006-09-20 Thread jmcd
Author: jmcd Date: 2006-09-20 17:37:20 + (Wed, 20 Sep 2006) New Revision: 18724 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18724 Log: Fixup time(0) - time(NULL) Modified: branches/SAMBA_3_0/source/rpc_server/srv_samr_util.c Changeset: Modified: branches

svn commit: samba r18726 - in branches/SAMBA_3_0_23/source: passdb rpc_parse rpc_server

2006-09-20 Thread jmcd
Author: jmcd Date: 2006-09-20 17:58:16 + (Wed, 20 Sep 2006) New Revision: 18726 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18726 Log: Password time stuff from SAMBA_3_0. I'll keep them in sync next time. Modified: branches/SAMBA_3_0_23/source/passdb

svn commit: samba r18748 - in branches: SAMBA_3_0/source/utils SAMBA_3_0_23/source/utils

2006-09-20 Thread jmcd
Author: jmcd Date: 2006-09-20 22:55:44 + (Wed, 20 Sep 2006) New Revision: 18748 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18748 Log: Eliminate set of computed time values Modified: branches/SAMBA_3_0/source/utils/pdbedit.c branches/SAMBA_3_0_23/source

svn commit: samba r18754 - in branches: SAMBA_3_0/source/rpc_server SAMBA_3_0_23/source/rpc_server

2006-09-20 Thread jmcd
Author: jmcd Date: 2006-09-20 23:43:56 + (Wed, 20 Sep 2006) New Revision: 18754 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18754 Log: Get rid of some more invalid time sets Modified: branches/SAMBA_3_0/source/rpc_server/srv_samr_util.c branches

svn commit: samba r18758 - in branches: SAMBA_3_0/source/utils SAMBA_3_0_23/source/utils

2006-09-20 Thread jmcd
Author: jmcd Date: 2006-09-20 23:56:07 + (Wed, 20 Sep 2006) New Revision: 18758 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18758 Log: Update net sam to use calculated times and force change password properly. Modified: branches/SAMBA_3_0/source/utils

svn commit: samba r18702 - in branches/SAMBA_3_0/source/rpcclient: .

2006-09-19 Thread jmcd
Author: jmcd Date: 2006-09-20 00:02:51 + (Wed, 20 Sep 2006) New Revision: 18702 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18702 Log: re-enable non-decimal specification of rid Modified: branches/SAMBA_3_0/source/rpcclient/cmd_samr.c Changeset: Modified

svn commit: samba r18660 - in branches/SAMBA_3_0/source/nmbd: .

2006-09-18 Thread jmcd
Author: jmcd Date: 2006-09-19 00:39:21 + (Tue, 19 Sep 2006) New Revision: 18660 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18660 Log: Fix build, one uuid-GUID was missed. Modified: branches/SAMBA_3_0/source/nmbd/nmbd_processlogon.c Changeset: Modified

svn commit: samba r18263 - in branches/tmp/vl-messaging/source: include lib

2006-09-08 Thread jmcd
Author: jmcd Date: 2006-09-08 13:00:48 + (Fri, 08 Sep 2006) New Revision: 18263 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18263 Log: From Aleksey Fedoseev: Add database traverse for lockd-based locking, allowing locks to be seen in smbstatus. Modified

svn commit: samba r18180 - in branches/tmp/vl-messaging/source: include lib torture

2006-09-06 Thread jmcd
Author: jmcd Date: 2006-09-06 14:50:52 + (Wed, 06 Sep 2006) New Revision: 18180 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=18180 Log: From Aleksey Fedoseev, The patch consists of several modifications: 1) added preallocation of incoming stream buffer (minus

svn commit: samba r17179 - in branches/SAMBA_3_0/source: . include lib modules smbd

2006-07-21 Thread jmcd
Author: jmcd Date: 2006-07-21 15:51:34 + (Fri, 21 Jul 2006) New Revision: 17179 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=17179 Log: Merge the vl-posixacls tmp branch into mainline. It modularizes our interface into the special posix API used on the system

svn commit: samba r17154 - in branches/tmp/vl-messaging/source/lib: .

2006-07-20 Thread jmcd
Author: jmcd Date: 2006-07-20 09:37:44 + (Thu, 20 Jul 2006) New Revision: 17154 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=17154 Log: From Aleksey Fedoseev: - add some more debug - correct the unpacking functions - one shared database can be used now

svn commit: samba r16562 - in branches/tmp/vl-messaging/source: . include lib locking param

2006-06-27 Thread jmcd
Author: jmcd Date: 2006-06-27 14:24:25 + (Tue, 27 Jun 2006) New Revision: 16562 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=16562 Log: Aleksey's changes to put in dbwrapper to later enable messaging. Modified: branches/tmp/vl-messaging/source/Makefile.in

svn commit: samba r16564 - in branches/tmp/vl-messaging/source/lib: .

2006-06-27 Thread jmcd
Author: jmcd Date: 2006-06-27 15:14:56 + (Tue, 27 Jun 2006) New Revision: 16564 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=16564 Log: Whoops, forgot to add these two files. Added: branches/tmp/vl-messaging/source/lib/dbwrap.c branches/tmp/vl-messaging

svn commit: samba r16081 - in branches/tmp/vl-messaging/source: . include lib nmbd nsswitch param printing

2006-06-07 Thread jmcd
Author: jmcd Date: 2006-06-07 14:45:07 + (Wed, 07 Jun 2006) New Revision: 16081 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=16081 Log: Work from Aleksey Fedoseev to add separate messaging types Added: branches/tmp/vl-messaging/source/lib/messages_dgram.c

svn commit: samba r16047 - branches/SAMBA_3_0/source/lib trunk/source/lib

2006-06-05 Thread jmcd
Author: jmcd Date: 2006-06-05 16:59:10 + (Mon, 05 Jun 2006) New Revision: 16047 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=16047 Log: Remove unnecessary line, as this value is set in either branch of the 'if' below. Spotted by Aleksey Fedoseev. Modified

svn commit: samba r15869 - in branches/SAMBA_4_0/source/lib/charset: .

2006-05-24 Thread jmcd
Author: jmcd Date: 2006-05-24 17:47:40 + (Wed, 24 May 2006) New Revision: 15869 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15869 Log: Fix loop var to search paths for iconv Modified: branches/SAMBA_4_0/source/lib/charset/config.m4 Changeset: Modified

svn commit: samba r15872 - in branches/SAMBA_3_0/source/script/tests: .

2006-05-24 Thread jmcd
Author: jmcd Date: 2006-05-24 19:07:21 + (Wed, 24 May 2006) New Revision: 15872 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15872 Log: Take one step toward getting this working on AIX. the [-z ] stuff doesn't work there. Modified: branches/SAMBA_3_0/source

svn commit: samba r15873 - in branches/SAMBA_3_0/source/script/tests: .

2006-05-24 Thread jmcd
Author: jmcd Date: 2006-05-24 20:06:06 + (Wed, 24 May 2006) New Revision: 15873 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15873 Log: Use short signal names to placate ksh trap. bash seems to accept either and even uses them on the manpage. this should now

svn commit: samba r15874 - in trunk/source/script/tests: .

2006-05-24 Thread jmcd
Author: jmcd Date: 2006-05-24 20:20:28 + (Wed, 24 May 2006) New Revision: 15874 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15874 Log: merge make test fixes for aix/ksh Modified: trunk/source/script/tests/test_functions.sh Changeset: Modified: trunk

svn commit: samba r15719 - in branches/SAMBA_4_0/source/lib/replace: .

2006-05-19 Thread jmcd
Author: jmcd Date: 2006-05-19 18:37:35 + (Fri, 19 May 2006) New Revision: 15719 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15719 Log: Fix build on systems (AIX) that don't have vsyslog or strcasestr, with --enable-developer on. syslog() and toupper() required

svn commit: samba r15662 - in branches/tmp/vl-posixacls/source: . modules

2006-05-17 Thread jmcd
Author: jmcd Date: 2006-05-17 16:14:33 + (Wed, 17 May 2006) New Revision: 15662 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15662 Log: restore aix acl functionality. Work done by Gomati Mohanan and Peter Somogyi. Added: branches/tmp/vl-posixacls/source

svn commit: samba r15630 - branches/SAMBA_3_0/source branches/SAMBA_3_0/source/utils trunk/source trunk/source/utils

2006-05-15 Thread jmcd
Author: jmcd Date: 2006-05-16 01:21:16 + (Tue, 16 May 2006) New Revision: 15630 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15630 Log: adapt smbclient fix to smbtree to enable long share names Modified: branches/SAMBA_3_0/source/Makefile.in branches

svn commit: samba r15281 - in branches/SAMBA_4_0/source/librpc/idl: .

2006-04-26 Thread jmcd
Author: jmcd Date: 2006-04-26 14:42:47 + (Wed, 26 Apr 2006) New Revision: 15281 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=15281 Log: A few updates for consistency's sake Modified: branches/SAMBA_4_0/source/librpc/idl/wkssvc.idl Changeset: Modified

svn commit: samba r14931 - branches/SAMBA_3_0/source/libads trunk/source/libads

2006-04-05 Thread jmcd
Author: jmcd Date: 2006-04-06 01:46:01 + (Thu, 06 Apr 2006) New Revision: 14931 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14931 Log: Fix #1374: can't join an OU with name that contains '#' I had to eliminate \ as an OU path separator, because

svn commit: samba r14681 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-23 Thread jmcd
Author: jmcd Date: 2006-03-23 16:39:37 + (Thu, 23 Mar 2006) New Revision: 14681 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14681 Log: Get rid of hardcoded /tmp/add.ldif and /tmp/mod.ldif files. Is there a different directory the temp files should

svn commit: samba r14683 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-23 Thread jmcd
Author: jmcd Date: 2006-03-23 18:35:15 + (Thu, 23 Mar 2006) New Revision: 14683 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14683 Log: Get rid of hardcoded output file. With no arg, print to stdout, otherwise append to output file specified. Modified

svn commit: samba r14408 - branches/SAMBA_3_0/source/libmsrpc trunk/source/libmsrpc

2006-03-14 Thread jmcd
Author: jmcd Date: 2006-03-15 02:31:11 + (Wed, 15 Mar 2006) New Revision: 14408 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14408 Log: More on fix for coverity #36. The previous fix would cause us to marshall a buffer based on an unknown size. Zero out

svn commit: samba r14320 - in trunk/source/passdb: .

2006-03-13 Thread jmcd
Author: jmcd Date: 2006-03-13 15:04:17 + (Mon, 13 Mar 2006) New Revision: 14320 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14320 Log: Fix coverity #222: free storage before returning in error case. This error doesn't occur in 3.0. Modified: trunk/source

svn commit: samba r14252 - branches/SAMBA_3_0/source/libads trunk/source/libads

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-12 19:56:10 + (Sun, 12 Mar 2006) New Revision: 14252 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14252 Log: Fix Coverity #72: free alloc'ed storage before return. Also found one more that coverity didn't find from asprintf. Modified

svn commit: samba r14272 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 00:35:33 + (Mon, 13 Mar 2006) New Revision: 14272 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14272 Log: Fix Coverity # 81: free alloc'ed storage before returning Modified: branches/SAMBA_3_0/source/utils/smbcacls.c trunk

svn commit: samba r14278 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 01:32:30 + (Mon, 13 Mar 2006) New Revision: 14278 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14278 Log: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be specified once in an ACL, so it can be allocated

svn commit: samba r14279 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 01:42:40 + (Mon, 13 Mar 2006) New Revision: 14279 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14279 Log: Fix coverity #86, 87, 88, 89: Free grp_sid and owner_sid before returning. Also, only allow one group or owner. Modified

svn commit: samba r14280 - branches/SAMBA_3_0/source/lib trunk/source/lib

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 01:49:01 + (Mon, 13 Mar 2006) New Revision: 14280 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14280 Log: Fix Coverity #129 and 130: check before dereferencing a pointer. This was especially silly as we checked immediately _after_

svn commit: samba r14135 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 09:41:08 + (Fri, 10 Mar 2006) New Revision: 14135 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14135 Log: Fix for Coverity #123: resource leak. Also rework much of the code to make it cleaner. There's still more to do

svn commit: samba r14147 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 13:33:02 + (Fri, 10 Mar 2006) New Revision: 14147 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14147 Log: Fix coverity #119. alloc'ed memory returned not saved, so not freed. Need to go back and correct the assumption that an ldap

svn commit: samba r14150 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 14:09:34 + (Fri, 10 Mar 2006) New Revision: 14150 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14150 Log: Fix coverity #118: not freeing alloc'ed storage returned from sstring_sub(). Modified: branches/SAMBA_3_0/source/utils

svn commit: samba r14152 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 14:14:23 + (Fri, 10 Mar 2006) New Revision: 14152 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14152 Log: Fix coverity #117: free storage alloc'ed by sstring_sub Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c

svn commit: samba r14153 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 14:17:44 + (Fri, 10 Mar 2006) New Revision: 14153 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14153 Log: Fix coverity #116: free storage alloc'ed by sstring_sub() Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c

svn commit: samba r14155 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 14:20:09 + (Fri, 10 Mar 2006) New Revision: 14155 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14155 Log: Fix coverity #115: free storage alloc'ed by sstring_sub() Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c

svn commit: samba r14156 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-10 Thread jmcd
Author: jmcd Date: 2006-03-10 14:28:51 + (Fri, 10 Mar 2006) New Revision: 14156 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14156 Log: Fix coverity #114: free storage alloc'ed by sstring_sub() Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c

svn commit: samba r14085 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-09 Thread jmcd
Author: jmcd Date: 2006-03-09 18:03:54 + (Thu, 09 Mar 2006) New Revision: 14085 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14085 Log: Fix coverity bg #152, uninit'ed var. Modified: branches/SAMBA_3_0/source/utils/net_rpc_join.c trunk/source/utils

svn commit: samba r14053 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-08 Thread jmcd
Author: jmcd Date: 2006-03-08 21:29:49 + (Wed, 08 Mar 2006) New Revision: 14053 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14053 Log: Implement Simo's suggestion: don't use /dev/null for a 'bad' path for users/workstations Modified: branches/SAMBA_3_0

svn commit: samba r13948 - in branches/SAMBA_3_0/source/lib: .

2006-03-07 Thread jmcd
Author: jmcd Date: 2006-03-07 15:32:18 + (Tue, 07 Mar 2006) New Revision: 13948 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=13948 Log: Fix the build. Remove rpcclient.h include. Modified: branches/SAMBA_3_0/source/lib/display_sec.c Changeset: Modified

svn commit: samba r13949 - in trunk/source/lib: .

2006-03-07 Thread jmcd
Author: jmcd Date: 2006-03-07 15:35:52 + (Tue, 07 Mar 2006) New Revision: 13949 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=13949 Log: Fix build. Remove rpcclient include. Modified: trunk/source/lib/display_sec.c Changeset: Modified: trunk/source/lib

svn commit: samba r13957 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-07 Thread jmcd
Author: jmcd Date: 2006-03-07 16:29:25 + (Tue, 07 Mar 2006) New Revision: 13957 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=13957 Log: Based on patch from Richard Renard [EMAIL PROTECTED]: Fix machine accounts (should not have valid shells) and users

svn commit: samba r13968 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-07 Thread jmcd
Author: jmcd Date: 2006-03-07 17:49:26 + (Tue, 07 Mar 2006) New Revision: 13968 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=13968 Log: fix typo, caught by Guenther Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c trunk/source/utils

svn commit: samba r13187 - in branches/SAMBA_3_0/examples/LDAP: .

2006-01-27 Thread jmcd
Author: jmcd Date: 2006-01-27 15:14:55 + (Fri, 27 Jan 2006) New Revision: 13187 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=13187 Log: IBM Tivoli Directory Server schema updates from John Janosik [EMAIL PROTECTED] Modified: branches/SAMBA_3_0/examples/LDAP

svn commit: samba r13188 - in trunk/examples/LDAP: .

2006-01-27 Thread jmcd
Author: jmcd Date: 2006-01-27 15:31:02 + (Fri, 27 Jan 2006) New Revision: 13188 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=13188 Log: Merge from 3.0 - samba schema updates for ITDS from [EMAIL PROTECTED] Modified: trunk/examples/LDAP/samba.schema.at.IBM-DS

svn commit: samba r11886 - branches/SAMBA_3_0/source/auth trunk/source/auth

2005-11-23 Thread jmcd
Author: jmcd Date: 2005-11-23 22:08:57 + (Wed, 23 Nov 2005) New Revision: 11886 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11886 Log: Fix 3187: logon hours restrictions were off corresponding to our offset from GMT. Use gmtime() instead of localtime

svn commit: samba r11230 - branches/SAMBA_3_0/source/lib trunk/source/lib

2005-10-20 Thread jmcd
Author: jmcd Date: 2005-10-20 16:07:36 + (Thu, 20 Oct 2005) New Revision: 11230 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11230 Log: Remove the '//' i was using to test something...oops Modified: branches/SAMBA_3_0/source/lib/util_sid.c trunk/source

svn commit: samba r11236 - branches/SAMBA_3_0/source/passdb branches/SAMBA_3_0/source/rpc_server trunk/source/passdb trunk/source/rpc_server

2005-10-20 Thread jmcd
Author: jmcd Date: 2005-10-20 20:40:47 + (Thu, 20 Oct 2005) New Revision: 11236 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11236 Log: Implement user rename for smbpasswd and ldap backends. Some cleanup on tdb as well to make naming consistent. Modified

svn commit: samba r10909 - in branches/SAMBA_3_0/source: include libsmb utils

2005-10-11 Thread jmcd
Author: jmcd Date: 2005-10-11 18:42:25 + (Tue, 11 Oct 2005) New Revision: 10909 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10909 Log: Give better shutdown messages Modified: branches/SAMBA_3_0/source/include/doserr.h branches/SAMBA_3_0/source/libsmb

svn commit: samba r10910 - in trunk/source: include libsmb utils

2005-10-11 Thread jmcd
Author: jmcd Date: 2005-10-11 18:53:13 + (Tue, 11 Oct 2005) New Revision: 10910 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10910 Log: Give better shutdown messages Modified: trunk/source/include/doserr.h trunk/source/libsmb/doserr.c trunk/source/utils

svn commit: samba r10911 - branches/SAMBA_3_0/source/include branches/SAMBA_3_0/source/param branches/SAMBA_3_0/source/passdb branches/SAMBA_3_0/source/rpc_server trunk/source/include trunk/source/par

2005-10-11 Thread jmcd
Author: jmcd Date: 2005-10-11 20:14:04 + (Tue, 11 Oct 2005) New Revision: 10911 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10911 Log: part of #2861: add rename support for usrmgr.exe when using tdbsam This gets it working before replacing tdb with the samba4

svn commit: samba r10247 - in branches/SAMBA_3_0/source/utils: .

2005-09-15 Thread jmcd
Author: jmcd Date: 2005-09-15 20:39:57 + (Thu, 15 Sep 2005) New Revision: 10247 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10247 Log: Fix help text for net rpc shutdown. Modified: branches/SAMBA_3_0/source/utils/net_rpc.c Changeset: Modified: branches

svn commit: samba r10248 - in trunk/source/utils: .

2005-09-15 Thread jmcd
Author: jmcd Date: 2005-09-15 20:41:25 + (Thu, 15 Sep 2005) New Revision: 10248 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10248 Log: Fix help text for net rpc shutdown Modified: trunk/source/utils/net_rpc.c Changeset: Modified: trunk/source/utils

svn commit: samba-web r794 - in trunk/patches: .

2005-08-29 Thread jmcd
Author: jmcd Date: 2005-08-29 21:20:56 + (Mon, 29 Aug 2005) New Revision: 794 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=794 Log: Fix typos. Modified: trunk/patches/index.html Changeset: Modified: trunk/patches/index.html

svn commit: samba r9261 - in branches/SAMBA_3_0/source/rpc_server: .

2005-08-12 Thread jmcd
Author: jmcd Date: 2005-08-12 15:28:19 + (Fri, 12 Aug 2005) New Revision: 9261 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9261 Log: Fix #2976: windows member servers wouldn't alloc connections from users defined locally because if we didn't find them as a DC we

svn commit: samba r9262 - in trunk/source/rpc_server: .

2005-08-12 Thread jmcd
Author: jmcd Date: 2005-08-12 15:28:21 + (Fri, 12 Aug 2005) New Revision: 9262 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9262 Log: Fix #2976: windows member servers wouldn't alloc connections from users defined locally because if we didn't find them as a DC we

svn commit: samba r9112 - in branches/SAMBA_3_0/source: libsmb rpc_server

2005-08-05 Thread jmcd
Author: jmcd Date: 2005-08-05 12:33:00 + (Fri, 05 Aug 2005) New Revision: 9112 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9112 Log: Fix #2953 - credentials chain on DC gets out of sync with client when NT_STATUS_NO_USER returned. We were moving to the next

svn commit: samba r9113 - in trunk/source: libsmb rpc_server

2005-08-05 Thread jmcd
Author: jmcd Date: 2005-08-05 12:33:03 + (Fri, 05 Aug 2005) New Revision: 9113 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9113 Log: Fix #2953 - credentials chain on DC gets out of sync with client when NT_STATUS_NO_USER returned. We were moving to the next

svn commit: samba r9091 - in branches/SAMBA_3_0/source/include: .

2005-08-04 Thread jmcd
Author: jmcd Date: 2005-08-05 01:23:33 + (Fri, 05 Aug 2005) New Revision: 9091 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9091 Log: Fix #2954, aix 5.1 compile. Stupid aix aio.h header defines aio_error and aio_return as macros... Modified: branches

svn commit: samba r9093 - in trunk/source/include: .

2005-08-04 Thread jmcd
Author: jmcd Date: 2005-08-05 01:23:35 + (Fri, 05 Aug 2005) New Revision: 9093 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9093 Log: Fix #2954, aix 5.1 compile. Stupid aix aio.h header defines aio_error and aio_return as macros... Modified: trunk/source

svn commit: samba r8432 - in branches/SAMBA_3_0/source: auth include rpc_server

2005-07-13 Thread jmcd
Author: jmcd Date: 2005-07-13 20:04:26 + (Wed, 13 Jul 2005) New Revision: 8432 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8432 Log: Fix #2077 - login to trusted domain doesn't allow home drive map and login scripts to be executed. We were filling in our name

svn commit: samba r8433 - in trunk/source: auth include rpc_server

2005-07-13 Thread jmcd
Author: jmcd Date: 2005-07-13 20:10:26 + (Wed, 13 Jul 2005) New Revision: 8433 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8433 Log: Merge from 3.0: Fix #2077, passing our server name as the login server when logging in on trusted domain account. We now pass

svn commit: samba r8189 - in branches/SAMBA_3_0/source: lib utils

2005-07-06 Thread jmcd
Author: jmcd Date: 2005-07-06 21:02:43 + (Wed, 06 Jul 2005) New Revision: 8189 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8189 Log: commit vampire ldif patch, mostly from Don Watson ([EMAIL PROTECTED]). Yes, that's my copyright...that's just how we have to do

svn commit: samba r8190 - in trunk/source: lib utils

2005-07-06 Thread jmcd
Author: jmcd Date: 2005-07-06 21:02:46 + (Wed, 06 Jul 2005) New Revision: 8190 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8190 Log: Commit vampire ldif patch, mostly from Don Watson ([EMAIL PROTECTED]). Yes, that's my copyright...that's just how we have to do

svn commit: samba r7148 - in branches/SAMBA_3_0/source/nsswitch: .

2005-05-31 Thread jmcd
Author: jmcd Date: 2005-05-31 18:36:38 + (Tue, 31 May 2005) New Revision: 7148 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=7148 Log: Fix #2736: winbind race condition with detecting idle clients winbind idle connection closing logic is getting invoked under

svn commit: samba r7149 - in trunk/source/nsswitch: .

2005-05-31 Thread jmcd
Author: jmcd Date: 2005-05-31 18:36:59 + (Tue, 31 May 2005) New Revision: 7149 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=7149 Log: Fix #2736: winbind race condition with detecting idle clients winbind idle connection closing logic is getting invoked under

svn commit: samba r6224 - in trunk/source: include passdb rpc_server

2005-04-06 Thread jmcd
Author: jmcd Date: 2005-04-06 13:47:21 + (Wed, 06 Apr 2005) New Revision: 6224 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=6224 Log: merge patch I'd checked in on 3.0: Volker's work on ldapsam trusted lookuprids Modified: trunk/source/include/passdb.h

  1   2   3   4   5   >