Sam garm...@catalyst.net.nz
Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Tue Feb 10 07:08:28 CET 2015 on sn-devel-104
Can you prepare backports of this for our current release branches?
v4-{0,1,2}-test?
Thanks!
metze
signature.asc
Description
are available here:
http://git.samba.org/autobuild.flakey/2014-08-05-0936/samba.stderr
I fear the recent glibc security update causes segfaults...
I'll have a look at it tomorrow.
metze
signature.asc
Description: OpenPGP digital signature
Am 05.08.2014 um 22:06 schrieb Stefan (metze) Metzmacher:
Am 05.08.2014 um 09:36 schrieb autobuild:
The autobuild test system has detected an intermittent failing test in
the current master tree.
The autobuild log of the failure is available here:
http://git.samba.org/autobuild.flakey
Am 05.08.2014 um 22:08 schrieb Stefan (metze) Metzmacher:
Am 05.08.2014 um 22:06 schrieb Stefan (metze) Metzmacher:
Am 05.08.2014 um 09:36 schrieb autobuild:
The autobuild test system has detected an intermittent failing test in
the current master tree.
The autobuild log of the failure
Am 03.01.2014 17:10, schrieb Stefan (metze) Metzmacher:
Am 23.12.2013 19:42, schrieb autobuild:
The autobuild test system has detected an intermittent failing test in
the current master tree.
The autobuild log of the failure is available here:
http://git.samba.org/autobuild.flakey/2013
This introduced some problems with flakey builds, please find
a workaround attached.
I'm currently doing manual autobuild with this, lets see if it gets better
while build over the weekend.
metze
(smb_sess);
+ }
status = nt_status_squash(status);
smbsrv_sesssetup_backend_send(req, sess, status);
I think we need to talloc_steal(req, smb_sess) here.
This is similar to
https://git.samba.org/?p=samba.git;a=commitdiff;h=25494628a2e977568de0f634602ebe893d0a5b88
metze
the socket to
non-blocking.
Signed-off-by: Amitay Isaacs ami...@gmail.com
Why have you also moved the set_close_on_exec() call?
metze
signature.asc
Description: OpenPGP digital signature
(dc:local) test is flakey.
metze
Am 06.11.2012 00:13, schrieb Andrew Bartlett:
The branch, master has been updated
via ab30a8b provision: Make dsacl2fsacl() take a security.dom_sid,
not str
via 0334515 provision: Also walk directories checking ACLs
via ab5 wintest: Try
because I want us to match windows as much as
possible.
metze
signature.asc
Description: OpenPGP digital signature
mappings, if winbindd is not reachable for a
short time.
metze
signature.asc
Description: OpenPGP digital signature
stage), but more particular it of course
uses Netbios rather than DNS names.
In any case it was also unused, as we use CLDAP for reliable DC
location these days.
Found by callcatcher
I think it's a bug that it's not used.
Samba3 DCs doesn't support CLDAP.
metze
.
We no longer need to call poll() directly inside smbd !
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Fri Feb 17 02:49:13 CET 2012 on sn-devel-104
Are you sure you want to remove the START_PROFILE(smbd_idle); part?
metze
signature.asc
Description
only use state-mid = 0; on PIPE_BROKEN?
As cli_state_notify_pending() calls cli_state_disconnect(), I think we
should
always use state-mid = 0; without looking at the status.
metze
signature.asc
Description: OpenPGP digital signature
;
+ PyErr_NTSTATUS_IS_ERR_RAISE(status);
Why this changes? What was the problem?
NT_STATUS_IS_ERR() is not the same as !NT_STATUS_IS_OK()
metze
signature.asc
Description: OpenPGP digital signature
Am 23.09.2011 07:01, schrieb Matthieu Patou:
On 22/09/2011 21:14, Stefan (metze) Metzmacher wrote:
Hi Matthieu,
diff --git a/source4/ntvfs/posix/python/pyxattr_tdb.c
b/source4/ntvfs/posix/python/pyxattr_tdb.c
index 2b28aca..a08557e 100644
--- a/source4/ntvfs/posix/python/pyxattr_tdb.c
over 1h 20 now.
metze
signature.asc
Description: OpenPGP digital signature
/autobuild/flakey/b28206/samba4/bin/ab/secserver/ncalrpc: File
exists
is very strange and I can't find the related code using git grep
'creating directory'
metze
signature.asc
Description: OpenPGP digital signature
) {
+ count += 1;
+ }
if (subrec-nmb_bcast != -1) {
count += 1;
}
Can you please explain me where this can happen? I think
nmb_sock and dgram_sock are always valid.
metze
signature.asc
Description: OpenPGP digital
Hi,
I think I've fixed the problems with this flakey test:
samba3.posix_s3.winbind.wbclient .wbcListUsers
See https://bugzilla.samba.org/show_bug.cgi?id=8215 for more details.
metze
The autobuild test system has detected an intermittent failing test in
the current master tree
this by adding the missing enum values
explicit instead of
using a default, as that will make sure we'll get a warning again if
someone adds a new
value.
metze
signature.asc
Description: OpenPGP digital signature
that we'll detect things like
this in future.
Thanks!
metze
signature.asc
Description: OpenPGP digital signature
trigger that
lp_netbios_name() will return FOO, which would match the old behavior.
I guess we need something similar to handle_realm() and szRealmUpper.
metze
signature.asc
Description: OpenPGP digital signature
really only print a warning, so I guess we need to remove the
ret = 1 there.
metze
signature.asc
Description: OpenPGP digital signature
it's marked in knownfail?
To me it seems that the knownfail feature doesn't work anymore.
metze
signature.asc
Description: OpenPGP digital signature
Am 29.04.2011 21:57, schrieb Jelmer Vernooij:
On Fri, 2011-04-29 at 21:29 +0200, Stefan (metze) Metzmacher wrote:
Hi Tridge,
http://git.samba.org/autobuild.flakey/2011-04-28-0842/samba4.stderr
http://git.samba.org/autobuild.flakey/2011-04-28-0842/samba4.stdout
Any idea why
-Programmed-With: Andrew Bartlett abart...@samba.org
Can we change that, so that's it's only allowed as SYSTEM?
metze
signature.asc
Description: OpenPGP digital signature
.
metze
signature.asc
Description: OpenPGP digital signature
on the file/directory
or by FILE_DELETE_CHILD on the parent directory.
metze
I've pushed a fix for this to autobuild...
metze
signature.asc
Description: OpenPGP digital signature
,
+ 'uid_t' = 8,
+ 'gid_t' = 8,
'NTTIME' = 4,
'NTTIME_1sec' = 4,
'NTTIME_hyper' = 8,
udlong aligns to 4 byte and not to 8 as hyper would do.
metze
signature.asc
Description: OpenPGP digital signature
(10,(file_name_hash: %s hash 0x%x\n,
+ fullpath,
+ (unsigned int)*p_name_hash ));
+
+ TALLOC_FREE(fullpath);
+ return NT_STATUS_OK;
+}
These function don't calculate the same hash!
string_term_tdb_data() uses strlen()+1.
metze
signature.asc
more changes to implement the fd fairness
in lib/events.c instead of smbd/process.c.
Please have a look at:
http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-tevent2
metze
signature.asc
Description: OpenPGP digital signature
Hi Volker,
On Mon, Jan 24, 2011 at 09:14:23AM +0100, Stefan (metze) Metzmacher wrote:
I think this change is wrong because, selret is a pointer and we already
have this check (directly above):
Gna. I have first done this in 3.5, where selrtn is not a
pointer. I have then just taken
I've pushed a change that marks samba4.tokengroups.python as knownfail.
metze
Am 19.01.2011 16:44, schrieb autobu...@samba.org:
Dear Developer,
Your autobuild failed when trying to test source4 with the following error:
source4: [make] failed 'make -j' with status 2
the autobuild
how this passed autobuild, as the ECHO-UDP test can never be
found...
I'm pushing fixes for it to autobuild now.
metze
metze
signature.asc
Description: OpenPGP digital signature
'?
'+' might be a valid character in the list items.
metze
signature.asc
Description: OpenPGP digital signature
failures?
metze
signature.asc
Description: OpenPGP digital signature
a few weeks ago, please readd it.
It showed that sizeof(bool) is 1, that means that we might think about
changing the fallback to define 'bool' as 'unsigned char' instead of 'int'.
metze
signature.asc
Description: OpenPGP digital signature
groups id's
across multiple drsuapi connections.
I think we should make sure a network capture of a samba dc join
and a windows dc join look exactly the same.
metze
signature.asc
Description: OpenPGP digital signature
.
ndr_push_DATA_BLOB() called with NDR_ALIGN8, should never look at this
values
at all. And if we need to initialize them we should initialize them to zero.
metze
signature.asc
Description: OpenPGP digital signature
in netbios and dns names.
See http://support.microsoft.com/kb/909264
metze
signature.asc
Description: OpenPGP digital signature
file?
metze
signature.asc
Description: OpenPGP digital signature
.
Is it required for the s3 build ?
Yes and the standalone build in the build-farm also needs it.
See
http://build.samba.org/?tree=libreplace;function=Recent+Builds;sortby=status
It would be also good if we would backport the fixes to the release
branches.
metze
signature.asc
Description: OpenPGP digital
strptime
commit 2d0ac59fcc490517b202180f49b178ab80c2534e
Author: Matthieu Patou m...@matws.net
Date: Thu Oct 21 00:13:54 2010 +0400
replace: use a wrapper around strtoll if it didn't behave as expected
We also need this wscript changes also for the autoconf build
in libreplace.m4.
metze
(ldb, LDB_DEBUG_ERROR, no symbol `%s' found in %s:
%s, symbol, path, dlerror());
return NULL;
I think we should call dlclose() after ldb_debug() otherwise dlerror()
may not return
the desired result.
metze
signature.asc
Description: OpenPGP digital signature
);
int tdb_check (struct tdb_context *, int (*) (TDB_DATA, TDB_DATA, void *),
void *);
TDB_DATA tdb_null;
What have this tdb changes todo with the rest?
metze
signature.asc
Description: OpenPGP digital signature
to change the protocol version for this change?
See
http://gitweb.samba.org/?p=metze/ctdb/wip.git;a=shortlog;h=refs/heads/master-tdb
Here're also a few other ctdb/tdb related changes...
metze
signature.asc
Description: OpenPGP digital signature
Without this, we can get a writable pipe end, but the writev call on the
pipe
will block.
Don't we need to add some EAGAIN logic to writev_handler() ?
Currently it only handles EINTR.
metze
signature.asc
Description: OpenPGP digital signature
is broken, but we still offer it.
We should add configure checks to only allow TLS/SSL support if the
used gnutls version don't has the handshake bug.
See https://bugzilla.samba.org/show_bug.cgi?id=7218
metze
signature.asc
Description: OpenPGP digital signature
a samba4ktutil and use that instead,
until then we need to skip this test.
metze
Would it be acceptable if the tests checks if ktutil (and any other
programs that ktpass depends on ) is present ?
Matthieu
I'd prefer to build a samba4ktutil as we do for samba4kinit,
this would
(unique_id)) == 0);
+ state-exists = (memcmp(state-id-unique_id, data.dptr,
+ sizeof(unique_id)) == 0);
return 0;
isn't the unique_id variable unused, if we use
sizeof(state-id-unique_id)?
metze
signature.asc
Description: OpenPGP digital signature
.
I also noticed that rIDUsedPool is never updated on a w2k8r2 server (at
least if it's
the rid master itself).
The changes can be found here:
http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-s3upgrade-review
If they're no objections I've planed to push this changes
.
metze
metze
signature.asc
Description: OpenPGP digital signature
(and nothing else) and the
lanman authentication is deactivated then we end in an account with no
password attribute at all! Lock this down.
I think the correct behavior is to reject the password change in that case.
metze
signature.asc
Description: OpenPGP digital signature
Am 23.06.2010 09:08, schrieb Matthias Dieter Wallnöfer:
Hi metze,
I reject it when the lanman auth is deactivated. But otherwise it should
be enabled (think at dcesrv_samr_ChangeOemPassword2 which manipulates
only the lanman hash - tested using the passwords torture test).
Therefore
use?
If so args-status is wrong now and we better keep an 'int _not_used'.
metze
signature.asc
Description: OpenPGP digital signature
' instead of 'True'
here too?
metze
signature.asc
Description: OpenPGP digital signature
gets this:
http://pastie.org/985637
(I assume the s4 build will have the same problem)
metze
signature.asc
Description: OpenPGP digital signature
*, const char *)
Waf: Leaving directory `/home/metze/master4/source4/bin'
Build failed: ABI for libldb-samba4.so has changed - please fix library
version then build with --abi-update
See http://wiki.samba.org/index.php/Waf#ABI_Checking for more information
make: *** [all] Fehler 1
metze
x$samba_cv_HAVE_qhalt = xyes; then
+ Werror_FLAGS=-qhalt=w
+fi
I think we also need -qhalt=e here, to match -Werror.
I'm wondering if --errwarn is the correct thing for the sun case...
metze
signature.asc
Description: OpenPGP digital signature
it in SMB1.
Jeremy.
I guess we still need the chunked message support, it's less likely
to happen with the smb2 buffer sizes and a really large krb5 PAC
should not cause problems in production environments later...
metze
.
metze
signature.asc
Description: OpenPGP digital signature
as client...
metze
signature.asc
Description: OpenPGP digital signature
(state-out_output_buffer.data,
req)) {
+ return tevent_req_post(req, ev);
+ }
+ }
can't we use talloc_move here and avoid a memdup?
metze
signature.asc
Description: OpenPGP digital signature
a lot, thanks for the good work!
metze
signature.asc
Description: OpenPGP digital signature
more and more occourences. Therefore
I would simply propose to allow it for s4 as well.
I think it's fine to use it also in source4.
metze
signature.asc
Description: OpenPGP digital signature
...:-)
metze
signature.asc
Description: OpenPGP digital signature
you noticed that smbd_smb2_send_oplock_break() already exists and you
just have to call it from send_smb2_break_message()?
metze
signature.asc
Description: OpenPGP digital signature
.
As these always call exit_server, make that part of the function.
Use _internal functions for the echo client.
Metze please check !
The changes look ok...
Summary of changes:
source3/smbd/globals.h | 10 -
source3/smbd/process.c | 78
express the same with valid NDR.
Something like:
[value(strlen(dns_name))] uint32 dns_name_size;
[charset(UTF8)] uint8 dns_name[dns_name_size];
should do the same.
Can you send me a file I can pass to ndrdump to test it?
metze
PS: It would be nice if you wouldn't introduce leading whitespaces
Hi Rusty,
does it make sense to create a new tdb version,
or do you have some more changes pending?
metze
The branch, master has been updated
via ec96ea6... tdb: handle processes dying during transaction commit.
via 1bf482b... patch tdb-refactor-tdb_lock
was:
tsocket/bsd: fix bug #7115 FreeBSD includes the UDP header in FIONREAD
Metze, this has to have been wrong - you are throwing away the
talloc_realloc
pointer returned. Also no error checking. Please review.
Thank goodness for gcc warnings :-).
talloc_realloc would
Tim Prouty schrieb:
On Dec 4, 2009, at 2:47 AM, Stefan (metze) Metzmacher wrote:
Hi Tim,
diff --git a/source4/selftest/knownfail b/source4/selftest/knownfail
index e2ae2cf..37c9f6a 100644
--- a/source4/selftest/knownfail
+++ b/source4/selftest/knownfail
@@ -10,9 +10,7
:-)
metze
--;
+ }
+ }
+
We need to be careful about this, an empty element means
we should remove existing values.
If remove the empty ones here, we need to let the repl_meta_data module
remove them based on the received meta_data array.
metze
signature.asc
Description: OpenPGP digital
=samba4
--basedir=/home/metze/tmp/st-master4/s4client
--option=torture:progress=no --format=subunit //$SERVER/tmp
-U$USERNAME%$PASSWORD --option=torture:sharedelay=1
--option=torture:oplocktimeout=3
--option=torture:writetimeupdatedelay=5 RAW-SFILEINFO
ERROR: Testsuite[samba4.raw.sfileinfo (dc
Hi Björn.
- Log -
commit a80a0b7728de21e992f8f0b3e31b600441a6535d
Author: Björn Jacke b...@sernet.de
Date: Sat Oct 31 10:37:44 2009 +0100
s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient
I think talloc and
keep
SHLD_MODULE, but use a new SHLD_LIBRARY for shared libraries.
It would also be nice to use
AC_LIBREPLACE_SHLD
AC_LIBREPLACE_SHLD_FLAGS
and
AC_LIBREPLACE_MDLD
AC_LIBREPLACE_MDLD_FLAGS
from libreplace. There we could also add the sun specifc flags genericly
for source3 and source4.
metze
, params, 4);
root_fid is a union, you can't set two union arms at the same time.
It's really confusing to read this code...
metze
can't change existing code!
At least we need to add the old enum values as defines to the new ones.
metze
WBC_PWD_CHANGE_REJECT_COMPLEXITY \
WBC_PWD_CHANGE_NOT_COMPLEX
metze
think they're wrong, functions which allocate memory should not
return const pointers, otherwise we'll get warnings when calling
talloc_free() on them.
metze
signature.asc
Description: OpenPGP digital signature
! Now to
see if all the attributes came across correctly.
I think we need to use the GUID if it's valid and fallback to SID and
finality to the dn, if the sid is also zero.
metze
signature.asc
Description: OpenPGP digital signature
. Change the name of read_socket_with_timeout() to
read_fd_with_timeout() to make this clear (and add comments).
Jeremy.
I think we should have 2 functions then.
We need to use sys_recv() on sockets, otherwise our socket_wrapper pcap
support doesn't work.
metze
signature.asc
Description
tree.
metze
signature.asc
Description: OpenPGP digital signature
Andrew Bartlett schrieb:
On Tue, 2009-08-25 at 08:46 +0200, Stefan (metze) Metzmacher wrote:
Hi Andrew,
static int show_deleted_search(struct ldb_module *module, struct
ldb_request *req)
{
struct ldb_context *ldb;
struct ldb_control *control;
struct ldb_control
xattr_DosAttrib struct used by
samba4.
But I think we should rename xattr_DosAttrib into
xattr_DosInforation or xattr_DosMetaData.
As *XATTR_DOSATTRIB_NAME = user.DosAttrib;
and #define SAMBA_XATTR_DOS_ATTRIB user.DOSATTRIB are different.
metze
6a9e0039100b57f9626e87defec6720c476b9789
still panics in the reproducible test case for bug
6564, as this is one case where such a message
(MSG_SMB_CONF_UPDATED) is sent to the parent. Metze
please check. This change passes valgrind.
Jeremy.
I think it is thte wrong approach, smbd_server_connection
that the
server doesn't crash when the test runs against it.
metze
Excellent, thanks Metze. Do we have any kind of document that describes best
practices for writing torture tests? If not I can start a wiki page.
That would be great.
Thus, far I have mostly copied style from other tests
.
Is there anyone working on the server side of this?
metze
signature.asc
Description: OpenPGP digital signature
8cb44830e0356804e21d9973382e0070f20b15be and
f49129e59225f6ea84add8e845ffaeb03dc6c8da for the reasons.
It would be also nice to run 'make test' or 'make test TESTS=smb2'
in s4.
metze
signature.asc
Description: OpenPGP digital signature
torture_comment() instead of printf()
and all torture_assert* functions instead of just returning false in a
test. Then make test reports them as failures instead of errors
and it's easy to mark them as known failures. This makes sure that the
server doesn't crash when the test runs against it.
metze
parameters, the function always gets a copy of the callers variable.
Also you missed a const in the proto.h for set_sticky_write_time_path()
which is present in the function.
metze
signature.asc
Description: OpenPGP digital signature
,
when libtalloc.so.1 and libtalloc.so.2 are loaded into the same process.
Like this:
http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=c534a8af46e1efbfad8cd953dadb3a68b29b9919
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -57,7 +57,9 @@
#define MAX_TALLOC_SIZE 0x1000
it symmetric?
metze
signature.asc
Description: OpenPGP digital signature
= addr + 7;
+ }
+ if ((strcmp(p, ip) == 0) || (strcmp(addr, ip) == 0)) {
if p could be NULL based on the decision above we need to check this
before passing p to strcmp().
metze
signature.asc
Description: OpenPGP digital signature
input parameters to a _send() function need to
be arround until the _recv function is called.
metze
signature.asc
Description: OpenPGP digital signature
,
if it uses an invalid vuid?
A torture test for this would also be very useful.
metze
metze
signature.asc
Description: OpenPGP digital signature
-
commit 621d40332aad9d99b14c45155308a394c31b98b5
Author: Günther Deschner g...@samba.org
Date: Fri Apr 3 00:30:13 2009 +0200
s3-build: fix the build after tsocket changes.
Metze, please check.
Thanks
example shows we need to be extremly careful and add
explicit cast in the right spots in order to avoid upgrade problems.
metze
signature.asc
Description: OpenPGP digital signature
1 - 100 of 4517 matches
Mail list logo
