Re: [scikit-learn] Code review

2016-06-23 Thread Raghav R V
Reg. the "Needs Review" tag - Could I request the maintainers to unlabel the PR once a review has been completed and is waiting for the author? (Should filter out a lot of noise). The use case I envision for this tag would be to serve as a bookmark or a green flag to the maintainer who labels it s

Re: [scikit-learn] Code review

2016-06-23 Thread Joel Nothman
On 23 June 2016 at 22:47, Raghav R V wrote: > > "nag if needed"! > > I always assume it to be an implicit advice ;P > I could tell. ___ scikit-learn mailing list [email protected] https://mail.python.org/mailman/listinfo/scikit-learn

Re: [scikit-learn] Code review

2016-06-23 Thread Raghav R V
> "nag if needed"! I always assume it to be an implicit advice ;P On Wed, Jun 22, 2016 at 9:39 PM, Andreas Mueller wrote: > Sorry, I've been off review duty for a while, should be back later this > summer ;) > > > On 06/21/2016 12:09 AM, olologin wrote: > >> Hi guys, I know scikit-learn may not

Re: [scikit-learn] Code review

2016-06-22 Thread Andreas Mueller
Sorry, I've been off review duty for a while, should be back later this summer ;) On 06/21/2016 12:09 AM, olologin wrote: Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it. Is

Re: [scikit-learn] Code review

2016-06-20 Thread Joel Nothman
I think perhaps that FAQ should be updated to say "nag if needed"! Apologies for that delay, @olologin. Yes, it would be good if we had a better way of organising reviewing priorities, but between github's feature set and the distributed nature of the core dev team, we land up relying on chance, o

Re: [scikit-learn] Code review

2016-06-20 Thread Nelson Liu
The review process has always been quite slow; the only thing you can do is ping and try to fix things on your side as quickly as possible. There are a lot of PRs in development at any one time, and it's difficult for the reviewers (let alone the contributors, as you mentioned) to keep track of eve

[scikit-learn] Code review

2016-06-20 Thread olologin
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it. Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 mo