Re: [Scikit-learn-general] BallTree and memoryviews

2012-07-16 Thread Andreas Mueller
On 07/17/2012 07:40 AM, Olivier Grisel wrote: > 2012/7/16 Andreas Mueller : >> On 07/16/2012 09:55 PM, Gael Varoquaux wrote: >>> On Mon, Jul 16, 2012 at 01:13:55PM -0700, Jake Vanderplas wrote: How do folks feel about using this sort of bleeding-edge cython syntax in scikit-learn? >>> I w

Re: [Scikit-learn-general] BallTree and memoryviews

2012-07-16 Thread Gael Varoquaux
On Tue, Jul 17, 2012 at 08:40:31AM +0200, Olivier Grisel wrote: > Still for new code I think it's better to use memoryviews rather than > manual pointer manipulation that is prone to segfaulting. I agree. G -- Live Secur

Re: [Scikit-learn-general] BallTree and memoryviews

2012-07-16 Thread Olivier Grisel
2012/7/16 Andreas Mueller : > On 07/16/2012 09:55 PM, Gael Varoquaux wrote: >> On Mon, Jul 16, 2012 at 01:13:55PM -0700, Jake Vanderplas wrote: >>> How do folks feel about using this sort of bleeding-edge cython syntax >>> in scikit-learn? >> I wouldn't mind waiting another year: it's not like we d

Re: [Scikit-learn-general] BallTree and memoryviews

2012-07-16 Thread Andreas Mueller
On 07/16/2012 09:55 PM, Gael Varoquaux wrote: > On Mon, Jul 16, 2012 at 01:13:55PM -0700, Jake Vanderplas wrote: >> How do folks feel about using this sort of bleeding-edge cython syntax >> in scikit-learn? > I wouldn't mind waiting another year: it's not like we don't have plenty > of things to do

Re: [Scikit-learn-general] BallTree and memoryviews

2012-07-16 Thread Gael Varoquaux
On Mon, Jul 16, 2012 at 01:13:55PM -0700, Jake Vanderplas wrote: > How do folks feel about using this sort of bleeding-edge cython syntax > in scikit-learn? I wouldn't mind waiting another year: it's not like we don't have plenty of things to do, and there is no urgency. That's my typical respon

[Scikit-learn-general] BallTree and memoryviews

2012-07-16 Thread Jake Vanderplas
Hello, There has been some interesting discussion regarding cKDTree recently on the scipy-dev list (see thread starting at http://mail.scipy.org/pipermail/scipy-dev/2012-July/017737.html) and I've been reading it with a lot of interest. Based on what Sturla is saying within these messages, the

Re: [Scikit-learn-general] "Improved" GLMNET

2012-07-16 Thread Alexandre Gramfort
>> if it is I would seriously consider patching Liblinear to allow warm >> restart than starting a complete reimplementation. > > I guess that part of your message is that backporting the latest > liblinear to run speed tests might be important. yes and eventually give up on a complete reimplement

Re: [Scikit-learn-general] Summary of my recent blog post and GSoC progress

2012-07-16 Thread Peter Prettenhofer
It seems like vbench is failing when it tries to run the following git command:: $ git --git-dir=/home/pprett/workspace/scikit-learn/.git/ --work-tree=/home/pprett/workspace/scikit-learn/ log [...] > githist.txt fatal: Could not jump back into original cwd: No such file or directory It wo

Re: [Scikit-learn-general] Summary of my recent blog post and GSoC progress

2012-07-16 Thread Andreas Mueller
Maybe what would be nice is to be able to pass a list of commits, so we can add data points for every release. Benchmarks that fail because of the estimator not existing in that release will simply not appear. > do whatever is reasonable with a trade off usefulness / time investment. > > it wa

Re: [Scikit-learn-general] "Improved" GLMNET

2012-07-16 Thread Gael Varoquaux
On Sun, Jul 15, 2012 at 10:01:26PM +0200, Alexandre Gramfort wrote: > if it is I would seriously consider patching Liblinear to allow warm > restart than starting a complete reimplementation. I guess that part of your message is that backporting the latest liblinear to run speed tests might be imp