RE: SCM plugin project
Thanks Mark. I will do that. --- Todd Thiessen > -Original Message- > From: Mark Struberg [mailto:[email protected]] > Sent: Monday, January 19, 2009 9:37 AM > To: [email protected] > Subject: RE: SCM plugin project > > Open a Jira, ship the patch, and I bet you'll get response. > > LieGrü, > strub > > > --- Todd Thiessen schrieb am Mo, 19.1.2009: > > > Von: Todd Thiessen > > Betreff: RE: SCM plugin project > > An: [email protected] > > Datum: Montag, 19. Januar 2009, 15:16 > > Are there any further comments regarding this? Do we need > to open the > > discussion to a wider audience to get some traction on it? > > > > --- > > Todd Thiessen > > > > > > > -Original Message- > > > From: Thiessen, Todd (BVW:9T16) > > > Sent: Thursday, January 15, 2009 10:49 AM > > > To: '[email protected]' > > > Subject: RE: SCM plugin project > > > > > > Yes it occurs in a standard SVN installation. This is > > done by > > > using svn hooks which is precisely what we have. > > Anyone can > > > change the output of the svn log command (ie: no > > change to > > > svn source is required). So yes I definiately > > consider this > > > standard. It isn't considered "default" > > behaviour, but I > > > would definitely describe it as standard. > > > > > > It is my opinion that this fix should be in the main > > repo. > > > Individual users/companies should not have to maintain > > their > > > own copy of it. It makes synchronizing changes between > > the > > > main repo and all others an extra chore that > > shouldn't be necessary. > > > > > > We should also take note that Subversion does not make > > any > > > guarantees regarding the format of the svn log author > > output. > > > They could very well change this "default" > > behaviour to > > > something that doesn't match what is currently > > being parsed. > > > So the fix I am proposing makes the code base more > > robust, > > > which is always a good thing. > > > > > > --- > > > Todd Thiessen > > > > > > > > > > -Original Message- > > > > From: Mark Struberg [mailto:[email protected]] > > > > Sent: Thursday, January 15, 2009 10:30 AM > > > > To: [email protected] > > > > Subject: RE: SCM plugin project > > > > > > > > Humm, so this SVN behaviour cannot occur in a > > standard SVN > > > > installation? Or can this also be achieved by > > anyone? If > > > not, there is > > > > imho little chance of getting your changes into > > the upstream repo. > > > > > > > > Do you have a parent pom for your projects? Have > > you tried > > > to override > > > > the dependency on maven-scm-provider-svnexe for > > your build to a > > > > locally patched version via > > ? > > > > > > > > I assume you have something like archiva, > > mavenproxy or nexus setup > > > > and also have a company-internal plugin > > repository, isn't? > > > > > > > > So you could easily make the release process work > > for your company > > > > without having to release your changes to the > > public repo. > > > > > > > > LieGrue, > > > > strub > > > > > > > > > > > > --- Todd Thiessen > > schrieb am Do, 15.1.2009: > > > > > > > > > Von: Todd Thiessen > > > > > > > Betreff: RE: SCM plugin project > > > > > An: [email protected] > > > > > Datum: Donnerstag, 15. Januar 2009, 15:33 > > > > > > > http://www.mail-archive.com/[email protected]/msg01173.html > > > > > > > > > > It seems I wasn't actually subscribed to > > scm-dev so I > > > > didn't' get this > > > > > response right away. Thanks for the response > > Mark. > > > > > > > > > > I have actually tested this and have seen it > > fail. We have made > > > > > modifications to SVN to print out the author > > differently. > > > > > I noticed the > > > > > problem when I tried running the changelog > > report and got > > > > no output. > > > > > I was bashing my head on my desk trying to > > figure out why for the > > > > > longest time ;-). > > > > > > > > > > I have also already made the modifications > > to the > > > > > maven-scm-provider-svnexe project and added > > all appropriate test > > > > > cases. > > > > > My initial plan was to simply store a copy > > of the source > > > in our svn > > > > > repo. However, I now have permission to > > submit this to the proper > > > > > place. > > > > > > > > > > I will raise a JIRA to track the issue and > > then I would > > > > like to submit > > > > > a patch for all appropriate personnel to > > review. Do I > > > > simply attach > > > > > an SVN patch to this mailing list? > > > > > > > > > > --- > > > > > Todd Thiessen > > > > > > > > > > > > > > > > > > > > > > >
RE: SCM plugin project
Open a Jira, ship the patch, and I bet you'll get response. LieGrü, strub --- Todd Thiessen schrieb am Mo, 19.1.2009: > Von: Todd Thiessen > Betreff: RE: SCM plugin project > An: [email protected] > Datum: Montag, 19. Januar 2009, 15:16 > Are there any further comments regarding this? Do we need to > open the > discussion to a wider audience to get some traction on it? > > --- > Todd Thiessen > > > > -Original Message- > > From: Thiessen, Todd (BVW:9T16) > > Sent: Thursday, January 15, 2009 10:49 AM > > To: '[email protected]' > > Subject: RE: SCM plugin project > > > > Yes it occurs in a standard SVN installation. This is > done by > > using svn hooks which is precisely what we have. > Anyone can > > change the output of the svn log command (ie: no > change to > > svn source is required). So yes I definiately > consider this > > standard. It isn't considered "default" > behaviour, but I > > would definitely describe it as standard. > > > > It is my opinion that this fix should be in the main > repo. > > Individual users/companies should not have to maintain > their > > own copy of it. It makes synchronizing changes between > the > > main repo and all others an extra chore that > shouldn't be necessary. > > > > We should also take note that Subversion does not make > any > > guarantees regarding the format of the svn log author > output. > > They could very well change this "default" > behaviour to > > something that doesn't match what is currently > being parsed. > > So the fix I am proposing makes the code base more > robust, > > which is always a good thing. > > > > --- > > Todd Thiessen > > > > > > > -Original Message- > > > From: Mark Struberg [mailto:[email protected]] > > > Sent: Thursday, January 15, 2009 10:30 AM > > > To: [email protected] > > > Subject: RE: SCM plugin project > > > > > > Humm, so this SVN behaviour cannot occur in a > standard SVN > > > installation? Or can this also be achieved by > anyone? If > > not, there is > > > imho little chance of getting your changes into > the upstream repo. > > > > > > Do you have a parent pom for your projects? Have > you tried > > to override > > > the dependency on maven-scm-provider-svnexe for > your build to a > > > locally patched version via > ? > > > > > > I assume you have something like archiva, > mavenproxy or nexus setup > > > and also have a company-internal plugin > repository, isn't? > > > > > > So you could easily make the release process work > for your company > > > without having to release your changes to the > public repo. > > > > > > LieGrue, > > > strub > > > > > > > > > --- Todd Thiessen > schrieb am Do, 15.1.2009: > > > > > > > Von: Todd Thiessen > > > > > Betreff: RE: SCM plugin project > > > > An: [email protected] > > > > Datum: Donnerstag, 15. Januar 2009, 15:33 > > > > > http://www.mail-archive.com/[email protected]/msg01173.html > > > > > > > > It seems I wasn't actually subscribed to > scm-dev so I > > > didn't' get this > > > > response right away. Thanks for the response > Mark. > > > > > > > > I have actually tested this and have seen it > fail. We have made > > > > modifications to SVN to print out the author > differently. > > > > I noticed the > > > > problem when I tried running the changelog > report and got > > > no output. > > > > I was bashing my head on my desk trying to > figure out why for the > > > > longest time ;-). > > > > > > > > I have also already made the modifications > to the > > > > maven-scm-provider-svnexe project and added > all appropriate test > > > > cases. > > > > My initial plan was to simply store a copy > of the source > > in our svn > > > > repo. However, I now have permission to > submit this to the proper > > > > place. > > > > > > > > I will raise a JIRA to track the issue and > then I would > > > like to submit > > > > a patch for all appropriate personnel to > review. Do I > > > simply attach > > > > an SVN patch to this mailing list? > > > > > > > > --- > > > > Todd Thiessen > > > > > > > > > > > > > >
RE: SCM plugin project
Are there any further comments regarding this? Do we need to open the discussion to a wider audience to get some traction on it? --- Todd Thiessen > -Original Message- > From: Thiessen, Todd (BVW:9T16) > Sent: Thursday, January 15, 2009 10:49 AM > To: '[email protected]' > Subject: RE: SCM plugin project > > Yes it occurs in a standard SVN installation. This is done by > using svn hooks which is precisely what we have. Anyone can > change the output of the svn log command (ie: no change to > svn source is required). So yes I definiately consider this > standard. It isn't considered "default" behaviour, but I > would definitely describe it as standard. > > It is my opinion that this fix should be in the main repo. > Individual users/companies should not have to maintain their > own copy of it. It makes synchronizing changes between the > main repo and all others an extra chore that shouldn't be necessary. > > We should also take note that Subversion does not make any > guarantees regarding the format of the svn log author output. > They could very well change this "default" behaviour to > something that doesn't match what is currently being parsed. > So the fix I am proposing makes the code base more robust, > which is always a good thing. > > --- > Todd Thiessen > > > > -Original Message- > > From: Mark Struberg [mailto:[email protected]] > > Sent: Thursday, January 15, 2009 10:30 AM > > To: [email protected] > > Subject: RE: SCM plugin project > > > > Humm, so this SVN behaviour cannot occur in a standard SVN > > installation? Or can this also be achieved by anyone? If > not, there is > > imho little chance of getting your changes into the upstream repo. > > > > Do you have a parent pom for your projects? Have you tried > to override > > the dependency on maven-scm-provider-svnexe for your build to a > > locally patched version via ? > > > > I assume you have something like archiva, mavenproxy or nexus setup > > and also have a company-internal plugin repository, isn't? > > > > So you could easily make the release process work for your company > > without having to release your changes to the public repo. > > > > LieGrue, > > strub > > > > > > --- Todd Thiessen schrieb am Do, 15.1.2009: > > > > > Von: Todd Thiessen > > > Betreff: RE: SCM plugin project > > > An: [email protected] > > > Datum: Donnerstag, 15. Januar 2009, 15:33 > > > http://www.mail-archive.com/[email protected]/msg01173.html > > > > > > It seems I wasn't actually subscribed to scm-dev so I > > didn't' get this > > > response right away. Thanks for the response Mark. > > > > > > I have actually tested this and have seen it fail. We have made > > > modifications to SVN to print out the author differently. > > > I noticed the > > > problem when I tried running the changelog report and got > > no output. > > > I was bashing my head on my desk trying to figure out why for the > > > longest time ;-). > > > > > > I have also already made the modifications to the > > > maven-scm-provider-svnexe project and added all appropriate test > > > cases. > > > My initial plan was to simply store a copy of the source > in our svn > > > repo. However, I now have permission to submit this to the proper > > > place. > > > > > > I will raise a JIRA to track the issue and then I would > > like to submit > > > a patch for all appropriate personnel to review. Do I > > simply attach > > > an SVN patch to this mailing list? > > > > > > --- > > > Todd Thiessen > > > > > > > > >
RE: SCM plugin project
Yes it occurs in a standard SVN installation. This is done by using svn hooks which is precisely what we have. Anyone can change the output of the svn log command (ie: no change to svn source is required). So yes I definiately consider this standard. It isn't considered "default" behaviour, but I would definitely describe it as standard. It is my opinion that this fix should be in the main repo. Individual users/companies should not have to maintain their own copy of it. It makes synchronizing changes between the main repo and all others an extra chore that shouldn't be necessary. We should also take note that Subversion does not make any guarantees regarding the format of the svn log author output. They could very well change this "default" behaviour to something that doesn't match what is currently being parsed. So the fix I am proposing makes the code base more robust, which is always a good thing. --- Todd Thiessen > -Original Message- > From: Mark Struberg [mailto:[email protected]] > Sent: Thursday, January 15, 2009 10:30 AM > To: [email protected] > Subject: RE: SCM plugin project > > Humm, so this SVN behaviour cannot occur in a standard SVN > installation? Or can this also be achieved by anyone? If not, > there is imho little chance of getting your changes into the > upstream repo. > > Do you have a parent pom for your projects? Have you tried to > override the dependency on maven-scm-provider-svnexe for your > build to a locally patched version via ? > > I assume you have something like archiva, mavenproxy or nexus > setup and also have a company-internal plugin repository, isn't? > > So you could easily make the release process work for your > company without having to release your changes to the public repo. > > LieGrue, > strub > > > --- Todd Thiessen schrieb am Do, 15.1.2009: > > > Von: Todd Thiessen > > Betreff: RE: SCM plugin project > > An: [email protected] > > Datum: Donnerstag, 15. Januar 2009, 15:33 > > http://www.mail-archive.com/[email protected]/msg01173.html > > > > It seems I wasn't actually subscribed to scm-dev so I > didn't' get this > > response right away. Thanks for the response Mark. > > > > I have actually tested this and have seen it fail. We have made > > modifications to SVN to print out the author differently. > > I noticed the > > problem when I tried running the changelog report and got > no output. > > I was bashing my head on my desk trying to figure out why for the > > longest time ;-). > > > > I have also already made the modifications to the > > maven-scm-provider-svnexe project and added all appropriate test > > cases. > > My initial plan was to simply store a copy of the source in our svn > > repo. However, I now have permission to submit this to the proper > > place. > > > > I will raise a JIRA to track the issue and then I would > like to submit > > a patch for all appropriate personnel to review. Do I > simply attach > > an SVN patch to this mailing list? > > > > --- > > Todd Thiessen > > > >
RE: SCM plugin project
Humm, so this SVN behaviour cannot occur in a standard SVN installation? Or can this also be achieved by anyone? If not, there is imho little chance of getting your changes into the upstream repo. Do you have a parent pom for your projects? Have you tried to override the dependency on maven-scm-provider-svnexe for your build to a locally patched version via ? I assume you have something like archiva, mavenproxy or nexus setup and also have a company-internal plugin repository, isn't? So you could easily make the release process work for your company without having to release your changes to the public repo. LieGrue, strub --- Todd Thiessen schrieb am Do, 15.1.2009: > Von: Todd Thiessen > Betreff: RE: SCM plugin project > An: [email protected] > Datum: Donnerstag, 15. Januar 2009, 15:33 > http://www.mail-archive.com/[email protected]/msg01173.html > > It seems I wasn't actually subscribed to scm-dev so I > didn't' get this > response right away. Thanks for the response Mark. > > I have actually tested this and have seen it fail. We have > made > modifications to SVN to print out the author differently. > I noticed the > problem when I tried running the changelog report and got > no output. I > was bashing my head on my desk trying to figure out why for > the longest > time ;-). > > I have also already made the modifications to the > maven-scm-provider-svnexe project and added all appropriate > test cases. > My initial plan was to simply store a copy of the source in > our svn > repo. However, I now have permission to submit this to the > proper place. > > I will raise a JIRA to track the issue and then I would > like to submit a > patch for all appropriate personnel to review. Do I simply > attach an > SVN patch to this mailing list? > > --- > Todd Thiessen
RE: SCM plugin project
http://www.mail-archive.com/[email protected]/msg01173.html It seems I wasn't actually subscribed to scm-dev so I didn't' get this response right away. Thanks for the response Mark. I have actually tested this and have seen it fail. We have made modifications to SVN to print out the author differently. I noticed the problem when I tried running the changelog report and got no output. I was bashing my head on my desk trying to figure out why for the longest time ;-). I have also already made the modifications to the maven-scm-provider-svnexe project and added all appropriate test cases. My initial plan was to simply store a copy of the source in our svn repo. However, I now have permission to submit this to the proper place. I will raise a JIRA to track the issue and then I would like to submit a patch for all appropriate personnel to review. Do I simply attach an SVN patch to this mailing list? --- Todd Thiessen
RE: SCM plugin project
If one can use such names (never tried that myself) then I totally aggree. What happens if the Author has 3 names, e.g. "Mark Emil Struberg" ... The simplest thing would be to setup a svn repo, add a change with such a user and do a 'svn log > src/test/resources/svn/changelog/svnlog_username.txt' Then add a small test case in maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogConsumerTest.java LieGrue, strub --- Todd Thiessen schrieb am Mi, 14.1.2009: > Von: Todd Thiessen > Betreff: RE: SCM plugin project > An: [email protected] > Datum: Mittwoch, 14. Januar 2009, 15:08 > b). So I am moving this over to scm-dev ;-). > > Ok, here are some of the details. > > The problem is actually with the maven-scm-provider-svnexe > project. More > specifically, the changelog consumer > (SvnChangeLogConsumer). > > This class has a couple of regular expressions to parse the > header of > the svn log output. This regular expression isn't as > robust as it could > be. > > The SvnChangeLogConsumer expects the author to be in a very > specific > format. Here is a snippet of the author regular expression. > > (\\(\\S+\\s+\\S+\\)|\\S+) > > This fits two basic formats for author: > > (firstname lastname) > > or > > username > > But what happens if the first or last name contains spaces? > The entire > header does not match and the changelog returns nothing. > > Further, Subversion does not guarantee the format of the > author. Hooks > can be added to subversion to modify the author again > resulting in an > empty changelog. > > The change log consumer should simply consume whatever is > in the author > section of the output to keep these kind of mismatches from > happening. > This allows for a header match to be found and the > scm:changelog command > to produce reasonable output. > > So I recommend that we change the parsing of the author to > pull in > anything. > > --- > Todd Thiessen > > > > -Original Message- > > From: Mark Struberg [mailto:[email protected]] > > Sent: Tuesday, January 13, 2009 5:49 PM > > To: Maven Users List > > Subject: RE: SCM plugin project > > > > Hi Todd! > > > > Is it a) an enhancement to the maven-scm-plugin > itself? > > Or b) does it dig deeper into maven-scm and we have to > change > > the scm-API too? > > > > For both options you'd probably file a Jira [1] > which > > describes the motivation and the changes you like to > do > > first. Then you may attach a patch or provide your > changes > > via a online repo. > > I personally would prefer git ;) > > > > For option b) we should definitely switch over to the > scm-dev > > list again. > > > > LieGrue, > > strub > > > > [1] http://jira.codehaus.org/browse/SCM > > > >
RE: SCM plugin project
b). So I am moving this over to scm-dev ;-). Ok, here are some of the details. The problem is actually with the maven-scm-provider-svnexe project. More specifically, the changelog consumer (SvnChangeLogConsumer). This class has a couple of regular expressions to parse the header of the svn log output. This regular expression isn't as robust as it could be. The SvnChangeLogConsumer expects the author to be in a very specific format. Here is a snippet of the author regular expression. (\\(\\S+\\s+\\S+\\)|\\S+) This fits two basic formats for author: (firstname lastname) or username But what happens if the first or last name contains spaces? The entire header does not match and the changelog returns nothing. Further, Subversion does not guarantee the format of the author. Hooks can be added to subversion to modify the author again resulting in an empty changelog. The change log consumer should simply consume whatever is in the author section of the output to keep these kind of mismatches from happening. This allows for a header match to be found and the scm:changelog command to produce reasonable output. So I recommend that we change the parsing of the author to pull in anything. --- Todd Thiessen > -Original Message- > From: Mark Struberg [mailto:[email protected]] > Sent: Tuesday, January 13, 2009 5:49 PM > To: Maven Users List > Subject: RE: SCM plugin project > > Hi Todd! > > Is it a) an enhancement to the maven-scm-plugin itself? > Or b) does it dig deeper into maven-scm and we have to change > the scm-API too? > > For both options you'd probably file a Jira [1] which > describes the motivation and the changes you like to do > first. Then you may attach a patch or provide your changes > via a online repo. > I personally would prefer git ;) > > For option b) we should definitely switch over to the scm-dev > list again. > > LieGrue, > strub > > [1] http://jira.codehaus.org/browse/SCM > >
RE: SCM plugin project
I haven't gotten a response from an SCM plugin development person. Perhaps someone on the Maven list could guide me in the right direction. I would like contribute a fix to the SCM plugin. I am trying to build the project but I have questions/issues. Who can I talk to regarding these? Thanks all. And sorry for creating some noise on the Maven list. --- Todd Thiessen > -Original Message- > From: Thiessen, Todd (BVW:9T16) > Sent: Friday, January 09, 2009 5:13 PM > To: '[email protected]' > Cc: 'Maven Users List' > Subject: SCM plugin project > > I have downloaded the source for this project have and have a > number questions/concerns. > > Most of the code seems be under the scm directory. ie: > > http://svn.apache.org/repos/asf/maven/scm > > There is a POM at the highest level, with an artifact ID of > maven-scm, which indicates many sub-directories as sub-modules. > > However, there is one sub-module that confuses me: > maven-scm-plugin. You would normally expect the parent for > this pom to be the parent in the higher directory. > > However, this isn't the case. Its parent is maven-plugins > which is a different artifact altogether. This really seems > to make building and versioning of the entire project confusing. > > Do you release the maven-scm project or the maven-scm-plugin > project? I naturally expected to release the maven-scm > project but the maven-scm-plugin stands out in that it > doesn't define maven-scm as the parent and it also includes > all the maven-scm submodule projects as dependancies by > explicitly specifying their version. How are the version > numbers of all these dependencies incremented when a new > version of the plugin is released? > > --- > Todd Thiessen >
RE: SCM plugin project
Thanks for the response Mark. Are you considered an SCM committer/developer? I have a fix/enchancement I would like to submit and am seeking some guidance. If we should take this strictly to the scm-dev list that is fine too. I don't want to create unnessary noice on the Maven list although there may be others would are looking to do this too. --- Todd Thiessen > -Original Message- > From: Mark Struberg [mailto:[email protected]] > Sent: Tuesday, January 13, 2009 3:06 PM > To: [email protected]; Maven Users List > Subject: RE: SCM plugin project > > Hi Todd! > > maven-scm defines a SPI + a few plugins for various SCMs. > But although the name of the project is maven-scm it is not > only intended to be used with maven only. There are other > projecs (e.g. continuum) which use maven-scm for accessing > SCMs without maven. > > The maven-scm-plugin on the other side is really a > maven-plugin! And maven-scm-plugin uses maven-scm to access > the SCM you are using. > > That's the reason why maven-scm-plugin uses the common parent > pom used for all maven-plugins (see maven-plugin-plugin for > more details) and maven-scm doesn't. > > > LieGrue, > strub > > --- Todd Thiessen schrieb am Di, 13.1.2009: > > > Von: Todd Thiessen > > Betreff: RE: SCM plugin project > > An: [email protected] > > CC: "Maven Users List" > > Datum: Dienstag, 13. Januar 2009, 18:47 I haven't gotten a response > > from an SCM plugin development person. > > Perhaps someone on the Maven list could guide me in the right > > direction. > > I would like contribute a fix to the SCM plugin. I am > trying to build > > the project but I have questions/issues. Who can I talk to > regarding > > these? > > > > Thanks all. And sorry for creating some noise on the Maven list. > > > > --- > > Todd Thiessen > > > > > > > -Original Message- > > > From: Thiessen, Todd (BVW:9T16) > > > Sent: Friday, January 09, 2009 5:13 PM > > > To: '[email protected]' > > > Cc: 'Maven Users List' > > > Subject: SCM plugin project > > > > > > I have downloaded the source for this project have and > > have a > > > number questions/concerns. > > > > > > Most of the code seems be under the scm directory. ie: > > > > > > http://svn.apache.org/repos/asf/maven/scm > > > > > > There is a POM at the highest level, with an artifact > > ID of > > > maven-scm, which indicates many sub-directories as > > sub-modules. > > > > > > However, there is one sub-module that confuses me: > > > maven-scm-plugin. You would normally expect the parent > > for > > > this pom to be the parent in the higher directory. > > > > > > However, this isn't the case. Its parent is > > maven-plugins > > > which is a different artifact altogether. This really > > seems > > > to make building and versioning of the entire project > > confusing. > > > > > > Do you release the maven-scm project or the > > maven-scm-plugin > > > project? I naturally expected to release the maven-scm > > > > > project but the maven-scm-plugin stands out in that it > > > > > doesn't define maven-scm as the parent and it also > > includes > > > all the maven-scm submodule projects as dependancies > > by > > > explicitly specifying their version. How are the > > version > > > numbers of all these dependencies incremented when a > > new > > > version of the plugin is released? > > > > > > --- > > > Todd Thiessen > > > > > > > > - > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: > > [email protected] > > > > > - > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
