Oops, I meant to reply the other day.
This is good.
--Mark
On Tue, 12 Feb 2008, Nathan Bush wrote:
> Date: Tue, 12 Feb 2008 17:05:47 -0800
> From: Nathan Bush
> To: Mark J. Nelson
> Cc: scm-migration-dev at opensolaris.org
> Subject: Re: [scm-migration-dev] Please review #
Nathan Bush wrote:
> Mark J. Nelson wrote:
>> It's good enough, or if you felt like polishing a little bit more, you
>> could also typset OLDDIR/NEWDIR variables in build_old_new, because each
>> called function repeatedly uses the same constructs
>>
>> $WDIR/raw_files/old/$PDIR
>> $WDIR/
Mark J. Nelson wrote:
>
Please review:
421 webrev: clean up global vars vs. function params
http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
>>>
>>> It seems like you should either remove all of the typeset
>>> declarations from build_old_new, or from each of the
>>> bui
>>> Please review:
>>> 421 webrev: clean up global vars vs. function params
>>> http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
>>
>> It seems like you should either remove all of the typeset declarations from
>> build_old_new, or from each of the build_old_new_blah functions that it
Mark J. Nelson wrote:
>
>> Please review:
>> 421 webrev: clean up global vars vs. function params
>> http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
>
> It seems like you should either remove all of the typeset declarations
> from build_old_new, or from each of the build_old_new_blah
> Please review:
> 421 webrev: clean up global vars vs. function params
> http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
It seems like you should either remove all of the typeset declarations
from build_old_new, or from each of the build_old_new_blah functions that
it calls. But yo
Please review:
421 webrev: clean up global vars vs. function params
http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
Thanks,
--Nathan
