[scm-migration-dev] Please review # 423

2008-03-05 Thread Richard Lowe
Nathan Bush writes: > Richard Lowe wrote: >> Nathan Bush writes: >> >>> Hi, >>> >>> I need a code review for: >>> 423 questionable format for rename-only changes in hg webrev >>> >>> The change to webrev is: >>> http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/ >>> >> >> The only thing

[scm-migration-dev] Please review # 423

2008-03-04 Thread Richard Lowe
Nathan Bush writes: > Hi, > > I need a code review for: > 423 questionable format for rename-only changes in hg webrev > > The change to webrev is: > http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/ > The only thing that jumps out is a nit I don't really mind either way: 2584: -n is

[scm-migration-dev] Please review # 423

2008-03-04 Thread Nathan Bush
Richard Lowe wrote: > Nathan Bush writes: > >> Hi, >> >> I need a code review for: >> 423 questionable format for rename-only changes in hg webrev >> >> The change to webrev is: >> http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/ >> > > The only thing that jumps out is a nit I don't re

[scm-migration-dev] Please review # 423

2008-03-04 Thread Nathan Bush
Hi, I need a code review for: 423 questionable format for rename-only changes in hg webrev The change to webrev is: http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/ Here is sample run against a test environment. This shows an example of each possible type of file change in the index: