John Beck writes:
> James> http://cr.opensolaris.org/~carlsonj/webrev-440/
>
> * sdrop.sh
>
> Typo on line 70: s/%/$/ (or if it's not a typo, then you need to
> educate me on that feature :-)
Good catch. I don't think I was aiming for .BAT file scripting, so
it's probably just the 4 and 5 k
Richard Lowe writes:
> which_scm.1:26
>
> 'which_scm', not 'webrev'
Oops; yes. Will fix.
> There's a few places (webrev, nightly, ws, xref) which don't
> explicitly deal with the case where which_scm knows which SCM is in
> use, but the tool doesn't really know what to do with them.
OK. I'l
James Carlson writes:
> I've (finally!) finished testing of my fix for this issue:
>
> 440 Need exactly one implementation of scm sniffing.
>
> This was originally a code review comment from Bill Sommerfeld. The
> webrev for this change is here:
>
> http://cr.opensolaris.org/~carlsonj/webrev
Richard Lowe writes:
> James Carlson writes:
> > - Manual testing of each of the modified binaries (xref, which_scm,
> > sdrop, nightly, webrev, ws, xref) in hg and Teamware workspaces.
>
> Subversion? (I know, that's a pain, since that means building
> Companion somehow)
Ahem. I forgot
James Carlson writes:
> I've (finally!) finished testing of my fix for this issue:
>
> 440 Need exactly one implementation of scm sniffing.
>
> This was originally a code review comment from Bill Sommerfeld. The
> webrev for this change is here:
>
> http://cr.opensolaris.org/~carlsonj/webrev
I've (finally!) finished testing of my fix for this issue:
440 Need exactly one implementation of scm sniffing.
This was originally a code review comment from Bill Sommerfeld. The
webrev for this change is here:
http://cr.opensolaris.org/~carlsonj/webrev-440/
Testing consisted of:
- Ful
James> http://cr.opensolaris.org/~carlsonj/webrev-440/
* sdrop.sh
Typo on line 70: s/%/$/ (or if it's not a typo, then you need to
educate me on that feature :-)
That's all I found to complain about, though I'm very early in the
learning curve for all this, so don't consider my review to be
