> "Jim" == James Carlson writes:
Jim> I looked at $SRC/cmd/nsadmin/system, and we really haven't changed
Jim> this file in decades, so it's time to ditch this logic.
That sounds fine to me. I think current practice is to reserve
/etc/system for the system administrator (i.e., if a develop
James Carlson writes:
> New webrev to follow ...
All updated per review comments and automated tests in progress. I'll
consider those review comments to be "final" unless someone squawks
otherwise.
http://cr.opensolaris.org/~carlsonj/webrev-268/
--
James Carlson, Solaris Networking
Mike Kupfer writes:
> Overall it looks good. A couple things caught my eye:
>
> * common_files/i.devlinktab_sparc
[...]
> but you've taken out the rm of /tmp/d.$$. Should that "cp" be "mv"?
Good catch. I'll just put the "rm" back.
> * common_files/i.etcsystem:
>
> Having i.etcsystem kno
Overall it looks good. A couple things caught my eye:
* common_files/i.devlinktab_sparc
There's
139 cp /tmp/d.$$ $dest
but you've taken out the rm of /tmp/d.$$. Should that "cp" be "mv"?
* common_files/i.etcsystem:
Having i.etcsystem know /etc/system's most recent SCC
Mike Kupfer writes:
> I'll take a look at this.
OK; thanks. Now that I'm back, I'll be regenerating with the SCCS
#ident lines put back in place this morning. I'll install that as
webrev-268-2 when done.
--
James Carlson, Solaris Networking
Sun Microsystems / 35 Network Drive
I'll take a look at this.
mike
Richard Lowe writes:
> Mike Kupfer writes:
>
> >> "Jim" == James Carlson writes:
> >
> > Jim> let me know if there's an RTI-like process here (or if I should
> > Jim> just push when ready).
> >
> > No RTI process. Code review by one reviewer (or more if appropriate),
> > then push.
>
> You
> "Jim" == James Carlson writes:
Rich> You'll need to affiliate with the project via the webapp before we
Rich> can add you as having write access though.
Rich> (should be a link on the project page, I think).
Jim> I think there would be if I weren't listed as an editor/leader.
Ah, right.
Mike Kupfer writes:
>> "Jim" == James Carlson writes:
>
> Jim> let me know if there's an RTI-like process here (or if I should
> Jim> just push when ready).
>
> No RTI process. Code review by one reviewer (or more if appropriate),
> then push.
You'll need to affiliate with the project via
Here's my completed and tested fix for #268:
http://cr.opensolaris.org/~carlsonj/webrev-268/
Please send me any comments you might have on this and let me know if
there's an RTI-like process here (or if I should just push when
ready).
--
James Carlson, Solaris Networking
Sun Mic
> "Jim" == James Carlson writes:
Jim> let me know if there's an RTI-like process here (or if I should
Jim> just push when ready).
No RTI process. Code review by one reviewer (or more if appropriate),
then push.
mike
11 matches
Mail list logo
