Re: [Scons-dev] [scons-dev] fix for 2903 breaks LIBPATH.py test..

2013-10-27 Thread alexandre . feblot
Yes, that was my initial conclusion. This commit changed: ShLibAction = SCons.Defaults.ShLinkAction(target, source, envlink) to: def VersionedSharedLibrary(target = None, source= None, env=None): ... result = SCons.Defaults.ShLinkAction(target, source, envlink) ... return result

Re: [Scons-dev] [scons-dev] fix for 2903 breaks LIBPATH.py test..

2013-10-27 Thread Gary Oberbrunner
I just pushed a fix which I think is now correct. Alexandre's original fix was the right way to do it, because we do want to depend on all the link args. But the varlist code itself was broken, and wasn't ignoring $(...$) parts of variables, which broke the LINKPATH test. I fixed the varlist

Re: [Scons-dev] [scons-dev] fix for 2903 breaks LIBPATH.py test..

2013-10-26 Thread Gary Oberbrunner
So this is a little more interesting than I'd thought. I can fix the current issue (spurious rebuilds when LIBPATH changes) by using LIBS in the varlist rather than SHLINKCOM, which initially makes sense. But as I added a test for this, along the way thought I'd make sure that changing other

Re: [Scons-dev] [scons-dev] fix for 2903 breaks LIBPATH.py test..

2013-10-25 Thread Gary Oberbrunner
[this was sent to the old obsolete SCons dev list, btw. Forwarding to the new one.] On Thu, Oct 24, 2013 at 11:22 PM, William Deegan b...@baddogconsulting.comwrote: Gary, I see this merge: https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff I did a hg