Re: [Scons-dev] Likely bug - installing side effect files

2014-11-03 Thread Ben Golding
It seems one possible fix for this bug could be a warning/error if the user tries to Install() a side-effect file, and expanding/clarifying the docs for SideEffect(). Also, if Install() is permitted with a warning, the current behaviour (silently ignoring the file) must be fixed. A few other

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-03 Thread Dirk Bächle
Hi Ben, On 03.11.2014 11:48, Ben Golding wrote: It seems one possible fix for this bug could be a warning/error if the user tries to Install() a side-effect file, and expanding/clarifying the docs for SideEffect(). Also, if Install() is permitted with a warning, the current behaviour

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-03 Thread Gary Oberbrunner
On Mon, Nov 3, 2014 at 8:44 AM, Ben Golding ben.gold...@synopsys.com wrote: Nevertheless, what effect does this marking of the side effect file actually have during the build? What can I usefully do with the object returned by SideEffect()? Does it have an effect during the parallel build?

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-03 Thread Dirk Bächle
On 03.11.2014 14:44, Ben Golding wrote: Hi Dirk, Thanks for the clarification. Nevertheless, what effect does this marking of the side effect file actually have during the build? What can I usefully do with the object returned by SideEffect()? Not very much, I'm afraid...and why would you

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-03 Thread Kenny, Jason L
...@scons.org] On Behalf Of Dirk Bächle Sent: Monday, November 3, 2014 8:38 AM To: scons-dev@scons.org Subject: Re: [Scons-dev] Likely bug - installing side effect files On 03.11.2014 14:44, Ben Golding wrote: Hi Dirk, Thanks for the clarification. Nevertheless, what effect does this marking

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-02 Thread Dirk Bächle
Gary, On 01.11.2014 12:03, Gary Oberbrunner wrote: SideEffect may be the root cause of the problem, but Install should not behave this way, IMHO. If you pass some nodes to Install, it should either install them or fail the build with an error (don't know how to build... or similar). It

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-02 Thread Bill Deegan
Well said Dirk! +1 On Sun, Nov 2, 2014 at 4:25 AM, Dirk Bächle tshor...@gmx.de wrote: Gary, On 01.11.2014 12:03, Gary Oberbrunner wrote: SideEffect may be the root cause of the problem, but Install should not behave this way, IMHO. If you pass some nodes to Install, it should either

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-02 Thread William Blevins
I agree with Dirk here. If multiple actions can have the same side-effect files, then Install cannot have a correct behavior. The behavior will always be ambiguous. If the files are always unique to the build actions, then they are not side-effects at all and should be correctly added to an

Re: [Scons-dev] Likely bug - installing side effect files

2014-11-01 Thread Bill Deegan
I'd almost say we should through an exception when a sideffect file is specified as a source (for any builder) -Bill On Sat, Nov 1, 2014 at 4:03 AM, Gary Oberbrunner ga...@oberbrunner.com wrote: SideEffect may be the root cause of the problem, but Install should not behave this way, IMHO. If

Re: [Scons-dev] Likely bug - installing side effect files

2014-10-31 Thread Dirk Bächle
Hi there, On 30.10.2014 16:01, Ben Golding wrote: Thanks Gary. http://scons.tigris.org/issues/show_bug.cgi?id=2982 I started to add some additional trace to Taskmaster.py, and compare the logs from sequential vs. parallel builds. The bug seems to relate to how the node states are used for

Re: [Scons-dev] Likely bug - installing side effect files

2014-10-31 Thread Gary Oberbrunner
On Fri, Oct 31, 2014 at 2:55 PM, Dirk Bächle tshor...@gmx.de wrote: I don't think there is anything to fix here...and it's no bug for me either. Please read the man page for the definition of a SideEffect, and when it should be used. My understanding is, that in your case the conditions do not

Re: [Scons-dev] Likely bug - installing side effect files

2014-10-31 Thread Bill Deegan
SideEffect() by definition (to me at least) should be informing SCons that a file is produced, but it is not important. Allowing SCons to be aware of it. It seems like using that file as an input in any part of your build would violate such an idea. So I think I'm agreeing with Dirk on this one.

Re: [Scons-dev] Likely bug - installing side effect files

2014-10-31 Thread William Blevins
Team, Not to be contrary here, but I think personal opinions should be postponed until we determine if the definition of SideEffect per the SCons User Guide matches the actual behavior. http://www.scons.org/doc/production/HTML/scons-user.html SideEffect(side_effect, target) ,

Re: [Scons-dev] Likely bug - installing side effect files

2014-10-30 Thread Gary Oberbrunner
On Thu, Oct 30, 2014 at 9:34 AM, Ben Golding ben.gold...@synopsys.com wrote: tgt = Command('tgt', 'src', 'touch $TARGET sf0 sf1') sf = SideEffect([ 'sf0', 'sf1' ], tgt) Install('dir', tgt + sf) I can reproduce this bug. Please file a ticket! The dependency tree looks OK, and I can't

Re: [Scons-dev] Likely bug - installing side effect files

2014-10-30 Thread Ben Golding
-Original Message- From: Scons-dev [mailto:scons-dev-boun...@scons.org] On Behalf Of Gary Oberbrunner Sent: 30 October 2014 14:30 To: SCons developer list Subject: Re: [Scons-dev] Likely bug - installing side effect files On Thu, Oct 30, 2014 at 9:34 AM, Ben Golding ben.gold...@synopsys.com wrote