Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-30 Thread Stefan Berger
On 11/28/2015 07:44 AM, Kevin O'Connor wrote: On Tue, Nov 24, 2015 at 12:40:32PM -0500, Stefan Berger wrote: On 11/23/2015 11:40 PM, Kevin O'Connor wrote: On Mon, Nov 23, 2015 at 11:17:35AM -0500, Kevin O'Connor wrote: However, it seems like just undoing my patch 4 makes the most sense. I'll

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-11-30 Thread edward wandasiewicz
Booting with 1 x Phillips USB and 1 x Ventura Ultra attached to the Pixel 2015 I've attached the cbmem -c from Pixel Samus, after a cold boot into Arch Linux and also following a reboot immediately after. After a reboot, following a boot, the Philips USB now only appears just the once, and not

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 03:22:38PM +, edward wandasiewicz wrote: > Booting with 1 x Phillips USB and 1 x Ventura Ultra attached to the Pixel 2015 > > I've attached the cbmem -c from Pixel Samus, after a cold boot into > Arch Linux and also following a reboot immediately after. > > After a

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Kevin O'Connor
On Sun, Nov 29, 2015 at 11:49:43PM -0500, Stefan Berger wrote: > From: Stefan Berger > > This patch adds an new menu entry to the main menu. This menu item enables > the user to enter a TPM control menu which allows control of those aspects > of the TPM's state that

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Peter Stuge
Kevin O'Connor wrote: > > > +static u32 > > > +read_stclear_flags(char *buf, int buf_len) > > > +{ > > .. > > > +if (rc || returnCode) > > > +goto err_exit; > > .. > > > +err_exit: > > > +dprintf(DEBUG_tcg, "TCGBIOS: TPM malfunctioning (line %d).\n", > > > __LINE__); > > > > I

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Stefan Berger
"Kevin O'Connor" wrote on 11/30/2015 10:05:22 AM: > From: "Kevin O'Connor" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: seabios@seabios.org, Stefan Berger > Date: 11/30/2015 10:05 AM > Subject: Re: [PATCH 3/3] tpm: Add a menu

[SeaBIOS] [PATCH v2 1/3] tpm: Remove check for working TPM from TPM interrupt handler

2015-11-30 Thread Stefan Berger
From: Stefan Berger Remove the check for a working TPM from the TPM interrupt handler. This then allows the individual API calls to return information even if the TPM was not working correctly. Some API calls will still run into the check. Signed-off-by: Stefan

Re: [SeaBIOS] Qemu-kvm VM halt at allocate VGA stack when continuously reset VM

2015-11-30 Thread Kevin O'Connor
On Sat, Nov 28, 2015 at 07:12:47AM +, Xulei (Stone) wrote: > Hi, > Recently, i use a script to continuously reset a VM and > i found my VM frequently halts at "Attempting to allocate > VGA stack via pmm call". After analyzing, i think it may > be a problem of SeaBIOS. > > From the

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 10:23:28AM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 11/30/2015 10:05:22 AM: > > Are the above definitions part of the standard, or internal to the > > implementation? If the latter, they should go into tcgbios.[ch] > > These are

[SeaBIOS] [PATCH v2 2/3] tpm: Check length parameter of the array

2015-11-30 Thread Stefan Berger
From: Stefan Berger Check the length parameter that indicates the length of the array for whether it has a minimum value of 0x200. Signed-off-by: Stefan Berger --- src/tcgbios.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-11-30 Thread edward wandasiewicz
On 30 Nov 2015 5:35 p.m., "Kevin O'Connor" wrote: > > On Mon, Nov 30, 2015 at 04:47:29PM +, edward wandasiewicz wrote: > > I started over, as I forgot which device was in which port. > > > > It seem's like a race condition, as I managed to get a USB device > > detected

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 04:47:29PM +, edward wandasiewicz wrote: > I started over, as I forgot which device was in which port. > > It seem's like a race condition, as I managed to get a USB device > detected twice with JohnLewis RW_LEGACY as well now, although it > doesn't happen very

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

2015-11-30 Thread Wim Vervoorn
Hello, I noticed that a lot of work is going on for the TPM support in SeaBIOS. All of this work is TPM 1.2 based. I was wondering if there are any plans to support TPM 2.0 in the future. Best regards, Wim Vervoorn -Original Message- From: SeaBIOS [mailto:seabios-boun...@seabios.org]

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 06:02:45AM +0100, Peter Stuge wrote: > Stefan Berger wrote: > > +++ b/src/tcgbios.c > > +static u32 > > +read_stclear_flags(char *buf, int buf_len) > > +{ > .. > > +if (rc || returnCode) > > +goto err_exit; > .. > > +err_exit: > > +dprintf(DEBUG_tcg,