Re: [SeaBIOS] [PATCH] optionrom: disallow int19 redirect for pnp roms.

2018-11-28 Thread Laszlo Ersek
On 11/28/18 19:33, Kevin O'Connor wrote: > On Wed, Nov 28, 2018 at 06:50:50PM +0100, Laszlo Ersek wrote: >> On 11/28/18 16:51, Kevin O'Connor wrote: >>> If we could do it safely that would be fine. My fear is that it >>> introduces a regression. A new config option would be okay, but it >>> doesn

Re: [SeaBIOS] [PATCH] SMBIOS: Add SMBIOS Type 6 Memory Module Information

2018-11-28 Thread Liran Alon
> On 28 Nov 2018, at 22:17, Laszlo Ersek wrote: > > On 11/28/18 16:54, Liran Alon wrote: >> From: Arbel Moshe >> >> Add support for obsolete SMBIOS Type 6 which describes the speed, type, >> size and error status of each system memory module. >> >> This is required by some guests to boot suc

Re: [SeaBIOS] [PATCH] SMBIOS: Add SMBIOS Type 6 Memory Module Information

2018-11-28 Thread Laszlo Ersek
On 11/28/18 16:54, Liran Alon wrote: > From: Arbel Moshe > > Add support for obsolete SMBIOS Type 6 which describes the speed, type, > size and error status of each system memory module. > > This is required by some guests to boot successfully. > > Such an example is Cisco NGFW appliance which

Re: [SeaBIOS] [PATCH] optionrom: disallow int19 redirect for pnp roms.

2018-11-28 Thread Kevin O'Connor
On Wed, Nov 28, 2018 at 06:50:50PM +0100, Laszlo Ersek wrote: > On 11/28/18 16:51, Kevin O'Connor wrote: > > If we could do it safely that would be fine. My fear is that it > > introduces a regression. A new config option would be okay, but it > > doesn't sound like that will help, as it seems th

Re: [SeaBIOS] [PATCH] optionrom: disallow int19 redirect for pnp roms.

2018-11-28 Thread Laszlo Ersek
On 11/28/18 16:51, Kevin O'Connor wrote: > On Wed, Nov 28, 2018 at 12:14:07PM +0100, Laszlo Ersek wrote: >> Right. Before I raised my short question about *not* short-circuiting >> get_pnp_rom() with "isvga" set, I had read through the BZ, and I was >> *very* tempted to say "this is what's wrong wi

[SeaBIOS] [PATCH] Revert "mptable: Don't describe pci-to-pci bridges."

2018-11-28 Thread Liran Alon
From: Arbel Moshe This reverts commit 3c3a3fa6522f ("mptable: Don't describe pci-to-pci bridges.”) The reverted commit removed the description of non-root PCI busses from the MPTable in claim they are not necessary. However, it seems that some guests rely on this information in order to correcl

[SeaBIOS] [PATCH] SMBIOS: Add SMBIOS Type 6 Memory Module Information

2018-11-28 Thread Liran Alon
From: Arbel Moshe Add support for obsolete SMBIOS Type 6 which describes the speed, type, size and error status of each system memory module. This is required by some guests to boot successfully. Such an example is Cisco NGFW appliance which has a script which runs every boot that parses this S

[SeaBIOS] [PATCH] mpt-scsi: Align MPT request to 8 bytes

2018-11-28 Thread Liran Alon
From: Nikita Leshchenko When mpt-scsi receives a SCSI message, it wraps it in a MPT request message and writes it's address to an IO port to be added to the request queue. This MPT request is allocated on the stack. Previous to this commit, the request is aligned to 4 bytes. However, VirtualBox

Re: [SeaBIOS] [PATCH] optionrom: disallow int19 redirect for pnp roms.

2018-11-28 Thread Kevin O'Connor
On Wed, Nov 28, 2018 at 12:14:07PM +0100, Laszlo Ersek wrote: > Right. Before I raised my short question about *not* short-circuiting > get_pnp_rom() with "isvga" set, I had read through the BZ, and I was > *very* tempted to say "this is what's wrong with our industry". :) The > oprom in question i

Re: [SeaBIOS] [PATCH] optionrom: disallow int19 redirect for pnp roms.

2018-11-28 Thread Kevin O'Connor
On Wed, Nov 28, 2018 at 07:24:21AM +0100, Gerd Hoffmann wrote: > On Tue, Nov 27, 2018 at 09:19:09PM -0500, Kevin O'Connor wrote: > > That is very odd. I'm pretty sure iPXE normally does register itself > > as a BEV - any idea why it's now hooking int19? > > It's not ipxe. Ah, okay. The bugzilla

Re: [SeaBIOS] [PATCH v2] qemu: fast boot when linuxboot optionrom is used

2018-11-28 Thread Kevin O'Connor
On Wed, Nov 28, 2018 at 12:30:42PM +0100, Stefano Garzarella wrote: > On Wed, Nov 28, 2018 at 3:12 AM Kevin O'Connor wrote: > > On Mon, Nov 26, 2018 at 12:39:12PM +0100, Stefano Garzarella wrote: > > > Speed up the boot phase when qemu uses "linuxboot" optionrom > > > (qemu -kernel) and the boot-m

Re: [SeaBIOS] [PATCH v2] qemu: fast boot when linuxboot optionrom is used

2018-11-28 Thread Stefano Garzarella
On Wed, Nov 28, 2018 at 3:12 AM Kevin O'Connor wrote: > > On Mon, Nov 26, 2018 at 12:39:12PM +0100, Stefano Garzarella wrote: > > Speed up the boot phase when qemu uses "linuxboot" optionrom > > (qemu -kernel) and the boot-menu is not required. > > Under these conditions we can skip the setup of d

Re: [SeaBIOS] [PATCH] optionrom: disallow int19 redirect for pnp roms.

2018-11-28 Thread Laszlo Ersek
On 11/28/18 07:24, Gerd Hoffmann wrote: > On Tue, Nov 27, 2018 at 09:19:09PM -0500, Kevin O'Connor wrote: >> On Tue, Nov 27, 2018 at 01:10:38PM +0100, Gerd Hoffmann wrote: >>> Check whenever pnp roms attempt to redirect int19, and in case it does >>> log a message and undo the redirect. >>> >>> A p