[SeaBIOS] Re: [PATCH 00/19] Support SMBIOS 3.0 entry points

On Fri, Dec 11, 2020 at 10:46:00AM -0500, Kevin O'Connor wrote: > On Thu, Dec 10, 2020 at 04:26:21PM -0500, Eduardo Habkost wrote: > > This series implements support for SMBIOS 3.0 entry points in > > > > SeaBIOS. > > > > > > The main advantage of SMBI

[SeaBIOS] [PATCH 19/19] smbios: Support SMBIOS 3.0 entry point at smbios_romfile_setup()

Support SMBIOS 3.0 entry points if exposed by QEMU in fw_cfg. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index 5ff1b0ed..1c09a785 100644

[SeaBIOS] [PATCH 17/19] smbios: copy_smbios_30() function

(), and smbios_minor_version() helpers to use the SMBIOS 3.0 entry point if available. Signed-off-by: Eduardo Habkost --- src/std/smbios.h| 13 + src/fw/biostables.c | 36 ++-- 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/src/std/smbios.h

[SeaBIOS] [PATCH 18/19] smbios: Support SMBIOS 3.0 entry point at copy_table()

This will make coreboot code (scan_tables()) and xen code (xen_biostable_setup()) copy SMBIOS 3.0 entry points if found. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index b2c84a12..5ff1b0ed

[SeaBIOS] [PATCH 16/19] smbios: Make smbios_build_tables() ready for 64-bit tables

Make smbios_build_tables() get u64 address and u32 length arguments, making it usable for SMBIOS 3.0. Adapt smbios_21_setup_entry_point() to use intermediate variables when calling smbios_build_tables(). Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 16 +--- 1 file

[SeaBIOS] [PATCH 15/19] smbios: Make some smbios_build_tables() arguments optional

Make max_structure_size and number_of_structures optional, as we don't have those fields in SMBIOS 3.0 entry points. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index

[SeaBIOS] [PATCH 14/19] smbios: smbios_21_setup_entry_point() function

Extract the code specific for building the SMBIOS 2.1 entry point from smbios_romfile_setup() to a new smbios_21_setup_entry_point() function. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff

[SeaBIOS] [PATCH 13/19] smbios: Make smbios_build_tables() more generic

Instead of taking a SMBIOS 2.1 entry point as argument, make smbios_build_tables() take pointers to the fields it actually changes. This will allow us to reuse the function for SMBIOS 3.0 later. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 32 +++- 1

[SeaBIOS] [PATCH 12/19] smbios: Extract SMBIOS table building code to separate function

commits. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 54 - 1 file changed, 34 insertions(+), 20 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index 11eaeaec..5eeceb52 100644 --- a/src/fw/biostables.c +++ b/src/fw

[SeaBIOS] [PATCH 11/19] smbios: Use smbios_next() at smbios_romfile_setup()

off-by: Eduardo Habkost --- src/fw/biostables.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index 47463be9..11eaeaec 100644 --- a/src/fw/biostables.c +++ b/src/fw/biostables.c @@ -477,16 +477,17 @@ smbios_romfile_setup(v

[SeaBIOS] [PATCH 10/19] smbios: Make SMBios21Addr variable static

The variable is now only used inside biostables.c, there's no need to make it global. Signed-off-by: Eduardo Habkost --- src/util.h | 1 - src/fw/biostables.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util.h b/src/util.h index 2e151752..aff8e888 100644

[SeaBIOS] [PATCH 09/19] csm: Don't check SMBios21Addr before calling copy_smbios_21()

copy_smbios_21() already checks if SMBios21Addr is NULL, there's no need to check it before calling the function. Signed-off-by: Eduardo Habkost --- src/fw/csm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fw/csm.c b/src/fw/csm.c index 74069028..bc14a925 100644

[SeaBIOS] [PATCH 08/19] tpm: Use smbios_get_tables()

Instead of using the SMBios21Addr global variable, use the smbios_get_tables() helper. This doesn't change any behavior yet, but it will be useful when we start supporting SMBIOS 3.0 entry points. Signed-off-by: Eduardo Habkost --- src/tcgbios.c | 10 +- 1 file changed, 5 insertions

[SeaBIOS] [PATCH 07/19] smbios: smbios_major_version()/smbios_minor_version() helpers

They new helpers will be useful when we start supporting SMBIOS 3.0 entry points. Use the new helpers at display_uuid(). Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/fw/biostables.c b

[SeaBIOS] [PATCH 06/19] smbios: Use smbios_get_tables()/smbios_next() at display_uuid()

Make the code more generic, and not specific for SMBIOS 2.1 entry points. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index 1adc694c..d22ab643 100644 --- a/src/fw

[SeaBIOS] [PATCH 04/19] smbios: Generic smbios_next() function

Extract generic code from smbios_21_next(), so it can be reused for SMBIOS 3.0 support. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index 8e53ae2e..3c30331e

[SeaBIOS] [PATCH 05/19] smbios: smbios_get_tables() function

The new function will be useful for code that just needs the address and length of SMBIOS tables. Signed-off-by: Eduardo Habkost --- src/util.h | 1 + src/fw/biostables.c | 9 + 2 files changed, 10 insertions(+) diff --git a/src/util.h b/src/util.h index f761271c..2e151752

[SeaBIOS] [PATCH 03/19] smbios: Rename code specific for SMBIOS 2.1 entry points

Rename copy_smbios(), smbios_next(), SMBIOS_SIGNATURE, smbios_entry_point, and SMBiosAddr, to indicate they refer to SMBIOS 2.1 entry points. Signed-off-by: Eduardo Habkost --- src/std/smbios.h| 4 ++-- src/util.h | 4 ++-- src/fw/biostables.c | 36

[SeaBIOS] [PATCH 02/19] util.h: Delete unused get_smbios_entry_point() prototype

The get_smbios_entry_point() function doesn't exist, delete unused prototype. Signed-off-by: Eduardo Habkost --- src/util.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util.h b/src/util.h index 0de35229..652ca6b1 100644 --- a/src/util.h +++ b/src/util.h @@ -88,7 +88,6 @@ u32

[SeaBIOS] [PATCH 01/19] biostables: copy_fseg_table() function

Replace the common malloc_fseg() + memcpy() code pattern with a helper function. Signed-off-by: Eduardo Habkost --- src/fw/biostables.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/src/fw/biostables.c b/src/fw/biostables.c index

[SeaBIOS] [PATCH 00/19] Support SMBIOS 3.0 entry points

This series implements support for SMBIOS 3.0 entry points in SeaBIOS. The main advantage of SMBIOS 3.0 entry points is the higher limit for total table size. The SMBIOS 2.1 64435 bytes limit can be easily hit in QEMU if creating virtual machines with more than 720 VCPUs. Eduardo

[SeaBIOS] Re: [Qemu-devel] Regression with floppy drive controller

On Tue, Aug 20, 2019 at 06:21:28PM +0200, Philippe Mathieu-Daudé wrote: > Cc'ing Eduardo, Paolo. > > On 8/20/19 3:38 PM, Philippe Mathieu-Daudé wrote: > > On 8/20/19 3:12 PM, John Snow wrote: > >> On 8/20/19 6:25 AM, Philippe Mathieu-Daudé wrote: > >>> [cross posting QEMU & SeaBIOS] > >>> > >>>

Re: [SeaBIOS] [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

On Wed, Sep 20, 2017 at 09:52:01AM +, Aleksandr Bezzubikov wrote: > ср, 20 сент. 2017 г. в 10:13, Marcel Apfelbaum <mar...@redhat.com>: > > > On 19/09/2017 23:34, Eduardo Habkost wrote: > > > On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wr

Re: [SeaBIOS] [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wrote: > Introduce a new PCIExpress-to-PCI Bridge device, > which is a hot-pluggable PCI Express device and > supports devices hot-plug with SHPC. > > This device is intended to replace the DMI-to-PCI Bridge. > > Signed-off-by:

Re: [SeaBIOS] [PATCH 6/6] q35: skip q35-acpi-dsdt.aml load if not needed

On Thu, Dec 17, 2015 at 11:40:49AM +0100, Gerd Hoffmann wrote: > Only old machine types which don't use the acpi builder (qemu 1.7 + older) > have to load that file for proper acpi support. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/pc_q35.c | 5 - > 1 file changed,

Re: [SeaBIOS] bug: incorrect uuid in seabios output

sed > >> via > >> qemu -uuid option. An example is reported here: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=1284259 > >> > >> This is due to: > >> > >> commit caad057bb6ce86a9cb71520af395fd0bd04a659f > >> Author

Re: [SeaBIOS] [PATCH for 1.7] pc: disable pci-info

by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

On Wed, Mar 20, 2013 at 02:18:00PM +0800, li guang wrote: 在 2013-01-09三的 01:08 +0100，Andreas Färber写道： Am 18.12.2012 13:41, schrieb Vasilis Liaskovitis: Because dimm layout needs to be configured on machine-boot, all dimm devices need to be specified on startup command line (either

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

-by: Michael S. Tsirkin m...@redhat.com Thanks! Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Eduardo Habkost ehabk...@redhat.com diff --git a/src/acpi-dsdt-cpu-hotplug.dsl b/src/acpi-dsdt-cpu-hotplug.dsl index 0f3e83b..c96ac42 100644 --- a/src/acpi-dsdt-cpu-hotplug.dsl

Re: [SeaBIOS] [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

On Thu, Jul 26, 2012 at 05:55:09PM +0300, Avi Kivity wrote: On 07/26/2012 05:16 PM, Eduardo Habkost wrote: It's possible to replace the atomic read of CountCPUs with the bitmap weight calculation on the loop, but: is it really worth it? Why not? This eliminates one more global

Re: [SeaBIOS] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

On Mon, Jul 23, 2012 at 03:20:14PM +0300, Gleb Natapov wrote: On Fri, Jul 20, 2012 at 02:04:50PM -0300, Eduardo Habkost wrote: Extract Local APIC IDs directly from the CPUs, and instead of check for i CountCPUs, check if the APIC ID was present on boot, when building ACPI tables and the MP

[SeaBIOS] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v3)

Changes v2 - v3: - Report I/O APIC ID = 0 on MP-table, too Changes v1 - v2: - Patch 1/2: cosmetic whitespace change - Patch 2/2: use size suffixes on asm instructions on smp.c - New patch descriptions Eduardo Habkost (2): report real I/O APIC ID (0) on MADT and MP-table (v3) allow CPUs

[SeaBIOS] [SeaBIOS PATCH 1/2] report real I/O APIC ID (0) on MADT and MP-table (v3)

reality. Changes v2 - v3: - Fix MP-table too, not just ACPI MADT table Changes v1 - v2: - Cosmetic: whitespace change (removed extra newline) - New patch description Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- src/acpi.c|2 +- src/config.h |1 + src/mptable.c |2 +- 3

[SeaBIOS] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

be exactly the same. This patch will simply allow QEMU to start setting non-contiguous APIC IDs (that is a requirement for some sockets/cores/threads topology settings). Changes v1 - v2: - Use size suffixes on all asm instructions on smp.c - New patch description Signed-off-by: Eduardo Habkost ehabk

Re: [SeaBIOS] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

On Mon, Jul 23, 2012 at 02:42:27PM +0300, Gleb Natapov wrote: On Fri, Jul 20, 2012 at 01:22:43PM -0300, Eduardo Habkost wrote: On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: When resetting an I/O APIC, its ID

Re: [SeaBIOS] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID (0) on MADT table (v2)

On Mon, Jul 23, 2012 at 03:16:30PM +0300, Gleb Natapov wrote: On Fri, Jul 20, 2012 at 02:04:49PM -0300, Eduardo Habkost wrote: When resetting an I/O APIC, its ID is set to 0, and SeaBIOS doesn't change it, so report it correctly on the MADT table. Some hardware may require the BIOS

Re: [SeaBIOS] [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology APIC ID utility functions

On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Sat, Jul 14

Re: [SeaBIOS] [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

On Mon, Jul 23, 2012 at 07:25:01PM +, Blue Swirl wrote: On Mon, Jul 23, 2012 at 7:09 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Jul 23, 2012 at 06:40:51PM +, Blue Swirl wrote: On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost ehabk...@redhat.com wrote: Hi, While

Re: [SeaBIOS] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the MADT table too. Actually BIOS needs to configure ioapic id to a uniqe value. This does

[SeaBIOS] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID (0) on MADT table (v2)

v1 - v2: - Cosmetic: whitespace change (removed extra newline) - New patch description Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- src/acpi.c |2 +- src/config.h |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/acpi.c b/src/acpi.c index d39cbd9

[SeaBIOS] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

be exactly the same. This patch will simply allow QEMU to start setting non-contiguous APIC IDs (that is a requirement for some sockets/cores/threads topology settings). Changes v1 - v2: - Use size suffixes on all asm instructions on smp.c - New patch description Signed-off-by: Eduardo Habkost ehabk

[SeaBIOS] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v2)

Small changes from the previous series: - Patch 1/2: cosmetic whitespace change - Patch 2/2: use size suffixes on asm instructions on smp.c - New patch descriptions Eduardo Habkost (2): acpi: report real I/O APIC ID (0) on MADT table allow CPUs to have non-contiguous Local APIC IDs (v2

Re: [SeaBIOS] [RFC seabios PATCH] enumerate APIC IDs directly from CPUs

On Thu, Jul 19, 2012 at 11:28:54AM -0300, Eduardo Habkost wrote: On Thu, Jul 19, 2012 at 12:58:46PM +0300, Gleb Natapov wrote: On Tue, Jul 17, 2012 at 06:56:30PM -0300, Eduardo Habkost wrote: This patch is an attempt to fix the non-continguous-APIC-ID problem without

[SeaBIOS] [seabios PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs

. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- src/acpi-dsdt.dsl |4 +++- src/acpi.c|9 + src/mptable.c |2 +- src/smp.c | 17 + src/util.h|1 + 5 files changed, 27 insertions(+), 6 deletions(-) diff --git a/src/acpi

[SeaBIOS] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the MADT table too. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- src/acpi.c |2 +- src/config.h |2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/acpi.c b/src/acpi.c index 55e4607

Re: [SeaBIOS] [seabios PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs

On Thu, Jul 19, 2012 at 09:12:54PM -0400, Kevin O'Connor wrote: On Thu, Jul 19, 2012 at 05:52:42PM -0300, Eduardo Habkost wrote: Extract Local APIC IDs directly from the CPUs, and instead of check for i CountCPUs, check if the APIC ID was present on boot, when building ACPI tables

[SeaBIOS] [RFC seabios PATCH] enumerate APIC IDs directly from CPUs

to know what others think about this approach. I think it is a much simpler approach than relying on some APIC ID = CPU ID translation to make Seabios and QEMU agree. This way, Seabios has absolute freedom to choose the ACPI Processor IDs. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- src

Re: [SeaBIOS] [Qemu-devel] [QEMU RFC PATCH 5/7] pc: write lapic info (apic IDs) to fw_cfg so seabios can use it

On Thu, Jul 12, 2012 at 07:29:02PM +, Blue Swirl wrote: [...] CODING_STYLE requires CamelCase, also below. [...] +struct lapic_info_table *lapic_table = g_malloc0(lapic_info_size);; ;-- +lapic_table-count = max_cpus; +for (i = 0; i max_cpus; i++) { +

Re: [SeaBIOS] [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology APIC ID utility functions

On Thu, Jul 12, 2012 at 07:37:26PM +, Blue Swirl wrote: On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost ehabk...@redhat.com wrote: [...] +#ifndef __QEMU_X86_TOPOLOGY_H__ +#define __QEMU_X86_TOPOLOGY_H__ Please remove the leading and trailing underscores. The name should match

[SeaBIOS] [QEMU PATCH 3/7] kvm: set vcpu_id to APIC ID instead of CPU index

The CPU ID in KVM is supposed to be the APIC ID, so change the KVM_CREATE_VCPU call to match it. It didn't break anything yet because today the APIC ID is assumed to be == the CPU index, but this won't be true in the future. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- kvm-all.c |2

[SeaBIOS] [QEMU RFC PATCH 7/7] generate APIC IDs according to CPU topology

NOTE: this is unfinished, and will break live-migration between older and newer QEMU versions if applied as-is. We need to make the older machine-types keep the existing behavior when generating APIC IDs. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.h |7 +++ 1

[SeaBIOS] [RFC 0/7+1] QEMU APIC ID + topology bug + CPU hotplug

Hi, This is more a call for discussion than a request for comments in the actual code. Our problem today is: - Lots of QEMU and Seabios code have the assumption that Initial APIC ID == CPU index (in other words, that APIC IDs are always contiguous and start at 0); - However, the Initial

[SeaBIOS] [QEMU RFC PATCH 5/7] pc: write lapic info (apic IDs) to fw_cfg so seabios can use it

Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/pc.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/pc.c b/hw/pc.c index 3b8e469..dc95fb8 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -71,6 +71,7 @@ #define FW_CFG_IRQ0_OVERRIDE (FW_CFG_ARCH_LOCAL + 2

[SeaBIOS] [QEMU PATCH 2/7] hw/apic.c: rename bit functions to not conflict with bitops.h

Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/apic.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index 60552df..d322fe3 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -50,7 +50,7 @@ static int ffs_bit

[SeaBIOS] [Seabios RFC PATCH 1/1] get lapic IDs from fw_cfg

This changes: - MADT table generation - SRAT table generation Still missing: - The _MAT method on SSDT Processor entries still return the wrong APIC ID (breaking CPU hotplug) - The MPTable generation code doesn't take the new APIC IDs into account Signed-off-by: Eduardo Habkost ehabk