[SeaBIOS] Re: [PATCH v2] make BUILD_MIN_BIOSTABLE configurable

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 10:52:27AM +0200, Gerd Hoffmann wrote: > BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data > structures -- for example disk drives known to seabios -- must be > stored there, so the space available here limits the number of > devices seabios is able to manage.

[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 09:25:01AM -0300, Heitor Alves de Siqueira wrote: > We should disable NMIs when accessing CMOS ports during state restore, > like it's done during state backup in call32_prep(). > > Signed-off-by: Heitor Alves de Siqueira > --- > src/stacks.c | 2 +- > 1 file changed, 1

[SeaBIOS] Re: [PATCH 0/2] nvme fixes

2021-05-26 Thread Kevin O'Connor
On Wed, May 26, 2021 at 09:49:55AM +0200, Gerd Hoffmann wrote: > Gerd Hoffmann (2): > > nvme: improve namespace allocation > > nvme: drive desc should not include the newline > Thanks. It looks fine to me. -Kevin ___ SeaBIOS mailing list --

[SeaBIOS] Re: [PATCH v2] vgasrc/vgalayout.lds.S: ignore .node.gnu.property (binutils-2.36 support)

2021-05-26 Thread Kevin O'Connor
On Thu, May 20, 2021 at 11:18:48PM +0100, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Modern binutils unconditionally tracks x86_64 ISA levels in intermediate > files in .note.gnu.property. Custom liker script does not handle the > section and complains about it: > > ld

[SeaBIOS] Re: [PATCH] stacks: call check_irqs() in run_thread()

2021-05-26 Thread Kevin O'Connor
# test reply is still on wire. > | > yield(); > # After a few yield()s the keyboard interrupt fires > # and clears the I8042_STR_OBF status bit. If the > # keyboard self test reply arrives before the > # i

[SeaBIOS] Re: [PATCH] fw/coreboot.c: Use coreboot table to find cbfs

2021-05-26 Thread Kevin O'Connor
On Thu, May 20, 2021 at 06:09:55PM +, Peter Stuge wrote: > Arthur Heymans wrote: > > This breaks compatibility with very old coreboot build (build before > > fb5d5b16 "2015-07-14, cbtable: describe boot media"). > > Is that really acceptable in SeaBIOS master at some random time? > > At the

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

2021-05-21 Thread Kevin O'Connor
On Fri, May 21, 2021 at 11:03:00AM +0200, Gerd Hoffmann wrote: > On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote: > > On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote: > > > Hi, > > > > > > This patch series adds sup

[SeaBIOS] Re: [PATCH] stacks: always call check_irqs() in yield()

2021-05-20 Thread Kevin O'Connor
On Thu, May 20, 2021 at 08:53:34PM +0200, Volker Rümelin wrote: > > On Fri, May 14, 2021 at 08:03:20PM +0200, Volker Rümelin wrote: > > > The comment above the yield() function suggests that yield() > > > allows interrupts for a short time. Currently this is only true > > > if seabios was built

[SeaBIOS] Re: patch: add run-time option to load but not execute option roms

2021-05-20 Thread Kevin O'Connor
On Sun, May 16, 2021 at 12:25:27AM +0100, Leah Rowe via SeaBIOS wrote: > From anecdotal reports, sometimes it is useful; I've heard of instances where > certain Nvidia graphics cards can, if using the nouveau driver on a GNU+Linux > system, be used without running any option ROM, but where the

[SeaBIOS] Re: [PATCH] stacks: always call check_irqs() in yield()

2021-05-20 Thread Kevin O'Connor
On Fri, May 14, 2021 at 08:03:20PM +0200, Volker Rümelin wrote: > The comment above the yield() function suggests that yield() > allows interrupts for a short time. Currently this is only true > if seabios was built without CONFIG_THREADS or if yield() is > called from the main thread. Change the

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

2021-05-20 Thread Kevin O'Connor
On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote: > Hi, > > This patch series adds support for all HD and QXGA resolutions. > > I've taken Gerd's advice on the v1 patch and split the formatting > improvments into a separate patch. > > I also tried to take Gerd's advice

[SeaBIOS] Re: [PATCH] fw/coreboot.c: Use coreboot table to find cbfs

2021-05-20 Thread Kevin O'Connor
On Fri, Apr 30, 2021 at 10:28:26AM +0200, Arthur Heymans wrote: > The "cbfs master header" cbfs file is considered a legacy feature in > coreboot and is planned for removal in the master branch. Since 2015 > the coreboot tables have exported info about the active cbfs. > > This change uses the

[SeaBIOS] Re: [PATCH] vgasrc/vgalayout.lds.S: ignore .node.gnu.property (binutils-2.36 support)

2021-05-20 Thread Kevin O'Connor
On Fri, Apr 30, 2021 at 11:30:33PM +0100, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Modern binutils unconditionally tracks x86_64 ISA levels in intermediate > files in .note.gnu.property. Custom liker script does not handle the > section and complains about it: > > ld

[SeaBIOS] Re: SeaBIOS fails to boot from NVMe controller with lots of namespaces

2021-04-14 Thread Kevin O'Connor
On Thu, Apr 08, 2021 at 01:32:47PM +0200, Gerd Hoffmann wrote: > > > > I changed the number of namespaces my controller reports to 1 and it > > > > worked fine. Is there an easy way to get around this or do I have to > > > > fix the code? I haven't looked at the code in detail, but I think we > >

[SeaBIOS] Re: [PATCH] boot: add config option for fast device init

2021-04-14 Thread Kevin O'Connor
On Thu, Apr 08, 2021 at 12:02:23PM +0200, Gerd Hoffmann wrote: > Hi, > > > > > > Add a config option for fast device init (i.e. skip non-bootable > > > > > devices). This optimization breaks boot in some rare configurations, > > > > > specifically in case the boot loader needs access to

[SeaBIOS] Re: [PATCH] malloc: Add check to avoid dereference NULL pointer.

2021-04-02 Thread Kevin O'Connor
On Tue, Mar 23, 2021 at 03:03:37AM +, likejun (A) wrote: > From: Kejun Li mailto:likej...@huawei.com>> > > Date: Mon, 22 Mar 2021 14:03:10 +0800 > > Subject: [PATCH] malloc: Add check to avoid dereference NULL pointer. > > > > info = alloc_find_lowest() may return NULL, should check

[SeaBIOS] Re: [PATCH] vgasrc/svgamodes: added 4k resolution

2021-04-02 Thread Kevin O'Connor
On Sun, Mar 14, 2021 at 01:48:07PM +0100, vit...@cyberhaven.com wrote: > From: Vitaly Chipounov > > This requires at least 32MB of video memory. > > Tested with Windows 10's default display driver and virtio-vga. > > Signed-off-by: Vitaly Chipounov > --- > vgasrc/bochsvga.h | 4 ++-- >

[SeaBIOS] Re: Bump max MPTABLE and SMBIOS sizes from 600 to 768

2021-04-02 Thread Kevin O'Connor
really justified in the first place: 768 decimal is > > 0x300, while 600 is a weird 0x258. > > > > On Tue, Mar 9, 2021 at 2:28 AM Kevin O'Connor wrote: > > > > > > On Tue, Mar 02, 2021 at 11:21:27PM +0300, Mike Banon wrote: > > > > There are plenty of cor

[SeaBIOS] Re: [PATCH] boot: add config option for fast device init

2021-04-02 Thread Kevin O'Connor
On Fri, Mar 26, 2021 at 09:52:49AM +0100, Gerd Hoffmann wrote: > On Tue, Mar 23, 2021 at 04:31:41PM +0100, Paul Menzel wrote: > > Dear Gerd, > > > > > > On 2021-03-23 15:18, Gerd Hoffmann wrote: > > > Add a config option for fast device init (i.e. skip non-bootable > > > devices). This

[SeaBIOS] Re: [PATCH 1/1] usb-hid: Increase MAX_KBD_EVENT

2021-03-11 Thread Kevin O'Connor
On Tue, Mar 09, 2021 at 03:14:05AM +0100, Stefan Ott via SeaBIOS wrote: > Some USB keyboards use max packet sizes beyond the current maximum > supported by SeaBIOS. > > This increases the available size to support keyboards such as the > Matias Ergo Pro. Thanks - I committed this change. -Kevin

[SeaBIOS] Re: [PATCH 00/31] Add support for PA-RISC CPU target

2021-03-08 Thread Kevin O'Connor
On Wed, Mar 03, 2021 at 05:26:23PM +0100, Helge Deller wrote: > On 2/24/21 2:23 AM, Kevin O'Connor wrote: > > Similarly, there are many cases where parisc has different > > implementations of similar functionality that isn't architecture > > I assume you meant "...tha

[SeaBIOS] Re: Bump max MPTABLE and SMBIOS sizes from 600 to 768

2021-03-08 Thread Kevin O'Connor
On Tue, Mar 02, 2021 at 11:21:27PM +0300, Mike Banon wrote: > There are plenty of coreboot platforms whose MPTABLE size is just > slightly larger than the current uneven limit of 600 bytes, which > prevents these important tables from being copied. For example, G505S > has 628 bytes and A88XM-E

[SeaBIOS] Re: [PATCH 1/1] usb-hid: Increase MAX_KBD_EVENT

2021-03-08 Thread Kevin O'Connor
On Tue, Mar 02, 2021 at 05:04:06AM +0100, Stefan Ott via SeaBIOS wrote: > Hi Paul > > > Thank you for the patch. It’d be great, if you added the exact > > keyboard model, you experienced this with. > > The keyboard model is a Matias Ergo Pro. Would you like me to > re-submit the patch with the

[SeaBIOS] Re: [PATCH 00/31] Add support for PA-RISC CPU target

2021-02-23 Thread Kevin O'Connor
On Thu, Feb 11, 2021 at 11:00:34PM +0100, Helge Deller wrote: > This patchset modifies SeaBIOS source code to be able to build a firmware for > the PA-RISC CPU architecture. This firmware can then be used to boot a virtual > PA-RISC machine with PA-Linux and HP/UX on QEMU. > > Where possible

[SeaBIOS] Re: Possibility to merge the SeaBIOS-parisc tree?

2021-02-08 Thread Kevin O'Connor
On Tue, Feb 02, 2021 at 03:31:56PM +0100, Helge Deller wrote: > Dear SeaBIOS developers, > > a few years back I forked the SeaBIOS sources to create > a SeaBIOS firmware for usage with the parisc/hppa architecture. > This fork is on github: > https://github.com/hdeller/seabios-hppa Interesting.

[SeaBIOS] Re: [PATCH 4/4] boot: Support booting more than 2 hard drives

2021-01-17 Thread Kevin O'Connor
On Thu, Dec 31, 2020 at 07:08:26PM -0800, Bin Gao wrote: > By default SeaBIOS can map up to 2 hard disks, and more hard disks beyond > 2 will be rejected. This restriction is caused by limited BDA slots. > This patch added support for mapping more than 2 hard disks by dynamically > mapping the

[SeaBIOS] Re: [PATCH 3/4] csm: Move pci_probe_devices() from InitializeYourself phase to PreparToBoot phase

2021-01-17 Thread Kevin O'Connor
On Thu, Dec 31, 2020 at 07:08:25PM -0800, Bin Gao wrote: > On physical hardware, some PCI devices are not detectable when > UEFI invokes our InitializeYourself() function. But they > are guaranteed to be available before UEFI invokes our > PreparToBoot() function. > > Signed-off-by: Bin Gao >

[SeaBIOS] Re: [PATCH 2/4] csm: Enable boot from pci option rom

2021-01-17 Thread Kevin O'Connor
On Thu, Dec 31, 2020 at 07:08:24PM -0800, Bin Gao wrote: > In csm mode, the bev pointer of the pci option rom was not > added to the bootentry list, resulting in failure to boot > from pci option rom. This patch fixed it. > Also we enabled hw timer interrupt and clock update before > we call the

[SeaBIOS] Re: [PATCH 1/4] pci: Allow scanning pci bus number up to 255 in CSM mode

2021-01-17 Thread Kevin O'Connor
On Thu, Dec 31, 2020 at 07:08:23PM -0800, Bin Gao wrote: > On real hardware especially server platforms, there might be multiple > root buses, thus pci bus number could run up to 255. This patch fixed > pci_probe_devices() by allowing to scan all 256 pci bus numbers(0-255). > > Signed-off-by: Bin

[SeaBIOS] Re: [PATCH] Support booting USB drives with a write protect switch enabled

2020-12-21 Thread Kevin O'Connor
On Sun, Dec 13, 2020 at 03:30:45PM +0300, Mike Banon wrote: > Each try takes about ~3300 ticks of a timer (got this info by some > inserts of u32 cur = timer_read(); dprintf(1, "tries %d=%d\n", tries, > cur);). A bit unsure how it translates to seconds (the CPU frequency > of my laptop fluctuates

[SeaBIOS] Re: [PATCH 00/19] Support SMBIOS 3.0 entry points

2020-12-21 Thread Kevin O'Connor
On Fri, Dec 11, 2020 at 02:46:29PM -0500, Eduardo Habkost wrote: > On Fri, Dec 11, 2020 at 10:46:00AM -0500, Kevin O'Connor wrote: > > What is the integration plan for merging this and making the > > associated changes to QEMU? Are you looking to merge this first? > > The QE

[SeaBIOS] Re: [PATCH 00/19] Support SMBIOS 3.0 entry points

2020-12-11 Thread Kevin O'Connor
On Thu, Dec 10, 2020 at 04:26:21PM -0500, Eduardo Habkost wrote: > This series implements support for SMBIOS 3.0 entry points in > > SeaBIOS. > > > The main advantage of SMBIOS 3.0 entry points is the higher limit > for total table size. The SMBIOS 2.1 64435 bytes limit can be > easily hit in

[SeaBIOS] Re: [PATCH] Support booting USB drives with a write protect switch enabled

2020-12-09 Thread Kevin O'Connor
On Thu, Dec 03, 2020 at 07:06:59AM +0300, Mike Banon wrote: > At least some USB drives with a write protect switch (e.g. Netac U335) > could report "MEDIUM NOT PRESENT" for a while if a write protection is > enabled. Instead of stopping the initialization attempts immediately, > stop only after

[SeaBIOS] Re: [PATCH v2] nvme: Clean up nvme_cmd_readwrite()

2020-11-16 Thread Kevin O'Connor
On Thu, Nov 05, 2020 at 04:09:32PM +, David Woodhouse wrote: > From: David Woodhouse > > This ended up with an odd mix of recursion (albeit *mostly* > tail-recursion) and interation that could have been prettier. In > addition, while recursing it potentially adjusted op->count which is >

[SeaBIOS] Re: [PATCH v3 4/4] nvme: Split requests by maximum allowed size

2020-10-30 Thread Kevin O'Connor
On Thu, Oct 29, 2020 at 05:21:04PM +, David Woodhouse wrote: > On Wed, 2020-10-07 at 12:13 -0400, Kevin O'Connor wrote: > > > > > --- a/src/hw/nvme.c > > > > > +++ b/src/hw/nvme.c > > > > > @@ -727,6 +727,22 @@ nvme_cmd_readwrite(struct nvme_nam

[SeaBIOS] Re: [PATCH v3 0/4] nvme: Add PRP List support

2020-10-28 Thread Kevin O'Connor
On Wed, Sep 30, 2020 at 11:10:52PM +0200, Alexander Graf wrote: > While looking at VM bootup times, we stumbled over the fact that the NVMe > code only does I/O operations of up to 4kb at a given point in time. This > is usually ok, but if you have an OS that loads a lot of data on boot in >

[SeaBIOS] Re: [PATCH] usb boot: add xhci mmio example

2020-10-14 Thread Kevin O'Connor
On Tue, Oct 13, 2020 at 11:10:19AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > src/boot.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/boot.c b/src/boot.c > index bd78fb907c5a..1effd802ce06 100644 > --- a/src/boot.c > +++ b/src/boot.c >

[SeaBIOS] Re: [PATCH v3 4/4] nvme: Split requests by maximum allowed size

2020-10-07 Thread Kevin O'Connor
On Sat, Oct 03, 2020 at 05:40:58AM +, Graf (AWS), Alexander wrote: > Hey Kevin, > > > Am 03.10.2020 um 03:47 schrieb Kevin O'Connor : > > > > > >> On Wed, Sep 30, 2020 at 11:10:56PM +0200, Alexander Graf wrote: > >> Some NVMe controller

[SeaBIOS] Re: [PATCH v3 4/4] nvme: Split requests by maximum allowed size

2020-10-02 Thread Kevin O'Connor
On Wed, Sep 30, 2020 at 11:10:56PM +0200, Alexander Graf wrote: > Some NVMe controllers only support small maximum request sizes, such as > the AWS EBS NVMe implementation which only supports NVMe requests of up > to 32 pages (256kb) at once. > > BIOS callers can exceed those request sizes by

[SeaBIOS] Re: [PATCH 0/3] usb/xhci: add support for mmio host adapters (via acpi).

2020-09-30 Thread Kevin O'Connor
On Wed, Sep 30, 2020 at 01:14:30PM +0200, Gerd Hoffmann wrote: > Gerd Hoffmann (3): > > usb: add boot prio support for mmio host adapters > > usb/xhci: split xhci setup into generic and pci parts > > usb/xhci: add support for mmio host adapters (via acpi). > Thanks. The series looks

[SeaBIOS] Re: [PATCH 0/2] dsdt: add support for pnp ids as strings

2020-09-30 Thread Kevin O'Connor
On Wed, Sep 30, 2020 at 01:12:20PM +0200, Gerd Hoffmann wrote: > Gerd Hoffmann (2): > > output: add support for uppercase hex numbers > > dsdt: add support for pnp ids as strings > Thanks. The series looks okay to me. -Kevin ___ SeaBIOS mailing

[SeaBIOS] Re: [PATCH 1/3] usb: add boot prio support for mmio host adapters

2020-09-30 Thread Kevin O'Connor
On Wed, Sep 30, 2020 at 01:14:31PM +0200, Gerd Hoffmann wrote: > Add mmio field to usb controller struct, add support for mmio-mapped > usb host adapters to boot order handling. > > Signed-off-by: Gerd Hoffmann > --- > src/hw/usb.h | 1 + > src/boot.c | 10 +- > 2 files changed, 10

[SeaBIOS] Re: [SEABIOS] [PATCH] usb.c: Fix devices using non-primary interface descriptor

2020-09-25 Thread Kevin O'Connor
On Fri, Sep 11, 2020 at 01:09:11PM -0500, Matt DeVillier wrote: > From 38f63fcd9b646d6a4eac30f0476bbaee611211ce Mon Sep 17 00:00:00 2001 > From: Matt DeVillier > Date: Fri, 11 Sep 2020 12:54:21 -0500 > Subject: [PATCH] usb.c: Fix devices using non-primary interface descriptor > > A fair number

[SeaBIOS] Re: [PATCH] smbios: avoid integer overflow adding SMBIOS type 0 table

2020-09-25 Thread Kevin O'Connor
On Mon, Sep 14, 2020 at 10:38:26AM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 11, 2020 at 02:03:23PM -0400, Kevin O'Connor wrote: > > On Tue, Sep 08, 2020 at 04:21:03PM +0100, Daniel P. Berrangé wrote: > > > SeaBIOS implements the SMBIOS 2.1 entry point which is limited

[SeaBIOS] Re: [PATCH] smbios: avoid integer overflow adding SMBIOS type 0 table

2020-09-11 Thread Kevin O'Connor
On Tue, Sep 08, 2020 at 04:21:03PM +0100, Daniel P. Berrangé wrote: > SeaBIOS implements the SMBIOS 2.1 entry point which is limited to a > maximum length of 0x. If the SMBIOS data received from QEMU is large > enough, then adding the type 0 table will cause integer overflow. This > results in

[SeaBIOS] Re: [SEABIOS] [PATCH] usb-hid: Fix keyboards using non-primary interface descriptor

2020-09-03 Thread Kevin O'Connor
On Thu, Sep 03, 2020 at 10:32:24PM -0400, Kevin O'Connor wrote: > On Thu, Sep 03, 2020 at 09:03:50PM -0500, Matt DeVillier wrote: > > On Thu, Sep 3, 2020 at 7:28 PM Kevin O'Connor wrote: > > > If we're going to support multiple interfaces, I think it would be > > > pr

[SeaBIOS] Re: [SEABIOS] [PATCH] usb-hid: Fix keyboards using non-primary interface descriptor

2020-09-03 Thread Kevin O'Connor
On Thu, Sep 03, 2020 at 10:32:24PM -0400, Kevin O'Connor wrote: > On Thu, Sep 03, 2020 at 09:03:50PM -0500, Matt DeVillier wrote: > > On Thu, Sep 3, 2020 at 7:28 PM Kevin O'Connor wrote: > > > If we're going to support multiple interfaces, I think it would be > > > pr

[SeaBIOS] Re: [SEABIOS] [PATCH] usb-hid: Fix keyboards using non-primary interface descriptor

2020-09-03 Thread Kevin O'Connor
On Thu, Sep 03, 2020 at 09:03:50PM -0500, Matt DeVillier wrote: > On Thu, Sep 3, 2020 at 7:28 PM Kevin O'Connor wrote: > > If we're going to support multiple interfaces, I think it would be > > preferable to expand the loop so that it also works for MASS_STORAGE > > and HUB

[SeaBIOS] Re: [SEABIOS] [PATCH] usb-hid: Fix keyboards using non-primary interface descriptor

2020-09-03 Thread Kevin O'Connor
On Tue, Sep 01, 2020 at 01:31:18AM -0500, Matt DeVillier wrote: > From 9e408a5441330b120a477324c017c0525cb5b365 Mon Sep 17 00:00:00 2001 > From: Matt DeVillier > Date: Tue, 1 Sep 2020 01:21:23 -0500 > Subject: [PATCH] usb-hid: Fix keyboards using non-primary interface descriptor > > A fair

[SeaBIOS] Re: [PATCH] AHCI: The attached ATA device cannot be detected when binding AHCI controller to Virtual Machine

2020-08-10 Thread Kevin O'Connor
On Tue, Aug 04, 2020 at 11:17:05AM -, runaguo...@zhaoxin.com wrote: > When binding AHCI controller to virtual machine, the attached ATA device > cannot be recognized for the following reason: > The first Identify PACKET CMD will be failed without dobut which will lead > PORT_IRQ_TF_ERR be

[SeaBIOS] [ANNOUNCE] SeaBIOS 1.14.0

2020-08-10 Thread Kevin O'Connor
acpi: add xsdt support acpi: add dsdt parser acpi: skip kbd init if not present acpi: find and register virtio-mmio devices rewrap Makefile lines. pci: fix mmconfig support vga: fix cirrus bios Kevin O'Connor (6): usb-hid: Improve max packet size

[SeaBIOS] Re: release planning

2020-07-28 Thread Kevin O'Connor
On Thu, Jul 02, 2020 at 01:56:15PM +0200, Gerd Hoffmann wrote: > On Thu, Jul 02, 2020 at 07:36:43AM -0400, Kevin O'Connor wrote: > > On Tue, Jun 30, 2020 at 10:57:15AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > qemu 5.1 is coming closer, with fr

[SeaBIOS] Re: [PATCH v2] virtio-scsi: fix boot prio detection by using correct lun

2020-07-28 Thread Kevin O'Connor
On Mon, Jul 27, 2020 at 03:14:15PM +0200, Stefan Reiter wrote: > Commits > > d6bdb85eb0 virtio-scsi: skip initializing non-bootable devices > f82e82a5ab2 virtio-mmio: add support for scsi devices. > > both use the lun value from tmpl_drv, which is always 0, instead of the > correct one

[SeaBIOS] Re: [PATCH] hw/nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5

2020-07-28 Thread Kevin O'Connor
On Mon, Jul 27, 2020 at 02:59:42PM +0200, Paul Menzel wrote: > Currently, setting SeaBIOS debug level to 3, the log is filled with > messages like below. > > ns 1 read lba 11346288+8: 0 > ns 1 read lba 11346296+4: 0 > ns 1 read lba 11346300+4: 0 > ns 1 read lba 11346304+8: 0 >

[SeaBIOS] Re: [PATCHv2] ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects

2020-07-28 Thread Kevin O'Connor
On Fri, Jul 24, 2020 at 10:41:56AM -0400, Kevin O'Connor wrote: > Add a script to remove the ET_EXEC flag from the 16bit and "32bit > segmented" intermediate objects. This avoids build failures with some > linkers that will not allow linking these objects again. FYI, I c

[SeaBIOS] [PATCHv2] ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects

2020-07-24 Thread Kevin O'Connor
Add a script to remove the ET_EXEC flag from the 16bit and "32bit segmented" intermediate objects. This avoids build failures with some linkers that will not allow linking these objects again. Signed-off-by: Kevin O'Connor -- v2: Use python instead of python2 in the scr

[SeaBIOS] Re: [PATCH] ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects

2020-07-24 Thread Kevin O'Connor
On Fri, Jul 24, 2020 at 12:55:31PM +0200, Gerd Hoffmann wrote: > Hi, > > > +++ b/scripts/ldnoexec.py > > +#!/usr/bin/env python2 > > Why "python2"? All other scripts have just "python" ... The script runs on python2 or python3. I'll make that change. -Kevin

[SeaBIOS] Re: release planning

2020-07-22 Thread Kevin O'Connor
On Tue, Jul 21, 2020 at 11:03:58PM +0200, Gerd Hoffmann wrote: > > > > I'm fine with tagging a new release. I'm not sure we'll necessarily > > > > match QEMU's schedule though. How about we target July 24th for the > > > > release? > > > > > > That'll be fine. Early enough for -rc2, if

[SeaBIOS] [PATCH] ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects

2020-07-22 Thread Kevin O'Connor
Add a script to remove the ET_EXEC flag from the 16bit and "32bit segmented" intermediate objects. This avoids build failures with some linkers that will not allow linking these objects again. Signed-off-by: Kevin O'Connor --- Makefile| 9 + scripts/ldnoex

[SeaBIOS] Re: release planning

2020-07-21 Thread Kevin O'Connor
On Thu, Jul 02, 2020 at 01:56:15PM +0200, Gerd Hoffmann wrote: > On Thu, Jul 02, 2020 at 07:36:43AM -0400, Kevin O'Connor wrote: > > On Tue, Jun 30, 2020 at 10:57:15AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > qemu 5.1 is coming closer, with fr

[SeaBIOS] Re: [PATCH] vgabios: Fix preserve memory flag in handle_1000

2020-07-16 Thread Kevin O'Connor
On Mon, Jul 13, 2020 at 06:54:25PM -0400, Kevin O'Connor wrote: > Commit 5108c69c made a change to the ordering of some code which broke > the check for the MF_NOCLEARMEM flag. > > Reported by felix.vo...@posteo.de > > Signed-off-by: Kevin O'Connor FYI, I committed th

[SeaBIOS] Re: SeaVGABIOS ignores preserve-memory flag

2020-07-13 Thread Kevin O'Connor
On Sun, Jul 12, 2020 at 03:06:20PM +0200, felix wrote: > Hello, here’s another defect I’ve found, this time in SeaVGABIOS. > > Video BIOS interrupt 0x10 subfunction 0 accepts a flag that determines > whether video memory should be preserved after mode change. SeaVGABIOS > ignores this flag. The

[SeaBIOS] [PATCH] vgabios: Fix preserve memory flag in handle_1000

2020-07-13 Thread Kevin O'Connor
Commit 5108c69c made a change to the ordering of some code which broke the check for the MF_NOCLEARMEM flag. Reported by felix.vo...@posteo.de Signed-off-by: Kevin O'Connor --- vgasrc/vgabios.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/vgasrc/vgabios.c b/vgasrc

[SeaBIOS] Re: recent ld built for x86_64 fails to accept 16bit code as input (seabios build)

2020-07-11 Thread Kevin O'Connor
On Sat, Jul 11, 2020 at 09:22:30AM +0300, Michael Tokarev wrote: > 11.07.2020 03:08, Kevin O'Connor wrote: > [] > > As for the particular workaround, "-z allowexec" generates a warning > > on current versions of ld. Given that, for SeaBIOS, my first reaction >

[SeaBIOS] Re: recent ld built for x86_64 fails to accept 16bit code as input (seabios build)

2020-07-10 Thread Kevin O'Connor
On Fri, Jul 10, 2020 at 11:58:06AM +0100, Nick Clifton wrote: > Hi Guys, > > I have just updated PR 26047 with a suggested patch which I think could > resolve > this situation. (Patch attached here as well in order to save time). It > adds > a new linker command line option: -z

[SeaBIOS] Re: recent ld built for x86_64 fails to accept 16bit code as input (seabios build)

2020-07-09 Thread Kevin O'Connor
On Thu, Jul 09, 2020 at 06:49:37PM +0300, Michael Tokarev wrote: > 09.07.2020 18:41, Kevin O'Connor wrote: > .. > > Some background links: > > > > https://www.mail-archive.com/seabios@seabios.org/msg12275.html > > > > https://sourceware.org/bug

[SeaBIOS] Re: recent ld built for x86_64 fails to accept 16bit code as input (seabios build)

2020-07-09 Thread Kevin O'Connor
On Thu, Jul 09, 2020 at 05:39:48PM +0300, Michael Tokarev wrote: > Hello! > > To clarify from the very beginning, I don't know how this part of the > larger picture actually works. The end result is that seabios project, > with the current source tarball available for download from >

[SeaBIOS] Re: release planning

2020-07-02 Thread Kevin O'Connor
On Tue, Jun 30, 2020 at 10:57:15AM +0200, Gerd Hoffmann wrote: > Hi, > > qemu 5.1 is coming closer, with freeze in a week and release in August. > See https://wiki.qemu.org/Planning/5.1 > > We'll need a new seabios release for qemu 5.1, and the options we have > are: > > (1) cherry-pick

[SeaBIOS] Re: [PATCH v2] timer: Handle decrements of PIT counter

2020-06-26 Thread Kevin O'Connor
On Fri, Jun 26, 2020 at 09:06:58PM +0300, Roman Bolshakov wrote: > There's a fallback to PIT if TSC is not present but it doesn't work > properly. It prevents boot from floppy on isapc and 486 cpu [1][2]. > > SeaBIOS configures PIT in Mode 2. PIT counter is decremented in the mode > but

[SeaBIOS] Re: [PATCH] timer: Handle decrements of PIT counter

2020-06-26 Thread Kevin O'Connor
On Fri, Jun 26, 2020 at 04:09:57PM +0300, Roman Bolshakov wrote: > On Tue, Jun 23, 2020 at 11:00:24PM -0400, Kevin O'Connor wrote: > > Good catch. Could we fix it using the patch below instead though? > > > > -Kevin > > > > > > --- a/src/hw/timer.c > &

[SeaBIOS] Re: [PATCH] vga: fix cirrus bios

2020-06-25 Thread Kevin O'Connor
On Thu, Jun 25, 2020 at 11:17:09AM +0200, Gerd Hoffmann wrote: > Little mistake, big effect. The patch adding the ati driver broke > cirrus due to a missing "else", which effectively downgrades cirrus > to standard vga. Thanks - I committed this change. -Kevin

[SeaBIOS] Re: [PATCH v2] Preserve Xen DebugOutputPort

2020-06-24 Thread Kevin O'Connor
On Wed, Jun 24, 2020 at 10:25:13AM -0400, Jason Andryuk wrote: > xen_preinit() runs early and changes DebugOutputPort. qemu_preinit() runs > soon after. inb on DebugOutputPort doesn't work on Xen, so the check > will always fail and DebugOutputPort will be cleared to 0 disabling > output. > >

[SeaBIOS] Re: [PATCH] timer: Handle decrements of PIT counter

2020-06-23 Thread Kevin O'Connor
On Sat, Jun 13, 2020 at 02:19:12PM +0300, Roman Bolshakov wrote: > There's a fallback to PIT if TSC is not present but it doesn't work > properly. It prevents boot from floppy on isapc and 486 cpu [1][2]. > > SeaBIOS configures PIT in Mode 2. PIT counter is decremented in the mode > but

[SeaBIOS] Re: [PATCH] Preserve Xen DebugOutputPort

2020-06-22 Thread Kevin O'Connor
On Tue, Jun 16, 2020 at 10:31:17PM -0400, Jason Andryuk wrote: > xen_preinit() runs early and changes DebugOutputPort. qemu_preinit() runs > soon after. inb on DebugOutputPort doesn't work on Xen, so the check > will always fail and DebugOutputPort will be cleared to 0 disabling > output. > >

[SeaBIOS] Re: SeaBIOS and superformatted floppies

2020-06-15 Thread Kevin O'Connor
On Fri, Jun 12, 2020 at 08:26:49PM +0200, felix wrote: > Hello, > > Not so long ago, I have stumbled upon some rather disappointing behaviour in > the SeaBIOS floppy driver. After some investigations, I concluded it would > in fact be worthy of a bug report. So here it is. > > The problem is

[SeaBIOS] Re: Boot order?

2020-05-25 Thread Kevin O'Connor
On Mon, May 25, 2020 at 05:19:23PM +, Mogens Jensen wrote: > On Friday, May 15, 2020 2:17 AM, Kevin O'Connor wrote: > > On Tue, May 12, 2020 at 03:39:58PM +, Mogens Jensen wrote: > > > I would expect that it should not matter that flash disk is inserted in >

[SeaBIOS] Re: [PATCH] pci: fix mmconfig support

2020-05-25 Thread Kevin O'Connor
On Mon, May 25, 2020 at 11:06:27AM +0200, Gerd Hoffmann wrote: > The MODESEGMENT condition is backwards, with the effect that > mmconfig mode is not used to configure pci bars during POST. > > Oops. Fix it. Thanks. I went ahead and committed this patch. -Kevin

[SeaBIOS] Re: [PATCH] ps2: Disable keyboard and mouse before flushing the queue

2020-05-23 Thread Kevin O'Connor
On Sat, May 23, 2020 at 11:10:24PM +0200, Paul Menzel wrote: > From: Stefan Reinauer > > If SeaBIOS is run as a payload via coreboot (and presumably as a > CSM), then it's possible the keyboard or mouse will still be > enabled. This can lead to data being queued even after the flush > function

[SeaBIOS] Re: [PATCH] ps2port: adjust init routine to fix PS/2 keyboard issues

2020-05-21 Thread Kevin O'Connor
On Tue, Mar 17, 2020 at 08:30:32PM -0400, Kevin O'Connor wrote: > On Mon, Mar 16, 2020 at 10:38:25AM +0100, Paul Menzel wrote: > > From: Matt DeVillier > > Date: Fri, 12 Aug 2016 14:21:58 -0500 > > > > PS/2 keyboards on Chromebooks with upstream coreboot + SeaBIOS ofte

[SeaBIOS] Re: [PATCH] cdrom: Demote `scsi_is_ready` return print to debug level

2020-05-21 Thread Kevin O'Connor
On Mon, May 18, 2020 at 06:58:04PM +0200, Paul Menzel wrote: > Printing the return value of `scsi_is_ready()` is a debug message, so > change the log level from 1 to 5. > > Booting from DVD/CD... > Device reports MEDIUM NOT PRESENT > scsi_is_ready returned -1 > Boot failed: Could

[SeaBIOS] Re: [PATCH v2 1/3] boot: Extend `etc/show-boot-menu` to configure skipping boot menu with only one device

2020-05-21 Thread Kevin O'Connor
On Tue, May 19, 2020 at 11:39:42PM +0200, Paul Menzel wrote: > Concerns were raised, that skipping the boot menu, if only one device is > present, might make debugging issues more difficult. So, extend the > current runtime configuration option `etc/show-boot-menu` to enable this > feature by

[SeaBIOS] Re: [PATCH 2/3] boot: Log, if boot menu is skipped

2020-05-17 Thread Kevin O'Connor
On Wed, Apr 22, 2020 at 09:19:37PM +0200, Paul Menzel wrote: > Signed-off-by: Paul Menzel > --- > src/boot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/boot.c b/src/boot.c > index 595cd77..8b33070 100644 > --- a/src/boot.c > +++ b/src/boot.c > @@ -673,6 +673,7 @@

[SeaBIOS] Re: [PATCH] rewrap Makefile lines.

2020-05-17 Thread Kevin O'Connor
On Fri, May 15, 2020 at 01:45:55PM +0200, Gerd Hoffmann wrote: > Rewrap SRCBOTH and SRC32FLAT variables in Makefile to keep line length > below 80 chars. No functional change. > > Signed-off-by: Gerd Hoffmann Thanks. Looks good to me. -Kevin > --- > Makefile | 32

[SeaBIOS] Re: Boot order?

2020-05-14 Thread Kevin O'Connor
On Tue, May 12, 2020 at 03:39:58PM +, Mogens Jensen wrote: > First posted this question to coreboot mailing list, but on second thought, I > think this is the right place. > > I have experimentet with coreboot on my CompuLab Intense PC (Ivy Bridge) for > some time, and I think everything is

[SeaBIOS] Re: [PATCH 3/3] qemu: check rtc presence before reading cpu count from cmos

2020-05-14 Thread Kevin O'Connor
On Fri, May 08, 2020 at 01:37:17PM +0200, Gerd Hoffmann wrote: > Read month register which should never have a value larger than 12. > In case the read returns 0xff assume the rtc isn't there. > Don't try to read the cpu count from cmos without rtc. > > Signed-off-by: Gerd Hoffmann FYI, the

[SeaBIOS] Re: [PATCH v3 7/9] acpi: add dsdt parser

2020-05-14 Thread Kevin O'Connor
GPLv3 license. > > +#include "byteorder.h" // le32_to_cpu > +#include "config.h" // CONFIG_* > +// Support for manipulating bios tables (pir, mptable, acpi, smbios). > +// > +// Copyright (C) 2008,2009 Kevin O'Connor > +// > +// This file may be

[SeaBIOS] Re: [PATCH v2] build: use -fcf-protection=none when available

2020-05-14 Thread Kevin O'Connor
On Tue, May 12, 2020 at 12:58:31PM +0200, Christian Ehrhardt wrote: > On Fri, Mar 20, 2020 at 9:38 AM Christian Ehrhardt > wrote: > > > > Some hardened gcc v9 compilers (such as the one in Ubuntu) > > default this option which for seabios leads to emulation errors > > when running in KVM (does

[SeaBIOS] Re: [PATCH 1/3] boot: Extend `etc/show-boot-menu` to configure skipping boot menu with only one device

2020-04-25 Thread Kevin O'Connor
On Wed, Apr 22, 2020 at 09:19:36PM +0200, Paul Menzel wrote: > Concerns were raised, that skipping the boot menu, if only one device is > present might make debugging issues more difficult. So, extend the > current runtime configuration option `etc/show-boot-menu` by enabling > this feature by

[SeaBIOS] Re: [PATCH] Skip boot menu and timeout with only one boot device

2020-04-19 Thread Kevin O'Connor
On Tue, Mar 17, 2020 at 08:27:59PM -0400, Kevin O'Connor wrote: > On Mon, Mar 16, 2020 at 10:32:41AM +0100, Paul Menzel wrote: > > From: Matt DeVillier > > Date: Fri, 13 Jun 2014 17:20:23 -0500 > > > > Signed-off-by: Matt DeVillier > > Signed-off-by: Paul Menzel

[SeaBIOS] Re: [PATCH] ps2port: adjust init routine to fix PS/2 keyboard issues

2020-04-19 Thread Kevin O'Connor
On Thu, Mar 26, 2020 at 03:52:58PM -0500, Matt DeVillier wrote: > On Thu, Mar 26, 2020 at 2:33 PM Paul Menzel wrote: > > Am 26.03.20 um 20:29 schrieb Matt DeVillier: > > > as requested I went ahead and retested a few different Chromebook > > > devices/platforms using upstream coreboot + SeaBIOS

[SeaBIOS] Re: [PATCH v2 0/3] tpm: Somce tcgbios related fixes and updates

2020-04-19 Thread Kevin O'Connor
On Mon, Mar 30, 2020 at 07:55:54AM -0400, Stefan Berger wrote: > This series of patches modifies the logging of events so that only > active PCR banks are logged. An active PCR bank is recognized by > the pcrSelect[0] being != 0. > > The vendorInfoSize was assumed to be u32 but it is u8. > >

[SeaBIOS] Re: [PATCH v3 0/5] Make seabios linkable with lld

2020-04-17 Thread Kevin O'Connor
On Tue, Apr 14, 2020 at 12:07:54PM -0700, Fāng-ruì Sòng wrote: > On Mon, Apr 6, 2020 at 5:55 PM Fangrui Song wrote: > > This patch series make seabios linkable with lld. > > [...] > Ping... > > And >

[SeaBIOS] Re: [PATCH 7/9] acpi: add dsdt parser

2020-04-08 Thread Kevin O'Connor
On Wed, Apr 08, 2020 at 02:39:39PM +0200, Gerd Hoffmann wrote: > > > +again: > > > +switch (ptr[offset]) { > > > +case 0: /* null name */ > > > +offset++; > > > +*(dst++) = 0; > > > +break; > [ ... ] > > > +case '^': > > > +*(dst++) = '^'; > > > +

[SeaBIOS] Re: [PATCH 1/4] Make rom16.o linkable with lld

2020-04-06 Thread Kevin O'Connor
On Mon, Apr 06, 2020 at 05:26:35PM -0700, Fangrui Song wrote: > On 2020-04-06, Kevin O'Connor wrote: > > On Wed, Apr 01, 2020 at 10:29:12AM -0700, Fangrui Song wrote: > > > (1) In romlayout.S, .fixedaddr.\addr sections do have not the SHF_ALLOC > > > flag. &

[SeaBIOS] Re: [PATCH 4/4] test-build.sh: Delete unneeded LD capability test

2020-04-06 Thread Kevin O'Connor
On Wed, Apr 01, 2020 at 10:29:15AM -0700, Fangrui Song wrote: > The previous commit changed romlayout32flag.lds to use `. += ` instead > of `. =`. > We no longer need the LD capability test checking > https://sourceware.org/bugzilla/show_bug.cgi?id=12726 Thanks. It would be great to remove this

[SeaBIOS] Re: [PATCH 3/4] romlayout32flag.lds: Use `. +=` instead of `. =`

2020-04-06 Thread Kevin O'Connor
On Wed, Apr 01, 2020 at 10:29:14AM -0700, Fangrui Song wrote: > This improves the portability of the linker script and allows lld to link > rom.o > > Dot assignment inside an output section has an inconsistent behavior > which makes lld difficult to implement. > See

[SeaBIOS] Re: [PATCH 2/4] Makefile: Change ET_EXEC to ET_REL so that lld can link bios.bin.elf

2020-04-06 Thread Kevin O'Connor
On Wed, Apr 01, 2020 at 10:29:13AM -0700, Fangrui Song wrote: > Accepting ET_EXEC as an input file is an extremely rare GNU ld feature > that lld does not intend to support, because this is error-prone. > > See Linux kernel commit 90ceddcb495008ac8ba7a3dce297841efcd7d584 for > another use of the

[SeaBIOS] Re: [PATCH 1/4] Make rom16.o linkable with lld

2020-04-06 Thread Kevin O'Connor
On Wed, Apr 01, 2020 at 10:29:12AM -0700, Fangrui Song wrote: > (1) In romlayout.S, .fixedaddr.\addr sections do have not the SHF_ALLOC flag. > It does not make sense to reference a SHF_ALLOC section from a non-SHF_ALLOC > section via R_386_PC16. > GNU ld allows it but lld will warn. Add the

[SeaBIOS] Re: [PATCH v2] Use readelf -WSrs instead of objdump -thr so that llvm-readelf can be used as a replacement

2020-04-06 Thread Kevin O'Connor
On Wed, Apr 01, 2020 at 06:12:09PM -0700, Fangrui Song wrote: > objdump -h relies heavily on BFD internals and the BFD flags are difficult to > emulate in llvm-objdump. > llvm-objdump -h has a different output (https://reviews.llvm.org/D57146) > > Switch to readelf, which is generally better

[SeaBIOS] Re: [PATCH 7/9] acpi: add dsdt parser

2020-04-06 Thread Kevin O'Connor
On Fri, Apr 03, 2020 at 10:31:19AM +0200, Gerd Hoffmann wrote: > Create a list of devices found in the DSDT table. Add helper functions > to find devices, walk the list and figure device informations like mmio > ranges and irqs. > > Signed-off-by: Gerd Hoffmann > --- > src/util.h |

<    1   2   3   4   5   6   7   8   9   10   >