Re: [SeaBIOS] [PATCH] fix comment typo in __make_bios_writable_intel()

On Fri, Jan 29, 2016 at 07:51:42PM +0800, Cao jin wrote: > Hi, > Am I wrong about this? The proposed comments aren't wrong, but the previous comments weren't wrong either. I don't think a change is warranted. -Kevin > On 01/25/2016 07:26 PM, Cao jin wrote: > >Signed-off-by: Cao jin

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

On Wed, Jan 27, 2016 at 03:51:02PM +0100, Paolo Bonzini wrote: > From: Don Slutz > > Also known as Fusion MPT disk; this controller model is supported > by VirtualBox and VMware, and QEMU support patches have been > posted. > > Signed-off-by: Don Slutz

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

On Wed, Jan 27, 2016 at 10:45:13AM -0600, Timothy Pearson wrote: > On 01/27/2016 10:38 AM, Paolo Bonzini wrote: > > On 27/01/2016 16:57, Kevin O'Connor wrote: > >> On Wed, Jan 27, 2016 at 03:51:02PM +0100, Paolo Bonzini wrote: > >>> --- a/src/Kconfig > >>>

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

On Wed, Jan 27, 2016 at 06:19:43PM +0100, Paolo Bonzini wrote: > On 27/01/2016 18:15, Kevin O'Connor wrote: > > Oh, I understand and agree that recovery isn't worth while. My > > concern is that a hardware error here will appear as a silent hang. > > Breaking out of the loo

Re: [SeaBIOS] Repeat of Query

On Wed, Jan 27, 2016 at 08:05:38PM +, Eli Duttman wrote: > Nothing has come my way, regarding my initial query. I'd appreciate a > response, even if it is in the negative. > > > I'm sorry my skills rate to be of zero help with the project. I can read a > little C and dabbled with x86

Re: [SeaBIOS] sd card support

On Tue, Jan 26, 2016 at 04:17:54PM +, Wim Vervoorn wrote: > Hello Kevin, > > I am trying to use the sdcard support in SeaBIOS. > > It is working but the performance is far from optimal. As far as I > was able to see this is because the current support is polling only. > > Do you know if

Re: [SeaBIOS] Qemu/Seabios and loading option roms

On Sat, Jan 23, 2016 at 12:24:38AM +, Bob Moore wrote: > Hi, > > I'm new to qemu/seabios and am in the process of developing an > option rom for a pcie device. I want to use seabios as a driver for > debugging this code. I see documentation that says I can put my > option rom into a file

Re: [SeaBIOS] [RFC PATCH v1 1/9] tpm: Extend TPM TIS with TPM 2 support.

On Fri, Jan 15, 2016 at 02:44:31PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Extend the probing of the interface with TPM 2 specifics. > > Use the new interface ID register of the TIS to check whether > a TPM 1.2 or a TPM 2 is underneath. > > We select

Re: [SeaBIOS] [RFC PATCH v1 3/9] tpm: Prepare code for TPM 2 functions

On Fri, Jan 15, 2016 at 02:44:33PM -0500, Stefan Berger wrote: > From: Stefan Berger > > This patch prepares the tcgbios.c file for extension with TPM 2 > specific code by: > > o prefixing all TPM 1.2 specific functions with tpm12_ I find the "tpm12_" and "tpm2_"

Re: [SeaBIOS] [RFC PATCH v1 6/9] tpm: Implement tpm2_prepboot

On Fri, Jan 15, 2016 at 02:44:36PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Implement tpm2_preboot. > > Here we set the platform password to a random password that prevents > higher layers (OS) to get this password. This avoids bad things like users >

Re: [SeaBIOS] [RFC PATCH v1 0/9] Add TPM 2 support

On Fri, Jan 15, 2016 at 02:44:30PM -0500, Stefan Berger wrote: > This series of patches adds TPM 2 support to SeaBIOS in the way previously > proposed. > > TPM 2 support also changes the log entry format, which I have not addressed > at all so far, and would append to the end of the series.

Re: [SeaBIOS] [RFC PATCH v1 5/9] tpm: Implement tpm2_set_timeouts

On Fri, Jan 15, 2016 at 02:44:35PM -0500, Stefan Berger wrote: > From: Stefan Berger > > The TIS timeouts for TPM 2 are different than for TPM 1.2. > Also the timeouts indicating a failed TPM 2 command are different. > Further, the command durations and timeouts

Re: [SeaBIOS] [PATCH 0/2] Improve reboot races during post and reboot

On Tue, Jan 12, 2016 at 02:57:25PM -0500, Kevin O'Connor wrote: > This is a follow up to an email chain that in November: > > http://www.seabios.org/pipermail/seabios/2015-November/009887.html > > It was possible for the SeaBIOS code to get confused if an external > reboot re

Re: [SeaBIOS] [PATCH 1/2] kbd: Don't treat scancode and asciicode as separate values

On Tue, Jan 12, 2016 at 01:13:36PM -0500, Kevin O'Connor wrote: > The scancode/asciicode pair can be more easily handled as a single > 16bit value. FYI, I committed this series. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.or

Re: [SeaBIOS] [PATCH] biostables: Support SMBIOS 2.6+ UUID format

On Thu, Jan 14, 2016 at 12:24:29PM -0500, Cole Robinson wrote: > On 01/14/2016 12:22 PM, Kevin O'Connor wrote: > > According to SMBIOS v2.6 the first three fields are encoded in > > little-endian format. Versions prior to v2.6 did not specify the > > encoding, but we follow

Re: [SeaBIOS] [PATCH v2] biostables: Support SMBIOS 2.6+ UUID format

On Fri, Jan 15, 2016 at 10:49:32AM -0500, Cole Robinson wrote: > SMBIOS 2.6+ stores the UUID in a different format, with the first 3 > fields in little endian format. This is what modern qemu delivers > and what dmidecode also handles, so let's follow suit too. Thanks - committed. Gerd, I'm

Re: [SeaBIOS] SeaBIOS security feature roadmap?

On Fri, Jan 15, 2016 at 12:38:12PM -0800, Blibbet wrote: > On 01/12/2016 11:36 AM, Kevin O'Connor wrote: > [...] > > As far as a roadmap, I understand there is a plan to add TPM 2.0 > > support to SeaBIOS. > > > > I'm not aware of any new consumer devices shippi

Re: [SeaBIOS] [PATCH] biostables: Support SMBIOS 2.6+ UUID format

On Tue, Jan 12, 2016 at 02:22:41PM -0500, Cole Robinson wrote: > SMBIOS 2.6+ stores the UUID in a different format, with the first 3 > fields in little endian format. This is what modern qemu delivers > and what dmidecode also handles, so let's follow suit too. More > info at this thread: > >

Re: [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

On Thu, Jan 14, 2016 at 05:36:51PM +0100, Gerd Hoffmann wrote: > On Do, 2016-01-14 at 14:50 +, Ian Campbell wrote: > > Hello, > > > > The xen.git development branch currently points to SeaBIOS rel-1.9.0, but > > Roger has tripped over a build issue which is fixed by 3b8c5378dfe2 "build: > >

Re: [SeaBIOS] [PATCH] coreboot: Check for unaligned cbfs header

On Tue, Jan 12, 2016 at 01:40:18PM -0500, Kevin O'Connor wrote: > If the CBFS header is invalid and points to 0x it could cause > SeaBIOS to read past the 4GB boundary and cause an exception. Check > the alignment of the header pointer before attempting to access fields

Re: [SeaBIOS] about the 'mptable' issue

CC'ing the seabios mailing list. On Thu, Jan 14, 2016 at 10:36:07AM +, Li, Liang Z wrote: > Correct something. > The actual parameter for QEMU in our test case is: > 'qemu-systerm-x86_64 -enable-kvm -smp 20 -m 2048 -no-acpi -monitor stdio > -drive file=/mnt/centos6u6.qcow, if=none,

[SeaBIOS] [PATCH] coreboot: Check for unaligned cbfs header

If the CBFS header is invalid and points to 0x it could cause SeaBIOS to read past the 4GB boundary and cause an exception. Check the alignment of the header pointer before attempting to access fields within the header. Reported-by: "Alex G." <mr.nuke...@gmail.com> Sign

[SeaBIOS] [PATCH 2/2] kbd: Refactor capslock and numlock handling

Simplify the scan_to_scanascii[] table by implementing numlock and capslock checking in the code. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 197 ++ 1 file changed, 96 insertions(+), 101 deletions(-) diff

Re: [SeaBIOS] [PATCH v3 0/6] tpm: Fixes for physical presence and API

On Thu, Jan 07, 2016 at 12:02:45PM -0500, Stefan Berger wrote: > Patch 1 fixes the return of a missing digest in the HashLogExtendEvent > command. > > Beyond that the patches extend the handling of physical presence to HW > physical presence and rework the showing of the TPM menu to depend on

Re: [SeaBIOS] SeaBIOS security feature roadmap?

Hi, On Wed, Jan 06, 2016 at 03:22:24PM -0800, Blibbet wrote: > Hi, > > I'm pretty new to the SeaBIOS codebase. I've noticed a lot of > interesting TPM-centric checkins recently.I was wondering if there was > any roadmap for current/upcoming SeaBIOS security features. I'd be > especially

[SeaBIOS] [PATCH 0/2] Improve reboot races during post and reboot

run before starting the "post" boot logic. The reboot handler should always return the BIOS code to a pristine state prior to clearing HaveRunPost. -Kevin Kevin O'Connor (2): resume: Make KVM soft reboot loop detection more flexible post: Always set HaveRunPost prior to sett

[SeaBIOS] [PATCH 1/2] resume: Make KVM soft reboot loop detection more flexible

Move the check for soft reboot loops from resume.c to shadow.c and directly check for the case where the copy of the BIOS in flash appears to be a memory alias instead. This prevents a hang if an external reboot request occurs during the BIOS memcpy. Signed-off-by: Kevin O'Connor <

[SeaBIOS] [PATCH 2/2] post: Always set HaveRunPost prior to setting any other global variable

enter post with global variables in a dirty state.) Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/fw/csm.c| 1 + src/fw/shadow.c | 2 ++ src/fw/xen.c| 1 + src/post.c | 20 src/util.h | 1 + 5 files changed, 21 insertions(+), 4 del

[SeaBIOS] [PATCH 1/2] kbd: Don't treat scancode and asciicode as separate values

The scancode/asciicode pair can be more easily handled as a single 16bit value. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 53 + 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/src/kbd.c b/src/kbd.c

Re: [SeaBIOS] Does SeaBIOS support eMMC?

On Mon, Jan 11, 2016 at 03:49:19PM +, Scheithauer, Mario wrote: > First I will clone a new coreboot with an actual SeaBIOS. After that > I will give you a new log. > But second I think sdcard setup is not ready for JEDEC Standard > 84-B51. Maybe I'm wrong with that. I did use that JEDEC

Re: [SeaBIOS] Does SeaBIOS support eMMC?

On Tue, Jan 12, 2016 at 05:07:08PM +, Scheithauer, Mario wrote: > > -Ursprüngliche Nachricht- > > Von: Kevin O'Connor [mailto:ke...@koconnor.net] > > Gesendet: Dienstag, 12. Januar 2016 17:15 > > An: Scheithauer, Mario > > Cc: seabios@seabios.org > >

Re: [SeaBIOS] Does SeaBIOS support eMMC?

On Tue, Jan 12, 2016 at 12:26:11PM -0500, Kevin O'Connor wrote: > On Tue, Jan 12, 2016 at 05:07:08PM +, Scheithauer, Mario wrote: > > > The drive is showing up as an 2TB drive, so something is clearly wrong > > > with the > > > size detection. Upon attempting

Re: [SeaBIOS] Does SeaBIOS support eMMC?

On Mon, Jan 11, 2016 at 08:29:48AM +, Scheithauer, Mario wrote: > Hello Together, > > I play with coreboot and SeaBIOS on a BayTrail platform. We have an 8GB eMMC > flash on the board. > With that combination I can boot a Lubuntu. > It seems that the current version of SeaBIOS does not

Re: [SeaBIOS] Does SeaBIOS support eMMC?

On Mon, Jan 11, 2016 at 02:59:00PM +, Scheithauer, Mario wrote: > Hello Kevin, Alexander, > > Attached is the boot log. > Thanks that you have a look at the eMMC initialization. > I will try the other way about both files (sdcard0, sdcard1). > I think for my case the address should be

Re: [SeaBIOS] Does SeaBIOS support eMMC?

On Mon, Jan 11, 2016 at 02:46:24PM +0100, Alexander Couzens wrote: > Hi Mario, > > SeaBIOS supports eMMC, but it's a bit hacky. > For eMMC in ACPI mode you have to add files containing the address > of the eMMC to the cbfs. > No idea, if eMMC in PCI mode works out-of-box. There were some

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

On Fri, Jan 08, 2016 at 12:19:52PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/08/2016 11:41:13 AM: > > On Thu, Jan 07, 2016 at 03:39:13PM -0500, Stefan Berger wrote: > > > "Kevin O'Connor" <ke...@koconnor.net>

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

On Thu, Jan 07, 2016 at 03:39:13PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/07/2016 03:14:37 PM: > > I don't have input on what TPM2 organization should look like, mainly > > because I don't know what TPM2 entails. I gather th

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

On Thu, Jan 07, 2016 at 05:08:53PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/07/2016 03:14:37 PM: > > On Thu, Jan 07, 2016 at 01:57:42PM -0500, Stefan Berger wrote: > > > At some point I'll bring the TPM 2 patches

Re: [SeaBIOS] [PATCH] usb: Remove usbdev->slotid field

On Tue, Jan 05, 2016 at 01:44:20PM -0500, Kevin O'Connor wrote: > The usbdev->slotid field is xhci specific and on xhci it is always > reachable from usbdev->defpipe->slotid. FYI, I committed this patch. -Kevin ___ SeaBIOS maili

Re: [SeaBIOS] [PATCH v2 0/6] Fixes for physical presence and API

On Thu, Jan 07, 2016 at 07:55:35AM -0500, Stefan Berger wrote: > Patch 1 fixes the return of a missing digest in the HashLogExtendEvent > command. > > Beyond thad that, the patches extend the handling of physical presence to HW > physical presence and rework the showing of the TPM menu to depend

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

On Thu, Jan 07, 2016 at 01:57:42PM -0500, Stefan Berger wrote: > At some point I'll bring the TPM 2 patches back to life following the many > recent changes... Now my question is how to organize the code. Should there > be one file where we essentially have the above type of code branching into >

Re: [SeaBIOS] [PATCH v2 4/6] Rework the assertion of physical presence

On Thu, Jan 07, 2016 at 07:55:39AM -0500, Stefan Berger wrote: > From: Stefan Berger > > Rework the assertion of physical presence by calling assert_physical_presence > in tpm_setup. This call will assert physical presence if SW assertion is > possible or by checking

Re: [SeaBIOS] [PATCH v3 0/6] tpm: Fixes for physical presence and API

On Thu, Jan 07, 2016 at 12:02:45PM -0500, Stefan Berger wrote: > Patch 1 fixes the return of a missing digest in the HashLogExtendEvent > command. > > Beyond that the patches extend the handling of physical presence to HW > physical presence and rework the showing of the TPM menu to depend on

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

On Wed, Jan 06, 2016 at 11:55:19AM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/05/2016 11:03:00 PM: > > On Tue, Jan 05, 2016 at 10:07:54PM -0500, Stefan Berger wrote: > > > "Kevin O'Connor" <ke..

Re: [SeaBIOS] [PATCH 4/5] Rework the assertion of physical presence

On Wed, Jan 06, 2016 at 01:15:56PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Rework the assertion of physical presence by calling assert_physical_presence > in tpm_setup. This call will assert physical presence if SW assertion is > possible or by checking

Re: [SeaBIOS] [PATCH 3/5] Add support for harware physical presence

On Wed, Jan 06, 2016 at 01:15:55PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Extend assert_physical_presence with checks for hardware physical presence > support. If no hardware physical presence is asserted and the SW assertion > is disable, -1 is

Re: [SeaBIOS] [PATCH 5/5] Give up physical presence when setting TPM into failure mode

On Wed, Jan 06, 2016 at 01:15:57PM -0500, Stefan Berger wrote: > From: Stefan Berger > > After temporarily deactivating the TPM, also give up physical > presence to disable more commands. > > Signed-off-by: Stefan Berger > --- >

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

On Tue, Dec 29, 2015 at 07:17:40PM -0500, Kevin O'Connor wrote: > The following series involves some code reorganization in the TPM code > that I found useful in understanding the code. FYI, I committed patches 1-9 (after some bug fixes).

[SeaBIOS] [PATCH] usb: Remove usbdev->slotid field

The usbdev->slotid field is xhci specific and on xhci it is always reachable from usbdev->defpipe->slotid. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/usb-xhci.c | 6 -- src/hw/usb.h | 1 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --g

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

On Tue, Jan 05, 2016 at 02:05:55PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/05/2016 12:16:18 PM: > > On Tue, Dec 29, 2015 at 07:17:40PM -0500, Kevin O'Connor wrote: > > > The following series involves some code reorganiz

Re: [SeaBIOS] eDP Init Failure on Broadwell

On Sun, Jan 03, 2016 at 07:33:14PM +, CoolStar Organization wrote: > Here's the cbmem with the updated patch. Thanks. To summarize our conversation on IRC, it looks like some hardware flags for this board are changed in coreboot that impact the option rom. The flags are set after coreboot

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

On Tue, Jan 05, 2016 at 10:07:54PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/05/2016 08:55:51 PM: > > Then it sounds like the only time we need to call tpm_set_failure is > > on a failure of a TPM_ORD_Extend command. It might al

Re: [SeaBIOS] [PATCH 0/8] TPM return code simplifications

On Wed, Dec 30, 2015 at 02:31:54PM -0500, Kevin O'Connor wrote: > Hi Stefan, > > I cleaned up the additional patches I mentioned yesterday. > > Some time back, you posted a series of patches that removed the use of > TCG 16bit BIOS structs from internal functions. Many of thos

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

On Tue, Jan 05, 2016 at 05:05:20PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 01/05/2016 03:35:35 PM: [...] > > - Take "measurements" during the boot process so that later on users > > can verify if some low

Re: [SeaBIOS] eDP Init Failure on Broadwell

On Sun, Jan 03, 2016 at 05:30:44PM +, CoolStar Organization wrote: > On a Broadwell based chromebook with upstream coreboot & SeaBIOS, SeaBIOS > fails to initialize the built-in display. > > If coreboot is configured to run the optionrom, keep the VESA framebuffer > and use VESA mode 4117

Re: [SeaBIOS] eDP Init Failure on Broadwell

On Sun, Jan 03, 2016 at 06:29:16PM +, CoolStar Organization wrote: > I have attached 4 cbmem's. > > cbmem.txt is with coreboot running the ROM & seabios using SeaVGABIOS. eDP > Inits properly and all is fine. > > I thought textmode might be the issue so I added a bootsplash but still no >

Re: [SeaBIOS] eDP Init Failure on Broadwell

On Sun, Jan 03, 2016 at 06:48:34PM +, CoolStar Organization wrote: > I'm using SeaBIOS 1.9.0 stable. I'm building with make/gcc on Ubuntu 14.04 > LTS. Will try those patches in a few. Are you building from the git repo or from a tar file? Can you cut-and-paste the build output from "make

Re: [SeaBIOS] eDP Init Failure on Broadwell

On Sun, Jan 03, 2016 at 07:13:03PM +, CoolStar Organization wrote: > Here is the cbmem with the debug patch. Can you try with this debug patch instead? -Kevin --- a/src/vgahooks.c +++ b/src/vgahooks.c @@ -299,10 +299,19 @@ winent_mb6047_setup(struct pci_device *pci) * Entry and setup

[SeaBIOS] [PATCH 4/8] tpm: Don't use 16bit BIOS return codes in build_and_send_cmd()

dprintf() in build_and_send_cmd() instead of in every caller. This replaces the command name with the integer command id, but it does make the debugging more consistent. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c

[SeaBIOS] [PATCH 2/8] tpm: No need to check the return status of measurements

The low-level measurement functions already handle error conditions, there is no need to check for the errors in the high level measurement functions. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 119 --

[SeaBIOS] [PATCH 5/8] tpm: Don't use 16bit BIOS return codes in tpm_log_event()

Don't use the return codes from the 16bit BIOS spec in the internal tpm_log_event() and tpm_log_extend_event() functions. Only the 16bit BIOS interface code should need to handle the details of that spec. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.

[SeaBIOS] [PATCH 1/8] tpm: Don't return a status from external bios measurement functions

The callers of the measurements don't care what happens, so no need to return a status. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 58 -- src/tcgbios.h | 8 2 files changed, 32 insertions(

[SeaBIOS] [PATCH 3/8] tpm: Don't call tpm_set_failure() from tpm_log_extend_event()

The 16bit BIOS interface shouldn't be able to shutdown the TPM. Move the check for tpm_is_working() and tpm_set_failure() to the only caller of tpm_log_extend_event() that may shutdown the TPM. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 21 +-

[SeaBIOS] [PATCH 7/8] tpm: Don't use 16bit BIOS return codes in TPM menu functions

-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 227 +- 1 file changed, 97 insertions(+), 130 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index b31de39..cd6a433 100644 --- a/src/tcgbios.c +++ b/src/tcg

[SeaBIOS] [PATCH 8/8] tpm: Replace build_and_send_cmd with tpm_send_cmd and tpm_send_check_cmd

the code line number in the debugging, but all callers of tpm_set_failure() will log the action that failed immediately prior to the dprintf(). So, the line number should not be necessary. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c

[SeaBIOS] [PATCH 0/8] TPM return code simplifications

(it replaces patch 10 of the previous series). Both series are also available at: https://github.com/KevinOConnor/seabios/tree/testing I'm not currently planning any other TPM changes after these. -Kevin Kevin O'Connor (8): tpm: Don't return a status from external bios measurement functions tpm

Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >Perform the hardware probe once during setup instead of checking if > >the probe has been completed on each measurement event. > > > >Don't probe for har

Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

On Wed, Dec 30, 2015 at 07:06:58PM -0500, Kevin O'Connor wrote: > On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote: > > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > > >+static u8 TPM_working; > > > > Should this not also have VARLOW to not be ROM'ed

Re: [SeaBIOS] [PATCH 2/8] tpm: No need to check the return status of measurements

On Wed, Dec 30, 2015 at 07:09:54PM -0500, Stefan Berger wrote: > On 12/30/2015 02:31 PM, Kevin O'Connor wrote: > >The low-level measurement functions already handle error conditions, > >there is no need to check for the errors in the high level measurement > >functions. > &

[SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 122 -- 1 file changed, 34 insertions(+), 88 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 55e38a9..9448984 100644 --- a/src/tcgbios.c +++ b/src/tcg

[SeaBIOS] [PATCH 09/10] tpm: Eliminate response buffer parameter from build_and_send_cmd()

There are no longer any callers that use the response buffer. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 45 + 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 5

[SeaBIOS] [PATCH 07/10] tpm: Simplify tcpa probe

-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 141 +++--- 1 file changed, 45 insertions(+), 96 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 3207478..8f9f321 100644 --- a/src/tcgbios.c +++ b/src/tcg

[SeaBIOS] [PATCH 00/10] Some TPM simplifications

simplify the parameters to the build_and_send_cmd() function. The remaining patches are mostly just code reorg. I have only compile tested these changes. -Kevin Kevin O'Connor (10): tpm: Add banner separating the TCG bios interface code from TCG menu code tpm: Avoid macro expansion of tpm

[SeaBIOS] [PATCH 06/10] tpm: Rework TPM interface shutdown support

ns to fail.) Centralize the checking for the interface shutdown condition in tpm_interrupt_handler32(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 63 +++ 1 file changed, 11 insertions(+), 52 deletions(-)

[SeaBIOS] [PATCH 05/10] tpm: Move TPM hardware functions from tcgbios.c to hw/tpm_drivers.c

Move the hardware interface functions (tpmhw_probe, tpmhw_transmit, and tpmhw_set_timeouts) to tpm_drivers.c code, and only export those functions. This simplifies the hardware interface. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/tpm_drivers.

[SeaBIOS] [PATCH 10/10] tpm: Return returnCode from build_and_send_cmd() instead of via pointer param

case that the command transmission fails, return -1 to signal the failure to the callers. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 139 -- 1 file changed, 66 insertions(+), 73 deletions(-) diff --git

[SeaBIOS] [PATCH 01/10] tpm: Add banner separating the TCG bios interface code from TCG menu code

Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/tcgbios.c b/src/tcgbios.c index 7b93d87..4f78c42 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -1187,6 +1187,11 @@ tpm_interrupt_handler32(struct bregs

[SeaBIOS] [PATCH 04/10] tpm: Add wrapper function tpm_set_timeouts()

Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 9448984..b680c1d 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -155,6 +155,13 @@ transmit(u8 locty,

[SeaBIOS] [PATCH 02/10] tpm: Avoid macro expansion of tpm request / response structs

Avoid macros and use regular struct definitions for the request and response headers. This simplifies the header and reduces the need for casts in the code. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/std/tcg.h | 40 +--- src/tcgbios.

Re: [SeaBIOS] [PATCH 10/10] tpm: Return returnCode from build_and_send_cmd() instead of via pointer param

On Tue, Dec 29, 2015 at 10:11:14PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >The callers interested in the return status of build_and_send_cmd() > >are only interested in the command return code status (returnCode) and > >not the

Re: [SeaBIOS] [PATCH 08/10] tpm: Introduce tpm_get_capability() helper function

On Tue, Dec 29, 2015 at 09:09:09PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >+static int > >+tpm_get_capability(u32 cap, u32 subcap, struct tpm_rsp_header *rsp, u32 > >rsize) > >+{ > >+struct tpm_req_getcap trgc = { &

Re: [SeaBIOS] SeaBIOS crashes on CBFS without legacy header

On Mon, Dec 28, 2015 at 04:09:22PM -0800, Alex G. wrote: > > Are you suggesting that an (unsigned) cast should be added? I doubt > > it would matter. > > I'm suggesting to not rely on (0 - 4) to produce 0xfffc. The > (unsigned) cast does not solve the C issue of writing a negative value >

Re: [SeaBIOS] [PATCH] nmi: Don't try to switch onto extra stack in NMI handler

On Wed, Dec 23, 2015 at 03:47:26PM -0500, Kevin O'Connor wrote: > The NMI could occur when already on the extra stack, which would > corrupt it. Always use the current stack on an NMI to avoid this. FYI, I committed this change. -Kevin ___ S

Re: [SeaBIOS] [PATCH 1/2] scsi: Do not call printf() from scsi_is_ready()

On Wed, Dec 23, 2015 at 03:48:48PM -0500, Kevin O'Connor wrote: > The scsi_is_ready() function may be called from a thread, and it is > not valid to call printf() from a thread. Convert printf() to > dprintf() to avoid this possibility. > > This does mean that cdrom detection (

Re: [SeaBIOS] SeaBIOS crashes on CBFS without legacy header

On Thu, Dec 24, 2015 at 03:45:03PM -0800, Alex Gagniuc wrote: > When SeaBIOS is run on an FMAP-based CBFS (AKA, without a CBFS master > header, it crashes). The problem is in coreboot_cbfs_init. A > disassembly with -Mintel shows the following: > > : >... >7: 8b 35 fc ff ff ff

Re: [SeaBIOS] [PATCH] build: fix typo in buildversion.py

On Mon, Dec 28, 2015 at 01:50:41PM +0100, Roger Pau Monne wrote: > Fixes the following build error: > > Building ld scripts > Traceback (most recent call last): > File "./scripts/buildversion.py", line 134, in > main() > File "./scripts/buildversion.py", line 114, in main >

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

On Wed, Dec 23, 2015 at 07:02:37PM +0100, Tobias Diedrich wrote: > Wcall16 with invalid stack: eax=dfbf3e62 edx=0 func=0x000f9563 esp=dfbf3e50 > > .text._farcall16 0x9563 : { *(.text._farcall16) } > Can you include the full log? It looks like the code tried to call a 16bit function while in a

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

On Wed, Dec 23, 2015 at 07:13:27PM +0100, Tobias Diedrich wrote: > Wcall16 with invalid stack: eax=dfbf3e62 edx=0 func=0x000f9563 esp=dfbf3e50 > ret=0x000f2304 > > │.text:000F22C8 sub_F22C8 proc near ; CODE XREF: > sub_F2309+2Cvp > ▒ > │.text:000F22C8

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

On Wed, Dec 23, 2015 at 07:39:56PM +0100, Tobias Diedrich wrote: > On Wed, Dec 23, 2015 at 7:10 PM, Kevin O'Connor <ke...@koconnor.net> wrote: > > > On Wed, Dec 23, 2015 at 07:02:37PM +0100, Tobias Diedrich wrote: > > > Wcall16 with invalid stack: eax=dfbf3e62 ed

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Wed, Dec 23, 2015 at 06:40:12AM +, Gonglei (Arei) wrote: > > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > On Tue, Dec 22, 2015 at 02:14:12AM +, Gonglei (Arei) wrote: > > > Sorry, it doesn't work. What's worse is we cannot stop SeaBIOS s

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

On Wed, Dec 23, 2015 at 12:51:30PM -0500, Kevin O'Connor wrote: > On Wed, Dec 23, 2015 at 04:27:55PM +0100, Tobias Diedrich wrote: > > And with verbose logging (level 8). > > > > [...] > > Wcall16 with invalid stack > > Strange. Can you report the output with

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

On Wed, Dec 23, 2015 at 04:27:55PM +0100, Tobias Diedrich wrote: > And with verbose logging (level 8). > > [...] > Wcall16 with invalid stack Strange. Can you report the output with the patch below? -Kevin --- a/src/stacks.c +++ b/src/stacks.c @@ -274,7 +274,8 @@ call16(u32 eax, u32 edx,

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

On Wed, Dec 23, 2015 at 09:14:44PM +0100, Tobias Diedrich wrote: > Final diff attached (without the src/stacks.c change, with %d->%u change > for sector counts). > Bootlog with debug_level 1 attached. Great! Patches sent - if no further comments I'll commit in a few days. -Kevin

[SeaBIOS] [PATCH 1/2] scsi: Do not call printf() from scsi_is_ready()

, the extra medium detection time is unlikely to be large anyway. Reported-by: Tobias Diedrich <tobiasdiedr...@gmail.com> Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/blockcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/blockcmd.c b/src/h

Re: [SeaBIOS] [PATCH] xhci: Wait for port enable even for USB3 devices

On Sun, Dec 20, 2015 at 03:10:48PM -0500, Kevin O'Connor wrote: > Some USB3 controllers (and/or devices) need additional time after the > device is detected to place the port in an enabled state. Wait for > the controller to report enabled before proceeding. This fixes > sev

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Wed, Dec 23, 2015 at 09:27:25PM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > SeaBIOS is careful to always disable IRQs while running C code to > > prevent this issue, but disabling normal IRQs does not disable NMIs. > > So, I believe this issue is specific

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Tue, Dec 22, 2015 at 03:15:26AM +, Xulei (Stone) wrote: > Hi, Kevin, > Can you tell how to reset/reboot this VM, if it goes to the handle_hwpic1() > on its booting procedure? I mean, usually, SeaBIOS would not go to > handle_hwpic routine. But in my test case, SeaBIOS calls handle_hwpic

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

On Mon, Dec 21, 2015 at 11:50:07AM -0500, Stefan Berger wrote: > "Kevin O'Connor" <ke...@koconnor.net> wrote on 12/17/2015 05:22:56 PM: > > > > > On Mon, Nov 30, 2015 at 11:32:05AM +, Wim Vervoorn wrote: > > > Hello, > > > > > >

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

On Mon, Dec 21, 2015 at 06:44:18PM +, edward wandasiewicz wrote: > With 47-g977a7d4, we get > > 1. YES - we get no duplicate of the Philips, and get just one of each > appear in the boot list, Mushkin & Philips > > 2. NO - we sometimes get just the Mushkin only - no Philips detected - > with

Re: [SeaBIOS] 5 basic features provided by CSM, which SeaBIOS does provide?

On Mon, Dec 21, 2015 at 12:57:33PM +, Stojsavljevic, Zoran wrote: > Hello Kevin, > > All Good with setting CSM ON for legacy support. You need it for 16 bit > BIOSes, and for legacy OSes, such as WIN XP or WIN 7 and derivatives. > > Here is the question I am wondering: What if I decide to

<    4   5   6   7   8   9   10   11   12   13   >