On 01/30/2011 04:33 PM, Gleb Natapov wrote:
>
> In theory a guest could check whether RTC alarm reboot is supported,
> if not it keeps awake, if it is it can set the alarm to sleep. So
> if seabios lies it could break that guest.
>
Theoretically possible.
> However that's an unlikely scen
On 02/02/2011 09:42 AM, Gleb Natapov wrote:
> The alternative would be to get it via fw_cfg.
>
How will this help? We want to lie that we support RTC wakeup without
actually supporting it.
We would be able to lie or say the truth at will. Distros that care
about WHQL/SVVP can turn the lie o
On 02/23/2011 08:04 PM, Aurelien Jarno wrote:
Actually that's the reason why i386 doesn't use softfloat, as all the
trigonometric use libm, and the bridge between softfloat and libm is not
working correctly (plenty of type abuse).
Besides, I doubt softfloat would want bug-compatible trig functi
On 05/19/2011 10:01 AM, Ian Campbell wrote:
We had a bit of a brainstorm yesterday and someone suggested that
perhaps qemu could deal with it when it sees the I/O ports for the
emulated device unplug get hit.
You could imagine doing the unplug even under an OS that uses INT 13h.
PV drivers als
On 09/23/2011 06:28 AM, Kevin O'Connor wrote:
I'd like to make the next release of SeaBIOS. I plan to make the
version number be v1.6.3 (instead of v0.6.3).
There are a few ACPI patches pending. However, I think it would be
best to tag the current code, and then add the ACPI code on top of it.
On 09/27/2011 03:04 PM, Michael S. Tsirkin wrote:
>There was a concern raised with
> two-pass PCI initialization that I need to follow up on before
> tagging.
The isa bridge? I thought that got fixed ...
Daniel Berrange reported a regression with virtio-9p.
Paolo
__
The mode page is marked as obsolete, but QEMU can provide the information.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 33 -
src/blockcmd.h | 29 +
2 files changed, 61 insertions(+), 1 deletions(-)
diff --git a/src
Finally move the INQUIRY/TEST UNIT READY/READ CAPACITY sequence to
generic code, so that virtio-scsi will be able to use it.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 53 +
src/blockcmd.h |1 +
src/usb-msc.c | 49
This fixes a timing problem when doing two consecutive USB_DIR_OUT
sends. It is visible for example when writing to a USB device.
Signed-off-by: Paolo Bonzini
---
src/usb-uhci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/usb-uhci.c b/src/usb-uhci.c
index
Avoid ambiguity when virtio-scsi will be introduced.
Signed-off-by: Paolo Bonzini
---
src/Kconfig |4 ++--
src/block.c |6 +++---
src/disk.c |4 ++--
src/disk.h | 18 +-
src/virtio-blk.c |4 ++--
src/virtio-blk.h |2 +-
6 files changed
.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c | 32 +++-
1 files changed, 15 insertions(+), 17 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index c8b9fbe..a0b79a5 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
@@ -153,7 +153,6 @@ process_usb_op(struct
Writes only require building the CDB and some care with the direction
in the USB packet. TEST UNIT READY is special because it has no data,
so it cannot have any residue either.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 12
src/blockcmd.h |1 +
src/usb-msc.c | 21
g
now the whole batch for review.
Paolo Bonzini (16):
cdrom: use TEST UNIT READY to detect ready medium
usb-msc: add usb_msc_send
usb-uhci: wait tick after sending data
usb-msc: support WRITE and TEST UNIT READY
usb-msc: move READ CAPACITY to usb_msc_init, fix off-by-one
usb-msc: pass
Another common bit that can be made generic.
Signed-off-by: Paolo Bonzini
---
src/virtio-blk.c | 17 +
src/virtio-pci.c | 22 +-
src/virtio-pci.h |2 +-
3 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/src/virtio-blk.c b/src/virtio
virtio-scsi will need to write to config space, add a helper to do that.
Signed-off-by: Paolo Bonzini
---
src/virtio-pci.h | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/src/virtio-pci.h b/src/virtio-pci.h
index e1d972d..ea40edf 100644
--- a/src/virtio-pci.h
This makes it a bit nicer to later introduce writes.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c | 19 ++-
1 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index 13ef93e..07a7ea2 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
They are generic SCSI constants, rename them as such.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.h |3 +++
src/usb-msc.c |2 +-
src/usb-msc.h |3 ---
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/blockcmd.h b/src/blockcmd.h
index 84ab659..6923e4c 100644
Put together the common parts of all virtio device initialization.
Signed-off-by: Paolo Bonzini
---
src/virtio-blk.c |9 +
src/virtio-pci.c | 11 +++
src/virtio-pci.h |1 +
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/src/virtio-blk.c b/src/virtio
virtio-scsi is a simple HBA that talks to the host via a single
vring. The implementation looks like a hybrid of usb-msc and
virtio-blk.
Signed-off-by: Paolo Bonzini
---
Makefile |2 +-
src/Kconfig |6 ++
src/block.c |3 +-
src/blockcmd.c|3 +
src
The READ CAPACITY output is not used except for some debugging messages.
In the future, we will use this code for USB sticks too, but those
already send READ CAPACITY. To avoid code duplication, switch to TEST
UNIT READY for this task.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 12
The two functions do not need anymore a disk_op_s.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index a0b79a5..b76bb57 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
Add the wait loop that CDs are already using to usb-msc. USB drives
might also report NOT READY at startup.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 44
src/blockcmd.h |2 ++
src/cdrom.c| 48
virtio-scsi's low-level dispatch code is exactly the same as USB's,
since in the end both are actually SCSI HBAs. Move it to common code.
Signed-off-by: Paolo Bonzini
---
src/block.c | 28 +---
src/usb-msc.c | 28
2 files c
On 11/16/2011 02:46 AM, Kevin O'Connor wrote:
Question on patch 4 - can you elaborate on why waittick is needed?
What happens is that if you do two consecutive OUT sends, the second
fails ~90% of the time with a timeout in wait_td. I initially wanted to
add the wait in usb-msc.c and only for
.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c | 30 ++
1 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index 65b33a2..818710c 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
@@ -153,7 +153,6 @@ process_usb_op(struct disk_op_s
This makes it a bit nicer to later introduce writes.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c | 19 ++-
1 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index f74b8ec..5e38b01 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
er happens in the IN direction).
To fix this, re-enable TDs whenever the host controller completes the
pending ones. Also, at the end of the processing do not wait for each
single TD to become inactive, but simply wait for the host controller
to invalidate the element link.
Signed-off-by: P
Put together the common parts of all virtio device initialization.
Signed-off-by: Paolo Bonzini
---
src/virtio-blk.c |9 +
src/virtio-pci.c | 11 +++
src/virtio-pci.h |1 +
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/src/virtio-blk.c b/src/virtio
This lets the usb-msc driver send TEST UNIT READY commands.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index 13ef93e..f74b8ec 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
@@ -79,9
The two functions do not need anymore a disk_op_s.
Signed-off-by: Paolo Bonzini
---
src/usb-msc.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index 818710c..5539f6a 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
Add the wait loop that CDs are already using to usb-msc in the HD
case, to cope with a NOT READY or UNIT ATTENTION condition.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 44
src/blockcmd.h |2 ++
src/cdrom.c| 48
The mode page is marked as obsolete, but QEMU can provide the information.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 32
src/blockcmd.h | 29 +
2 files changed, 61 insertions(+), 0 deletions(-)
diff --git a/src/blockcmd.c
.
Signed-off-by: Paolo Bonzini
---
src/usb-uhci.c | 65 ++-
1 files changed, 31 insertions(+), 34 deletions(-)
diff --git a/src/usb-uhci.c b/src/usb-uhci.c
index f3680d3..5957567 100644
--- a/src/usb-uhci.c
+++ b/src/usb-uhci.c
@@ -212,26
Writes only require building the CDB and some care with the direction
in the USB packet.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 12
src/blockcmd.h |1 +
src/usb-msc.c | 15 ---
3 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/src
few extra interface bits that are common
to both virtio-scsi and virtio-blk.
The two parts are logically separate but they have a small conflict,
so I'm sending them together.
Paolo Bonzini (16):
cdrom: use TEST UNIT READY to detect ready medium
usb-uhci: reorganize wait_qh into wait_pipe
usb
The READ CAPACITY output is not used except for some debugging messages.
In the future, we will use this code for USB sticks too, but those
already send READ CAPACITY. To avoid code duplication, switch to TEST
UNIT READY for this task.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 12
Finally move the INQUIRY/TEST UNIT READY/READ CAPACITY sequence to
generic code, so that virtio-scsi will be able to use it.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 57
src/blockcmd.h |1 +
src/usb-msc.c | 51
Another common bit that can be made generic.
Signed-off-by: Paolo Bonzini
---
src/virtio-blk.c | 11 ---
src/virtio-pci.c | 22 +-
src/virtio-pci.h |2 +-
3 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/src/virtio-blk.c b/src/virtio-blk.c
virtio-scsi's low-level dispatch code is exactly the same as USB's,
since in the end both are actually SCSI HBAs. Move it to common code.
Signed-off-by: Paolo Bonzini
---
src/block.c | 28 +---
src/usb-msc.c | 28
2 files c
Avoid ambiguity when virtio-scsi will be introduced.
Signed-off-by: Paolo Bonzini
---
src/Kconfig |4 ++--
src/block.c |6 +++---
src/disk.c |4 ++--
src/disk.h | 18 +-
src/virtio-blk.c |4 ++--
src/virtio-blk.h |2 +-
6 files changed
They are generic SCSI constants, rename them as such.
Signed-off-by: Paolo Bonzini
---
src/blockcmd.h |3 +++
src/usb-msc.c |2 +-
src/usb-msc.h |3 ---
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/blockcmd.h b/src/blockcmd.h
index 84ab659..6923e4c 100644
On 11/17/2011 05:53 AM, Kevin O'Connor wrote:
Interesting. Good catch! If I understand this correctly, the issue
occurs because all TDs being complete doesn't guarentee that the QH is
complete, and thus the next transfer races with the controller on the
QH update.
Yep.
Can't the code just u
.
4) Add a variable timeout argument, since bulk transfers might take more
than 500 ms.
Signed-off-by: Paolo Bonzini
---
v1->v2: prepare for passing a bigger timeout
src/usb-uhci.c | 64 ++-
1 files changed, 30 insertions(+),
This lets the usb-msc driver send TEST UNIT READY commands.
Signed-off-by: Paolo Bonzini
---
The new hunk was present in the previous submission but
was in patch 06/16. It didn't break bisectability, but
was not nice.
src/usb-msc.c | 11 +++
1 files ch
Finally move the INQUIRY/TEST UNIT READY/READ CAPACITY sequence to
generic code, so that virtio-scsi will be able to use it.
Signed-off-by: Paolo Bonzini
---
v1->v2: move scsi_is_ready call correctly from usb-msc to blockcmd
src/blockcmd.c |
er happens in the IN direction).
To fix this, at the end of the processing do not wait for each single
TD to become inactive, but for the host controller to invalidate the
element link (which implies it's done with all TDs).
Signed-off-by: Paolo Bonzini
---
Thanks Kevin for suggestin
On 10/16/2011 12:45 PM, Sven Schnelle wrote:
+/* some SCSI commands have the LUN in CDB */
+if (data[0] == 0x08 || // READ(6)
+ data[0] == 0x12 || // INQUIRY
+ data[0] == 0x15 || // MODE SELECT(6)
+ data[0] == 0x55 || // MODE SELECT(10)
+ data[0] == 0x1A || // MODE
On 10/16/2011 11:57 AM, Sven Schnelle wrote:
Some USB Mass storage devices need this command before being
accessed. request sense in error case and retry the last command
in case it says 'Unit attention'
If it says UNIT ATTENTION you do not need to do START STOP UNIT.
Sending REQUEST SENSE wil
er.
src/usb-ehci.c | 70 ---
src/usb-uhci.c |7 +++--
2 files changed, 35 insertions(+), 42 deletions(-)
I tested this with QEMU and it seems to work there.
Reviewed-by: Paolo Bonzini
Paolo
___
SeaBIOS mailing l
The fw paths for USB devices that SeaBIOS computes are off-by-one,
because QEMU builds those paths with a numbering that starts from one
(see usb_fill_port and usb_hub_initfn in QEMU). Fix that so that
the numbering agrees.
---
src/boot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions
On 11/18/2011 03:59 PM, Paolo Bonzini wrote:
The fw paths for USB devices that SeaBIOS computes are off-by-one,
because QEMU builds those paths with a numbering that starts from one
(see usb_fill_port and usb_hub_initfn in QEMU). Fix that so that
the numbering agrees.
Signed-off-by: Paolo
On 11/19/2011 01:49 AM, Kevin O'Connor wrote:
Paolo in your last series, you indicated there were some LUN changes -
but I didn't see it in the patches. Do you have something planned
here also?
I didn't have LUN changes, in fact I had a FIXME that the virtio-scsi
driver was scanning just LUN0
On 11/18/2011 04:36 PM, Paolo Bonzini wrote:
On 11/18/2011 03:59 PM, Paolo Bonzini wrote:
The fw paths for USB devices that SeaBIOS computes are off-by-one,
because QEMU builds those paths with a numbering that starts from one
(see usb_fill_port and usb_hub_initfn in QEMU). Fix that so that
the
On 12/16/2011 03:15 PM, Julian Pidancet wrote:
The real-mode emulator that Windows 7 uses to execute the vga bios rom
becomes very confused when the code tries to dereference the stack
pointer instead of using the frame pointer, leading to corruption of
parameters passed on the stack from one fun
Unlike basic_access, extended_access does not check for a zero
sector count. However, this is a problem because for example
it would be interpreted as 256 when processing an ATA request.
Signed-off-by: Paolo Bonzini
---
src/disk.c | 14 +-
1 files changed, 9 insertions(+), 5
On 02/11/2012 03:38 PM, Kevin O'Connor wrote:
> Unlike basic_access, extended_access does not check for a zero
> sector count. However, this is a problem because for example
> it would be interpreted as 256 when processing an ATA request.
Thanks. The EDD spec seems to imply that sending a zero
On 02/14/2012 02:35 PM, Kevin O'Connor wrote:
On Thu, Feb 09, 2012 at 01:22:23PM +0100, Fred . wrote:
Lots of stuff have been happening lately (namely VGA and VBE related
stuff). Also some fixes.
Perhaps it is time for a new release soon?
It's a good question. I have some USB fixes I want to
On 02/15/2012 11:21 AM, Fred . wrote:
> How about 286 though?
SeaBIOS has 32-bit code, so no way.
Paolo
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
virtio-scsi is a simple HBA that talks to the host via a single
vring. The implementation looks like a hybrid of usb-msc and
virtio-blk.
Signed-off-by: Paolo Bonzini
---
Makefile |2 +-
src/Kconfig |6 ++
src/block.c |3 +-
src/blockcmd.c|5 +-
src
On 02/15/2012 02:46 AM, Kevin O'Connor wrote:
>> > I would like to get virtio-scsi included. It would make sense to
>> > have the QEMU side applied first, but perhaps it's not paramount now
>> > that Rusty included the specification.
> I don't recall seeing the seabios changes for virtio-scsi.
I
On 02/15/2012 02:35 PM, Laszlo Ersek wrote:
> I've reviewed this patch for RHEL-6 and now diffed the RHEL-6 patch with
> this one. I think the differences are all OK (source file list, handling
> of the VIRTIO_SCSI config option, bdf vs. pci, contents of struct
> virtio_scsi_config).
Hm, no. I in
virtio-scsi is a simple HBA that talks to the host via a single
vring. The implementation looks like a hybrid of usb-msc and
virtio-blk.
Signed-off-by: Paolo Bonzini
---
Makefile |2 +-
src/Kconfig |6 ++
src/block.c |3 +-
src/blockcmd.c|5 +-
src
On 02/16/2012 02:36 PM, Kevin O'Connor wrote:
> On Wed, Feb 15, 2012 at 03:42:22PM +0100, Paolo Bonzini wrote:
>> virtio-scsi is a simple HBA that talks to the host via a single
>> vring. The implementation looks like a hybrid of usb-msc and
>> virtio-blk.
>
> Th
On 02/19/2012 05:34 PM, Kevin O'Connor wrote:
> The scsi_init_drive() function has enough information to directly
> register the drive there, so do the registration there. This
> simplifies the calling code.
>
> Signed-off-by: Kevin O'Connor
> ---
>
> Paulo - this patch will conflict with your
virtio-scsi is a simple HBA that talks to the host via a single
vring. The implementation looks like a hybrid of usb-msc and
virtio-blk.
Reviewed-by: Laszlo Ersek
Signed-off-by: Paolo Bonzini
---
On top of your patch "Register drives directly in scsi_init_drive()".
Il 02/03/2012 01:34, Dave Frodin ha scritto:
> On a related topic, I have a copy of the "Indispensable PC Hardware" book
> that lists the return values for the mode page 4 request. It list the cyc/head
> data as follows...
> offset value
> ==
>2 cyl(msb)
>3 cyl
>
Il 04/03/2012 19:49, Kevin O'Connor ha scritto:
>> > The sg_modes command has a "-a" option to dump out all of the supported
>> > page codes
>> >- it reports that none of the thumbdrives (tested 9) support page code
>> > = 4
>> >- it reports that most of the thumbdrives (tested 9) suppor
in
Signed-off-by: Paolo Bonzini
---
src/blockcmd.c | 36 +++-
1 files changed, 23 insertions(+), 13 deletions(-)
diff --git a/src/blockcmd.c b/src/blockcmd.c
index 2769573..b4a1e37 100644
--- a/src/blockcmd.c
+++ b/src/blockcmd.c
@@ -139,19 +139,29 @@ scsi_
Il 06/03/2012 00:50, Kevin O'Connor ha scritto:
> I plan to backport the 5 fixes below to the stable branch and tag it
> as v1.6.3.2. Let me know if there are any concerns or additional
> changes needed.
The MODE SENSE change would be a good candidate.
Paolo
___
Il 09/03/2012 08:35, Gerd Hoffmann ha scritto:
> Is INT13h supported for legacy OS and to boot? Future? But as far as
> I saw implemented in seabios, right?
Yes, Kevin (O' Connor, not Wolf) integrated the patch this week. It
will also be in Fedora 17.
> What BIOS translation is used? Buslogic? L
Il 14/03/2012 21:53, Peter Stuge ha scritto:
> > 2. Will this break anything else?
>
> I'm sure it will break plenty of other non-compliant USB MSC devices
> which also do not ignore the direction bit and require it to be 1.
Linux FWIW always sets it to 0 for DMA_NONE SCSI commands. So I think
m = (len ? 3 : 2) - out_num;
>> @@ -89,7 +90,7 @@ virtio_scsi_cmd_data(struct disk_op_s *op, void *cdbcmd,
>> u16 blocksize)
>> return virtio_scsi_cmd(GET_GLOBAL(vlun->ioaddr),
>> GET_GLOBAL(vlun->vq), op, cdbcmd,
>>
Il 15/03/2012 02:31, Kevin O'Connor ha scritto:
> On Wed, Mar 14, 2012 at 01:02:39PM -0600, Steve Goodrich wrote:
>> I've been working with coreboot and SeaBIOS lately to try to get a platform
>> working, including having boot capability using an SD-to-USB adapter. I got
>> stuck on this last part
Il 18/03/2012 22:47, fel...@gmx.net ha scritto:
> Hi,
>
> I'm a new subscriber to seabios.org. Not much exp. with mailing lists
> nor C++, so feel free to straighten me out as necessary. I found out an
> issue: Booting from CD-ROM doesn't work anymore, though related make
> options have been set.
boot failures.
Signed-off-by: Paolo Bonzini
---
src/ata.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/ata.c b/src/ata.c
index 76e4f20..c37691a 100644
--- a/src/ata.c
+++ b/src/ata.c
@@ -645,13 +645,15 @@ atapi_cmd_data(struct disk_op_s *op, void *cdbcmd
Il 16/04/2012 02:44, Peter Stuge ha scritto:
> Michael Tokarev wrote:
>> Maybe this Standard VGA should be named something like Old VGA?
>
> IBM PC/XT/AT 128K VGA ?
FWIW, the first VGA was for the PS/2 and had 256K of VRAM. "IBM VGA" is
probably good enough...
Paolo
__
Il 16/05/2012 15:46, Gleb Natapov ha scritto:
> I saw that, but I don't get why doing it this way instead of defining
> the object in AML and patching it? I can define Name(S4VL, 0x2) and path
> 0x2 to whatever QEMU wants me to use, or I can patch Package directly
> like I did.
>
Can we build an
Il 16/05/2012 18:40, Gleb Natapov ha scritto:
> On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote:
>> Il 16/05/2012 15:46, Gleb Natapov ha scritto:
>>> I saw that, but I don't get why doing it this way instead of defining
>>> the object in AML and pat
Il 17/05/2012 02:24, Kevin O'Connor ha scritto:
>> > Can we build an SSDT that includes the contents of fw_cfg (e.g.
>> > FW_CFG_SIGNATURE at offset 0, FW_CFG_UUID at offset 4, FW_CFG_NOGRAPHIC
>> > at offset 16... the entry <-> offset mapping and the defaults would be
>> > part of SeaBIOS), and th
Il 12/06/2012 03:32, Kevin O'Connor ha scritto:
> -int bootprio_find_usb(struct usbdevice_s *usbdev)
> +int bootprio_find_usb(struct usbdevice_s *usbdev, int lun)
> {
> if (!CONFIG_BOOTORDER)
> return -1;
> -// Find usb - for example: /pci@i0cf8/usb@1,2/hub@1/network@0/ethernet@0
Il 13/06/2012 01:14, Kevin O'Connor ha scritto:
> On Tue, Jun 12, 2012 at 06:21:39PM +0200, Paolo Bonzini wrote:
>> Il 12/06/2012 03:32, Kevin O'Connor ha scritto:
>>> -int bootprio_find_usb(struct usbdevice_s *usbdev)
>>> +int bootprio_find_us
Il 13/06/2012 08:33, Kevin O'Connor ha scritto:
>> > It's also something like /pci@i0cf8/usb@1,2/*@1, but * could be usb-host
>> > or usb-redir (the latter for USB-over-IP).
> Well, if we know it will always start with "usb-" (instead of
> "storage") then we can limit to that. See the incremental
Il 26/07/2012 17:38, Alexey Korolev ha scritto:
> If I add any DBUG call in acpi-dst it will cause BSOD on win2003 (win2008
> works fine)
You can try inlining it (in practice this means adding simple
Store(0x41, DBGB) here and there).
Paolo
___
SeaBIO
need to keep a separate SSDT for PCI hotplug.
Everything can reside in the same table.
Signed-off-by: Paolo Bonzini
---
On top of this: do we actually need the S01/S02 devices? Their
address is a duplicate of \_SB.PCI0.ISA and \_SB.PCI0.VGA's; and
they are never removab
simple rename and patch 4 fixes a bug in acpi_extract. Patches 5 and
6 finally do the movement.
Paolo Bonzini (6):
acpi: move PCNT to DSDT
acpi: move s3/s4/s5 to build_ssdt
acpi: rename Processor SSDT constants
acpi_extract: fix off-by-one
acpi_extract: detect DeviceOp
acpi: build PCI
-off-by: Paolo Bonzini
---
Makefile |2 +-
src/acpi.c | 41 -
src/ssdt-pcihp.dsl | 36
src/ssdt-susp.dsl | 41 +
4 files changed, 66 insertions(+), 54
The DeviceOp AML opcode has more or less the same structure as ProcessorOp,
except that there is no processor ID.
Signed-off-by: Paolo Bonzini
---
tools/acpi_extract.py | 28
1 file changed, 28 insertions(+)
diff --git a/tools/acpi_extract.py b/tools
The PCNT method does not need any patching, so it can stay in the DSDT
if we add an External declaration. The AML code size does not change.
Signed-off-by: Paolo Bonzini
---
src/acpi-dsdt.dsl | 39 +--
src/ssdt-pcihp.dsl | 37
Single-byte package length values do use bits 4-5, and this will
happen with the PCI hotplug devices. pkglenbytes has not yet been
decremented, so multi-byte values are detected with pkglenbytes > 1.
Signed-off-by: Paolo Bonzini
---
tools/acpi_extract.py |2 +-
1 file changed, 1 insert
A simple rename, to prepare for the later introduction of similar constants
for PCI slots.
Signed-off-by: Paolo Bonzini
---
src/acpi.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/src/acpi.c b/src/acpi.c
index e6a7ef5..906237c 100644
--- a
Il 31/07/2012 15:33, Corey Minyard ha scritto:
>>
> I considered that, but that seems like a more brittle interface. New
> fields may need to be added in the future. I'll look at the file
> interface, but I would think it would be best to have something that
> could be added to.
Just format it as
Il 01/08/2012 02:46, Kevin O'Connor ha scritto:
> I agree with this patch series. A couple of questions - why not
> create the Notify stuff dynamically (as CPU hotplug does) instead of
> moving it back to the dsdt?
For no particular reason, except that I aimed at 100% correspondence
with the exis
Il 01/08/2012 10:05, Igor Mammedov ha scritto:
> On 07/31/2012 11:52 AM, Paolo Bonzini wrote:
>> Move the _S3/_S4/_S5 packages out of ssdt-pcihp.dsl and into a separate
>> file. Correspondingly, move the patching from build_pcihp to build_ssdt.
>> Place this part at the
Single-byte package length values do use bits 4-5, and this will
happen with the PCI hotplug devices. pkglenbytes has not yet been
decremented, so multi-byte values are detected with pkglenbytes > 1.
Signed-off-by: Paolo Bonzini
---
tools/acpi_extract.py |2 +-
1 file changed, 1 insert
The DeviceOp AML opcode has more or less the same structure as ProcessorOp,
except that there is no processor ID.
Signed-off-by: Paolo Bonzini
---
tools/acpi_extract.py | 28
1 file changed, 28 insertions(+)
diff --git a/tools/acpi_extract.py b/tools
rename and patch 3 fixes a bug in acpi_extract. Patches 4 to
6 finally do the movement.
v1->v2: document computation of length (patch 1, Igor)
build PCNT dynamically (Kevin)
Paolo Bonzini (6):
acpi: move s3/s4/s5 to build_ssdt
acpi: rename Processor SSDT constants
acpi_extract: fix
We already build the CPU notification method in src/acpi.c, and we can
reuse most of the code for PCI hotplug.
Signed-off-by: Paolo Bonzini
---
src/acpi.c | 68 +++-
src/ssdt-pcihp.dsl | 37
2 files changed
need to keep a separate SSDT for PCI hotplug.
Everything can reside in the same table.
Signed-off-by: Paolo Bonzini
---
src/acpi.c | 83
src/ssdt-pcihp.dsl | 51
2 files changed, 50 insertions(+), 84
A simple rename, to prepare for the later introduction of similar constants
for PCI slots.
Signed-off-by: Paolo Bonzini
---
src/acpi.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/src/acpi.c b/src/acpi.c
index 641781f..7d22d22 100644
--- a
-off-by: Paolo Bonzini
---
Makefile |2 +-
src/acpi.c | 50 --
src/ssdt-pcihp.dsl | 36
src/ssdt-susp.dsl | 41 +
4 files changed, 70 insertions
1 - 100 of 403 matches
Mail list logo
