Re: Code Review Request for translatability bugs

2011-03-24 Thread Weijun Wang
Another thing, maybe you can also combine the JarSigner TSA-unavailable warnings like you did for KeyTool integrity-not-checked ones? I've attached a diff and you can directly apply it at jdk level. Thanks Max On 03/25/2011 09:35 AM, Weijun Wang wrote: AuthResources.java: ===

hg: jdk7/tl/jdk: 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build

2011-03-24 Thread weijun . wang
Changeset: 4a64eefbfd7a Author:weijun Date: 2011-03-25 11:58 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a64eefbfd7a 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build Reviewed-by: mullan ! src/share/classes/java/util/jar/JarVerifier.jav

Re: Code Review Request for translatability bugs

2011-03-24 Thread Weijun Wang
AuthResources.java: === 1. {"expected.", "expected "}, -{".read.end.of.file", ", read end of file"}, +{"expected.expect.read.end.of.file.", +"expected {0}, read end of file"}, The "expected." is now useless. At least I grep thru all jdk/s

hg: jdk7/tl/jdk: 7029680: fix test/sun/misc/Version/Version.java build parsing

2011-03-24 Thread stuart . marks
Changeset: f326a018fd3f Author:smarks Date: 2011-03-24 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f326a018fd3f 7029680: fix test/sun/misc/Version/Version.java build parsing Reviewed-by: ohair ! test/sun/misc/Version/Version.java

hg: jdk7/tl/langtools: 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies

2011-03-24 Thread jonathan . gibbons
Changeset: 83260b3305ac Author:jjg Date: 2011-03-24 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/83260b3305ac 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies Reviewed-by: mcimadamore ! src/share/classes/

Re: Code Review Request for translatability bugs

2011-03-24 Thread Brad Wetmore
On 3/24/2011 6:49 AM, Sean Mullan wrote: Max, Freda, Could you please review this webrev for a batch of translatability bugs: http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ KeyTool.java: = Looks good. Only minor comments about line length, which is kind of

hg: jdk7/tl/jdk: 7029823: (ann) test/java/lang/annotation/package-info.java no longer compiles

2011-03-24 Thread jim . holmlund
Changeset: 632a96f5752d Author:jjh Date: 2011-03-24 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/632a96f5752d 7029823: (ann) test/java/lang/annotation/package-info.java no longer compiles Summary: Use @Deprecated instead of @java.lang.annotation.Documented Reviewed-by

Re: code review request: 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build

2011-03-24 Thread Sean Mullan
Hi Max, The fix looks good. I suggest you also remove this comment in ManifestEntryVerifier: 198 // MANIFEST.MF should not be skipped. It has signers. and add a similar comment to JarSigner.doneWithMeta. Also, in the test, I think you should add a try/finally clause and close the 2 I

Code Review Request for translatability bugs

2011-03-24 Thread Sean Mullan
Max, Freda, Could you please review this webrev for a batch of translatability bugs: http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ Thanks, Sean

code review request: 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build

2011-03-24 Thread Weijun Wang
Hi Sean This is a regression made by my former treat-MANIFEST.MF-as-signed code change. Webrev here: http://cr.openjdk.java.net/~weijun/7023056/webrev.00/ For the reason, see the evaluation below. === *Description* Running a Maven build of

hg: jdk7/tl/jdk: 7030174: Jarsigner should accept TSACert with an HTTPS id-ad-timeStamping SIA

2011-03-24 Thread weijun . wang
Changeset: 65e7fddf517f Author:weijun Date: 2011-03-24 16:16 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/65e7fddf517f 7030174: Jarsigner should accept TSACert with an HTTPS id-ad-timeStamping SIA Reviewed-by: xuelei ! src/share/classes/sun/security/tools/TimestampedSigner