Re: Code Review Request for translatability bugs

2011-03-28 Thread Weijun Wang
Looks fine. Thanks Max On 03/29/2011 02:46 AM, Sean Mullan wrote: I have addressed all of your comments and posted another webrev at: http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.01/ Max, can you check that I integrated your patch ok? Thanks, Sean On 3/25/11 12:15 AM, We

hg: jdk7/tl/jdk: 7031166: (pack200) tools/pack200/CommandLineTests.java fail with testsdk on RO filesystem

2011-03-28 Thread kumar . x . srinivasan
Changeset: a42760dae179 Author:ksrini Date: 2011-03-28 13:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a42760dae179 7031166: (pack200) tools/pack200/CommandLineTests.java fail with testsdk on RO filesystem Reviewed-by: alanb ! test/tools/pack200/CommandLineTests.java !

Re: Code Review Request for translatability bugs

2011-03-28 Thread Sean Mullan
I have addressed all of your comments and posted another webrev at: http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.01/ Max, can you check that I integrated your patch ok? Thanks, Sean On 3/25/11 12:15 AM, Weijun Wang wrote: Another thing, maybe you can also combine the JarSig

Re: Exception while processing 'no-addresses' flag in KrbApReq.java

2011-03-28 Thread Weijun Wang
Sorry for the late reply. I suppose your client side program is not in Java? Because in JDK a service ticker's addresses field is always null. Thanks Max On 03/25/2011 07:53 PM, Szabolcs Pota wrote: [+ adding back security-dev] Hi Henry, Thank you for your reply. My answers are below.

hg: jdk7/tl/jdk: 2 new changesets

2011-03-28 Thread weijun . wang
Changeset: 86ace035d04d Author:weijun Date: 2011-03-28 18:04 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86ace035d04d 7019384: Realm.getRealmsList returns realms list in wrong (reverse) order Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/Realm.java ! test/sun/

Re: code review request: 7031536: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports

2011-03-28 Thread Xuelei Fan
On 3/28/2011 4:23 PM, Weijun Wang wrote: Hi Xuelei This webrev includes 2 kinds of code changes: http://cr.openjdk.java.net/~weijun/7031536/webrev.00/ 1. HttpNegotiateServer: now servers open on port 0. Looks fine. 2. Others: I add run/othervm for all tests in jgss and krb5 that call Sy

code review request: 7031536: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports

2011-03-28 Thread Weijun Wang
Hi Xuelei This webrev includes 2 kinds of code changes: http://cr.openjdk.java.net/~weijun/7031536/webrev.00/ 1. HttpNegotiateServer: now servers open on port 0. 2. Others: I add run/othervm for all tests in jgss and krb5 that call System.setProperty Thanks Max Original Messag