I have addressed all of your comments and posted another webrev at:
http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.01/
Max, can you check that I integrated your patch ok?
Thanks,
Sean
On 3/25/11 12:15 AM, Weijun Wang wrote:
Another thing, maybe you can also combine the JarSigner TSA-unavailable warnings
like you did for KeyTool integrity-not-checked ones?
I've attached a diff and you can directly apply it at jdk level.
Thanks
Max
On 03/25/2011 09:35 AM, Weijun Wang wrote:
AuthResources.java:
===================
1.
{"expected.", "expected "},
- {".read.end.of.file", ", read end of file"},
+ {"expected.expect.read.end.of.file.",
+ "expected {0}, read end of file"},
The "expected." is now useless. At least I grep thru all jdk/src files
and see none of it.
2.
- {"provided.null.name", "provided null name"}
This one is still used in:
./com/sun/security/auth/SolarisPrincipal.java:79
./com/sun/security/auth/SolarisNumericGroupPrincipal.java:92
./com/sun/security/auth/SolarisNumericUserPrincipal.java:83
./com/sun/security/auth/X500Principal.java:90
There is an entry with the same name in Resources.java, but
unfortunately our codes use both.
Thanks
Max
On 03/25/2011 04:15 AM, Brad Wetmore wrote:
On 3/24/2011 6:49 AM, Sean Mullan wrote:
Max, Freda,
Could you please review this webrev for a batch of translatability bugs:
http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/
KeyTool.java:
=============
Looks good. Only minor comments about line length, which is kind of hard
in this environment.
Brad
