Re: code review request: 7122169: TcpTimeout fail for various reasons

2011-12-20 Thread Weijun Wang
On 12/20/2011 10:05 PM, Alan Bateman wrote: On 20/12/2011 10:22, Weijun Wang wrote: Hi Alan Do you have time to look at this fix? http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ I study the test again and find out it's not the same as those BadKdc* tests, where the port number must ob

Code review request for 6839886, 7033170, 7084025

2011-12-20 Thread Valerie (Yu-Ching) Peng
Sean, Can you please help reviewing the fixes for 6839886: Array overrun in pkcs11 http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/ (fixed to use the correct value; no regression test due to @reg-hard) 7033170: Cipher.getMaxAllowedKeyLength(String) throws NoSuchAlgorithmException http:

Re: code review request: 7122169: TcpTimeout fail for various reasons

2011-12-20 Thread Alan Bateman
On 20/12/2011 10:22, Weijun Wang wrote: Hi Alan Do you have time to look at this fix? http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ I study the test again and find out it's not the same as those BadKdc* tests, where the port number must obey a pattern (n-th server on n). So there

Re: code review request: 7122169: TcpTimeout fail for various reasons

2011-12-20 Thread Weijun Wang
On 12/20/2011 08:36 PM, Chris Hegarty wrote: I'm not familiar with the Windows VM time issue, but the other changes look fine to me. In Windows VM, if you call Thread.sleep(1) and measure the time elapsed, the difference of System.nanoTime() is precise always, but the difference of Syst

Re: code review request: 7122169: TcpTimeout fail for various reasons

2011-12-20 Thread Chris Hegarty
I'm not familiar with the Windows VM time issue, but the other changes look fine to me. -Chris. On 12/20/11 10:22 AM, Weijun Wang wrote: Hi Alan Do you have time to look at this fix? http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ I study the test again and find out it's not the same

code review request: 7122169: TcpTimeout fail for various reasons

2011-12-20 Thread Weijun Wang
Hi Alan Do you have time to look at this fix? http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ I study the test again and find out it's not the same as those BadKdc* tests, where the port number must obey a pattern (n-th server on n). So there is no need to assign one before the serv

Re: code review request (Re: Some Mac JDK codes not open sourced (was Fwd: Re: Kerberos codes in Apple's Java))

2011-12-20 Thread Weijun Wang
None of you review my code changes. :( Here is the final version: http://cr.openjdk.java.net/~weijun/7123107/webrev.00/ I guess with the current bylaw. The jdk7u-osx belongs to the "jdk7u - JDK 7 Updates Project" and skovatch is not listed there. So I guess I will be the committer and you w