Re: Code review request: 7102106: TEST_BUG: sun/security/util/Oid/S11N.sh should be modified

2012-07-16 Thread Sean Mullan
Hi Max, The fix looks fine, but I am wondering if it is appropriate to require that everyone that runs these tests must have these older JREs installed or mounted for this test to pass. It seems like it would have been better to pre-generate the serialized data and add them as test data

Re: Code review request: 7102106: TEST_BUG: sun/security/util/Oid/S11N.sh should be modified

2012-07-16 Thread Wei-jun Wang
The interop test is bi-directional. The new JDK needs to understand what older JDKs produce, vice versa. Therefore it must launch those older JDKs. Thanks Max 在 Jul 16, 2012,10:22 PM,Sean Mullan sean.mul...@oracle.com 写道: Hi Max, The fix looks fine, but I am wondering if it is

Re: code review request for 6880559: Enable PKCS11 64-bit windows builds

2012-07-16 Thread Vincent Ryan
FYI I've updated this changeset to include the NSS sources, in compliance with the requirements of MPL 2.0 license. http://cr.openjdk.java.net/~vinnie/6880559/webrev.01/ On 07/12/12 09:48 PM, Vincent Ryan wrote: Please review this changeset to (finally) add support for PKCS11 on 64-bit

Request for Review: AESCrypt.init performance JDK change

2012-07-16 Thread Deneau, Tom
Please review the following webrev which improves performance for the com/sun/crypto/provider when the algorithm is AES for some kinds of Cipher usage patterns. http://cr.openjdk.java.net/~tdeneau/aescrypt-init-performance/webrev.01/ I do not have a bug number for this change but a description

hg: jdk8/tl/jdk: 6880559: Enable PKCS11 64-bit windows builds

2012-07-16 Thread vincent . x . ryan
Changeset: 5cee646eaaa7 Author:vinnie Date: 2012-07-16 22:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5cee646eaaa7 6880559: Enable PKCS11 64-bit windows builds Reviewed-by: valeriep ! THIRD_PARTY_README ! make/sun/security/Makefile !

hg: jdk8/tl: 6880559: Enable PKCS11 64-bit windows builds

2012-07-16 Thread vincent . x . ryan
Changeset: 0562a97bd601 Author:vinnie Date: 2012-07-16 22:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0562a97bd601 6880559: Enable PKCS11 64-bit windows builds Reviewed-by: valeriep ! THIRD_PARTY_README

hg: jdk8/tl/jdk: 7177045: Rework the TestProviderLeak.java regression test, it is too fragile to low memory errors.

2012-07-16 Thread kurchi . subhra . hazra
Changeset: 1469be7182b4 Author:khazra Date: 2012-07-16 16:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1469be7182b4 7177045: Rework the TestProviderLeak.java regression test, it is too fragile to low memory errors. Summary: Increase Xmx to 20 MB and add mechanisms to

Re: Code review request: 7102106: TEST_BUG: sun/security/util/Oid/S11N.sh should be modified

2012-07-16 Thread Weijun Wang
Also, the test skips an old JDK (and shows a warning) if its path does not exist. What this bug wants to solve is that the path exists but is too slow. -Max On 07/16/2012 10:43 PM, Wei-jun Wang wrote: The interop test is bi-directional. The new JDK needs to understand what older JDKs

Re: Code review request: 7183203: ShortRSAKeynnn.sh tests intermittent failure

2012-07-16 Thread Xuelei Fan
Looks fine to me. Thanks for addressing this issue. Xuelei On 7/16/2012 6:23 PM, Weijun Wang wrote: Hi Xuelei The ShortRSAKeyNNN tests have failed several times recently, showing strange error messages like Signature not verified or Cannot create key for the keytool command. It might be

hg: jdk8/tl/jdk: 7183203: ShortRSAKeynnn.sh tests intermittent failure

2012-07-16 Thread weijun . wang
Changeset: e2d265c9b592 Author:weijun Date: 2012-07-17 11:28 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2d265c9b592 7183203: ShortRSAKeynnn.sh tests intermittent failure Reviewed-by: xuelei ! test/sun/security/mscapi/ShortRSAKey1024.sh -

Re: OpenJDK krb5 ignore /etc/krb5.conf?

2012-07-16 Thread Weijun Wang
Ping again. On 07/05/2012 04:34 PM, Weijun Wang wrote: Hi Scott On Mac since Lion, sun.security.krb5.Config tries to locate the config info in this order: 1. java.security.krb5.conf system property 2. ${jre}/lib/security/krb5.conf 3. SCDynamicStoreConfig The main difference from other

hg: jdk8/tl: 6 new changesets

2012-07-16 Thread lana . steuck
Changeset: f6a685069274 Author:katleman Date: 2012-07-05 18:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f6a685069274 Added tag jdk8-b46 for changeset 27fa766a2298 ! .hgtags Changeset: c8d320b48626 Author:erikj Date: 2012-07-03 16:11 -0700 URL:

hg: jdk8/tl/corba: 3 new changesets

2012-07-16 Thread lana . steuck
Changeset: cb31b67326bc Author:katleman Date: 2012-07-05 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/cb31b67326bc Added tag jdk8-b46 for changeset 30141e598d72 ! .hgtags Changeset: 21e46ea21c6a Author:lana Date: 2012-07-10 11:40 -0700 URL:

hg: jdk8/tl/hotspot: 2 new changesets

2012-07-16 Thread lana . steuck
Changeset: 0c7bb1f4f9c8 Author:katleman Date: 2012-07-05 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0c7bb1f4f9c8 Added tag jdk8-b46 for changeset cf37a594c38d ! .hgtags Changeset: fa0c28fabbb1 Author:katleman Date: 2012-07-12 16:48 -0700 URL:

hg: jdk8/tl/jaxws: 2 new changesets

2012-07-16 Thread lana . steuck
Changeset: fe6a060afc40 Author:katleman Date: 2012-07-05 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fe6a060afc40 Added tag jdk8-b46 for changeset ae368a83c240 ! .hgtags Changeset: efb564de8a8e Author:katleman Date: 2012-07-12 16:48 -0700 URL:

hg: jdk8/tl/jaxp: 4 new changesets

2012-07-16 Thread lana . steuck
Changeset: bf27b857c6ee Author:katleman Date: 2012-07-05 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bf27b857c6ee Added tag jdk8-b46 for changeset 300f45e99064 ! .hgtags Changeset: 404521944ac9 Author:lana Date: 2012-07-10 11:40 -0700 URL:

hg: jdk8/tl/langtools: 5 new changesets

2012-07-16 Thread lana . steuck
Changeset: c7e62fc9df92 Author:katleman Date: 2012-07-05 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7e62fc9df92 Added tag jdk8-b46 for changeset 4ca599497172 ! .hgtags Changeset: 01d9911df25d Author:erikj Date: 2012-06-28 14:59 -0700 URL:

hg: jdk8/tl/jdk: 22 new changesets

2012-07-16 Thread lana . steuck
Changeset: 9d1738ef61d6 Author:katleman Date: 2012-07-05 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d1738ef61d6 Added tag jdk8-b46 for changeset 8d2ed9d58453 ! .hgtags Changeset: 9881db0a65bf Author:prr Date: 2012-06-26 09:38 -0700 URL: