Re: RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception

2012-07-25 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 7/26/2012 9:49 AM, Seán Coffey wrote: > Requesting a review for the following issue : > > http://bugs.sun.com/view_bug.do?bug_id=7179879 > > The SSLSocketImpl doesn't appear to handle the case where a connect > operation is cancelled > before an SSL session h

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-25 Thread Weijun Wang
On 07/26/2012 08:21 AM, Valerie (Yu-Ching) Peng wrote: Hi, Max or Xuelei, Either of you have cycles to review the following 3 perf related fixes? 7107613: scalability bloker in javax.crypto.CryptoPermissions 7107616: scalability bloker in javax.crypto.JceSecurityManager 7185471: Avoid key expa

RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception

2012-07-25 Thread Seán Coffey
Requesting a review for the following issue : http://bugs.sun.com/view_bug.do?bug_id=7179879 The SSLSocketImpl doesn't appear to handle the case where a connect operation is cancelled before an SSL session has begun (we simple ignore such a case) Fix would be to honour the close call which in

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-25 Thread Weijun Wang
On 07/26/2012 08:21 AM, Valerie (Yu-Ching) Peng wrote: Hi, Max or Xuelei, Either of you have cycles to review the following 3 perf related fixes? 7107613: scalability bloker in javax.crypto.CryptoPermissions 7107616: scalability bloker in javax.crypto.JceSecurityManager 7185471: Avoid key expa

Code Review Request for 7107613, 7107616, 7185471

2012-07-25 Thread Valerie (Yu-Ching) Peng
Hi, Max or Xuelei, Either of you have cycles to review the following 3 perf related fixes? 7107613: scalability bloker in javax.crypto.CryptoPermissions 7107616: scalability bloker in javax.crypto.JceSecurityManager 7185471: Avoid key expansion when AES cipher is re-init w/ the same key Webrevs

hg: jdk8/tl/jdk: 7186829: test/sun/nio/cs/OLD/JIS_X_0201_OLD.java failed in jdk8 TL nightly build

2012-07-25 Thread xueming . shen
Changeset: 42eac77355d2 Author:sherman Date: 2012-07-25 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42eac77355d2 7186829: test/sun/nio/cs/OLD/JIS_X_0201_OLD.java failed in jdk8 TL nightly build Summary: fixed the test case Reviewed-by: alanb ! test/sun/nio/cs/OLD/JI

Re: 6995421: Eliminate the static dependency to sun.security.ec.ECKeyFactory

2012-07-25 Thread Vincent Ryan
Hello Stephen, Your changes look good. Thanks. On 20/07/2012 21:18, Stephen Flores wrote: Please review the following webrev: http://cr.openjdk.java.net/~sflores/6995421/ for bug: 6995421 Eliminate the static dependency to sun.security.ec.ECKeyFactory Description of the problem: sun.securi