On 07/26/2012 08:21 AM, Valerie (Yu-Ching) Peng wrote:
Hi, Max or Xuelei,
Either of you have cycles to review the following 3 perf related fixes?
7107613: scalability bloker in javax.crypto.CryptoPermissions
7107616: scalability bloker in javax.crypto.JceSecurityManager
7185471: Avoid key expansion when AES cipher is re-init w/ the same key
Webrevs are at:
http://cr.openjdk.java.net/~valeriep/7107613
http://cr.openjdk.java.net/~valeriep/7107616
Already sent in another mail.
http://cr.openjdk.java.net/~valeriep/7185471
Looks fine, but I want to confirm if my understanding is correct:
1. I guess ROUNDS being 10, 12 and 14 means keysize of of 128, 192, 256?
2. The original code has confused ROUNDS and key length a little, so the
line
57 /** (ROUNDS-1) * 4 */
was incorrect. You've fixed this and used different names for them.
Thanks
Max
The changes are for JDK 8. May be backported to 7u later if necessary,
Thanks,
Valerie
