Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-26 Thread Valerie (Yu-Ching) Peng
Thanks Max and Xuelei for your reviews! I've updated the webrevs for 7107613, and 7107616: http://cr.openjdk.java.net/~valeriep/7107613/webrev.01 http://cr.openjdk.java.net/~valeriep/7107616/webrev.01 Please let me know if you have more comments. Thanks, Valerie On 07/25/12 17:21, Valerie (Yu-C

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-26 Thread Weijun Wang
On 07/27/2012 07:26 AM, Valerie (Yu-Ching) Peng wrote: Max, So, do you want me to check the exemptCache again, i.e. what line 122- 125 do, inside the synchronized block before calling getAppPermissions(...)? Yes, that should work. If you do believe this is a very rare case and you don't mind

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-26 Thread Valerie (Yu-Ching) Peng
Max, So, do you want me to check the exemptCache again, i.e. what line 122- 125 do, inside the synchronized block before calling getAppPermissions(...)? Thanks, Valerie On 07/25/12 18:29, Weijun Wang wrote: http://cr.openjdk.java.net/~valeriep/7107616 You have 122 CryptoPermissio

hg: jdk8/tl/jdk: 7179879: SSLSocket connect times out instead of throwing socket closed exception

2012-07-26 Thread sean . coffey
Changeset: 35fec642fd32 Author:coffeys Date: 2012-07-26 22:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35fec642fd32 7179879: SSLSocket connect times out instead of throwing socket closed exception Reviewed-by: xuelei, chegar ! src/share/classes/sun/security/ssl/SSLSock

Re: RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception

2012-07-26 Thread Chris Hegarty
On 25/07/12 19:37, Xuelei Fan wrote: Looks fine to me. Looks fine to me too. -Chris. Thanks, Xuelei On 7/26/2012 9:49 AM, Seán Coffey wrote: Requesting a review for the following issue : http://bugs.sun.com/view_bug.do?bug_id=7179879 The SSLSocketImpl doesn't appear to handle the case w

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-26 Thread Valerie (Yu-Ching) Peng
Xuelei, I pondered with the "preserving the Vector 'perms' and add a new transient ConcurrentHashMap 'permsMap'" idea in one of my previous changes. Felt that it's cleaner to only have one assuming no lengthy/complicated custom serialization methods needed. I will look at the ObjectOutputStream

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-26 Thread Valerie (Yu-Ching) Peng
Yes, I find the definition for rounds seems inconsistent in the original code, so I did a little clean up. Valerie On 07/25/12 19:15, Weijun Wang wrote: http://cr.openjdk.java.net/~valeriep/7185471 Looks fine, but I want to confirm if my understanding is correct: 1. I guess ROUNDS being 10

Re: Code Review Request for 7107613, 7107616, 7185471

2012-07-26 Thread Xuelei Fan
On 7/26/2012 8:21 AM, Valerie (Yu-Ching) Peng wrote: > Hi, Max or Xuelei, > > Either of you have cycles to review the following 3 perf related fixes? > 7107613: scalability bloker in javax.crypto.CryptoPermissions > 7107616: scalability bloker in javax.crypto.JceSecurityManager > 7185471: Avoid ke

hg: jdk8/tl/jdk: 7187051: ShortRSAKeynnn.sh tests should do cleanup before start test

2012-07-26 Thread weijun . wang
Changeset: f267302093d4 Author:weijun Date: 2012-07-26 20:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f267302093d4 7187051: ShortRSAKeynnn.sh tests should do cleanup before start test Reviewed-by: xuelei ! test/sun/security/mscapi/ShortRSAKey1024.sh

Re: Code review request: 7187051: ShortRSAKeynnn.sh tests should do cleanup before start tes

2012-07-26 Thread Xuelei Fan
Looks fine to me. Xuelei On 7/26/2012 4:41 PM, Weijun Wang wrote: > Hi Xuelei > > You might have to review the fix to the same test again > > http://cr.openjdk.java.net/~weijun/7187051/webrev.00/ > > This time it's > > 7187051 ShortRSAKeynnn.sh tests should do cleanup before start test >

Code review request: 7187051: ShortRSAKeynnn.sh tests should do cleanup before start tes

2012-07-26 Thread Weijun Wang
Hi Xuelei You might have to review the fix to the same test again http://cr.openjdk.java.net/~weijun/7187051/webrev.00/ This time it's 7187051 ShortRSAKeynnn.sh tests should do cleanup before start test Thanks Max On 07/17/2012 10:35 AM, Xuelei Fan wrote: Looks fine to me. Thanks for a