Re: Code Review Request, JDK-8001751, Javadoc warnings in JSSE code

It's a P2 bug, ping again. Thanks, Xuelei On 11/23/2012 5:15 PM, Xuelei Fan wrote: > Hi, > > Please review the java doc warning cleanup in javax.net.sll. > > webrev: http://cr.openjdk.java.net./~xuelei/8001751/webrev.00/ > > Thanks, > Xuelei >

Warning cleanup in package sun.security.ssl (3/n)

This patch removes unused constructs related to the TLS 1.2 signature_algorithm extension. See the brief discussion here: (I need a sponsor for this patch.) -- Florian Weimer / Red Hat Product Security Team # HG c

Re: TLS 1.2 signature_algorithms extension processing

On 11/23/2012 02:58 PM, Xuelei Fan wrote: On 11/23/2012 1:59 AM, Florian Weimer wrote: Is the extension actually being processed? Yes. sun.security.ssl.HandshakeHash.setCertificateVerifyAlg(String) appears to have no effect because the cvAlg member is never read. Need to clean up the code.

Re: TLS 1.2 signature_algorithms extension processing

On 11/23/2012 1:59 AM, Florian Weimer wrote: > Is the extension actually being processed? Yes. > sun.security.ssl.HandshakeHash.setCertificateVerifyAlg(String) appears > to have no effect because the cvAlg member is never read. > Need to clean up the code. We do not actually use the above code t

Re: Warning cleanup in package sun.security.ssl (2/n)

On 11/23/2012 01:52 PM, Xuelei Fan wrote: Great catches! Looks fine to me. Please let me know if you want a sponsor to push the patch. Yes, please. -- Florian Weimer / Red Hat Product Security Team

Re: Warning cleanup in package sun.security.ssl (2/n)

Great catches! Looks fine to me. Please let me know if you want a sponsor to push the patch. Thanks, Xuelei On 11/23/2012 2:05 AM, Florian Weimer wrote: > This patch removes unused variables. If any of them have to stay > because they are accessed through reflection (possibly by legacy code),

Re: Warning cleanup in package sun.security.ssl (1/n)

Thanks for the cleanup, which makes the code style of JSSE looks pretty. Please let me know if you want a sponsor to push the patch. Thanks, Xuelei On 11/23/2012 1:41 AM, Florian Weimer wrote: > The attached patch adds missing @Override annotations and removes > unnecessary imports. >

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

On 11/23/2012 8:01 PM, Florian Weimer wrote: > On 11/23/2012 12:54 PM, Xuelei Fan wrote: >> On 11/23/2012 7:22 PM, Florian Weimer wrote: >>> On 11/22/2012 04:00 PM, Xuelei Fan wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 1

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

On 11/23/2012 12:54 PM, Xuelei Fan wrote: On 11/23/2012 7:22 PM, Florian Weimer wrote: On 11/22/2012 04:00 PM, Xuelei Fan wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ J

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

On 11/23/2012 7:22 PM, Florian Weimer wrote: > On 11/22/2012 04:00 PM, Xuelei Fan wrote: >> Hi Valerie, Max or Brad, >> >> Can you review the update for JDK-7030966? It is the JSSE part of JEP >> 115. >> >> webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ >> JEP 115: http://openjdk.ja

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

On 11/22/2012 04:00 PM, Xuelei Fan wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ JEP 115: http://openjdk.java.net/jeps/115 In the update, I have not remove the debug sync

Code Review Request, JDK-8001751, Javadoc warnings in JSSE code

Hi, Please review the java doc warning cleanup in javax.net.sll. webrev: http://cr.openjdk.java.net./~xuelei/8001751/webrev.00/ Thanks, Xuelei