hg: jdk8/tl/langtools: 8008768: Using {@inheritDoc} in simple tag defined via -tag fails

2013-05-03 Thread jonathan . gibbons
Changeset: d918b63a5509 Author:jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibb...@oracle.com, mike.dui...@ora

Re: Code review request: 8010192: Enable native JGSS provider on Mac

2013-05-03 Thread Weijun Wang
On 5/4/13 2:23 AM, Valerie (Yu-Ching) Peng wrote: So, has this changes been tested against the existing regression tests on Mac? Yes, but there is only one current test using native lib, that is runNameEquals.sh. However, I've experienced it a lot with the ReplayCacheTestProc test in my

hg: jdk8/tl/jdk: 8005922: TEST_BUG: There is no /tmp directory for windows system.

2013-05-03 Thread jason . uh
Changeset: d7f3d5659c46 Author:juh Date: 2013-05-03 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7f3d5659c46 8005922: TEST_BUG: There is no /tmp directory for windows system. Reviewed-by: weijun ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/

hg: jdk8/tl/jdk: 8013528: Provide SharedSecrets access to String(char[], boolean) constructor

2013-05-03 Thread mike . duigou
Changeset: fc156b925259 Author:mduigou Date: 2013-05-03 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc156b925259 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Reviewed-by: martin, alanb, chegar, plevart ! src/share/classes/java/lang/Sy

Re: [8] code review request 4634141: PBE Cipher should have the ability to use params from PBE Key

2013-05-03 Thread Valerie (Yu-Ching) Peng
Vinnie, Hmm, so, are we taking the salt and ic value from the key object for decrypt mode? If yes, then the if-cond checking on line 214 will have to be deferred to a later point where we checked both key and the parameters. Do we check for consistent values of salt and ic if both key and pa

Re: Code review request: 8010192: Enable native JGSS provider on Mac

2013-05-03 Thread Valerie (Yu-Ching) Peng
So, has this changes been tested against the existing regression tests on Mac? After this, is the native JGSS provider get used on Mac for most if not all Kerberos operation or is it still Java Kerberos? Otherwise, changes look ok to me. Valerie On 03/18/13 05:38, Erik Joelsson wrote: The b

hg: jdk8/tl/langtools: 8002387: Improve rendered HTML formatting for {@code}

2013-05-03 Thread jonathan . gibbons
Changeset: 38c4bade0ec1 Author:jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc

hg: jdk8/tl/langtools: 8012728: Normalize @ignore comments on langtools tests

2013-05-03 Thread jonathan . gibbons
Changeset: abd153854f16 Author:jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/

Re: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system.

2013-05-03 Thread Weijun Wang
On 5/3/13 5:52 PM, Jason Uh wrote: Hi Max, On 05/03/2013 12:33 AM, Weijun Wang wrote: Hi Jason One question: why is this necessary in i18n.html and ChangeUI.html: - + Neither test mentions step #. Using a zero-based list was just a stylistic choice, especially as Step 0 would be a case-s

Re: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system.

2013-05-03 Thread Jason Uh
Hi Max, On 05/03/2013 12:33 AM, Weijun Wang wrote: Hi Jason One question: why is this necessary in i18n.html and ChangeUI.html: - + Neither test mentions step #. Using a zero-based list was just a stylistic choice, especially as Step 0 would be a case-specific ("If Windows...") step. I did

Re: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system.

2013-05-03 Thread Weijun Wang
Hi Jason One question: why is this necessary in i18n.html and ChangeUI.html: - + Neither test mentions step #. Otherwise, the changes look fine. Thanks Max On 5/3/13 1:44 PM, Jason Uh wrote: Could I please get a review for this fix for 8005922: Edits to the manual test instructions for so