Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

2013-06-11 Thread David Holmes
Erik, On 7/06/2013 7:50 PM, Erik Joelsson wrote: On 2013-06-07 04:08, David Holmes wrote: On 4/06/2013 10:38 PM, David Holmes wrote: On 4/06/2013 9:21 PM, Erik Joelsson wrote: On 2013-06-04 06:56, David Holmes wrote: I think we should add a (configure time?) check to watch for the

Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

2013-06-11 Thread Erik Joelsson
On 2013-06-11 09:22, David Holmes wrote: Erik, On 7/06/2013 7:50 PM, Erik Joelsson wrote: On 2013-06-07 04:08, David Holmes wrote: On 4/06/2013 10:38 PM, David Holmes wrote: On 4/06/2013 9:21 PM, Erik Joelsson wrote: On 2013-06-04 06:56, David Holmes wrote: I think we should add a

hg: jdk8/tl/nashorn: 7 new changesets

2013-06-11 Thread sundararajan . athijegannathan
Changeset: bab844827181 Author:sundar Date: 2013-06-06 21:41 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bab844827181 8015346: JSON parsing issues with escaped strings, octal, decimal numbers Reviewed-by: hannesw, jlaskey !

Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

2013-06-11 Thread David Holmes
On 11/06/2013 5:47 PM, Erik Joelsson wrote: On 2013-06-11 09:22, David Holmes wrote: Erik, On 7/06/2013 7:50 PM, Erik Joelsson wrote: On 2013-06-07 04:08, David Holmes wrote: On 4/06/2013 10:38 PM, David Holmes wrote: On 4/06/2013 9:21 PM, Erik Joelsson wrote: On 2013-06-04 06:56,

hg: jdk8/tl/langtools: 8008547: javac, warning message: use of ''_'' as an identifier might not be supported in future releases, should be more especific

2013-06-11 Thread vicente . romero
Changeset: bbedff0dc37e Author:vromero Date: 2013-06-11 09:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bbedff0dc37e 8008547: javac, warning message: use of ''_'' as an identifier might not be supported in future releases, should be more especific Reviewed-by:

hg: jdk8/tl/langtools: 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error

2013-06-11 Thread vicente . romero
Changeset: 7fe655cad9b1 Author:vromero Date: 2013-06-11 09:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fe655cad9b1 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error Reviewed-by: jjg !

Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

2013-06-11 Thread Erik Joelsson
On 2013-06-11 10:59, David Holmes wrote: On 11/06/2013 5:47 PM, Erik Joelsson wrote: On 2013-06-11 09:22, David Holmes wrote: Erik, On 7/06/2013 7:50 PM, Erik Joelsson wrote: On 2013-06-07 04:08, David Holmes wrote: On 4/06/2013 10:38 PM, David Holmes wrote: On 4/06/2013 9:21 PM,

hg: jdk8/tl/jdk: 8015895: Int/LongStream.range/rangeClosed; ...

2013-06-11 Thread paul . sandoz
Changeset: 8d627f324c38 Author:psandoz Date: 2013-06-11 12:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d627f324c38 8015895: Int/LongStream.range/rangeClosed 8012986: Right-bias range spliterators for large ranges Reviewed-by: mduigou !

Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-11 Thread Sean Mullan
Why did you need to check for a $HOME/.java.policy file in i18n.sh? Can you explain that? Otherwise, changes look good to me. --Sean On 06/08/2013 09:32 PM, Weijun Wang wrote: Updated at http://cr.openjdk.java.net/~weijun/8015274/webrev.01/ A new bug 8016158 is added. The changes

hg: jdk8/tl/jdk: 3 new changesets

2013-06-11 Thread alan . bateman
Changeset: 669be1677ab7 Author:alanb Date: 2013-06-11 11:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/669be1677ab7 7059085: Retire Thread.stop(Throwable) so that it throws UOE Reviewed-by: dholmes, chegar, forax, darcy, mduigou ! src/share/classes/java/lang/Thread.java

Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-11 Thread Weijun Wang
It is because of 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. Policytool automatically loads ~/.java.policy when it's started. The test expects the file does not exist and a warning should be created. -Max On 6/11/13 9:16 PM, Sean

Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-11 Thread Sean Mullan
On 06/11/2013 09:51 AM, Weijun Wang wrote: It is because of 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. Policytool automatically loads ~/.java.policy when it's started. The test expects the file does not exist and a warning should be

hg: jdk8/tl/jdk: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows

2013-06-11 Thread naoto . sato
Changeset: cadb0ef6e931 Author:naoto Date: 2013-06-11 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cadb0ef6e931 8015960: java/util/Locale/LocaleProviders.java failing again on Windows Reviewed-by: alanb ! test/java/util/Locale/LocaleProviders.java

Code review request for 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode

2013-06-11 Thread Valerie (Yu-Ching) Peng
Xuelei, Can you help review this one-line fix? 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode The webrev is at: http://cr.openjdk.java.net/~valeriep/8012637/webrev.00/ Thanks, Valerie

Code Review Requests for 8012900: CICO ignores AAD in GCM mode

2013-06-11 Thread Valerie (Yu-Ching) Peng
Xuelei, Here is another GCM and CipherInputStream/CipherOutputStream related fix, i.e. for 8012900: CICO ignores AAD in GCM mode The key changes are in CipherCore.java, GalorisCounterMode.java, the rest files only have minor changes. Essentially, when using AES/GCM cipher in decryption mode,

hg: jdk8/tl/jdk: 8016213: Convert j2se NetBeans project to use top-level make targets

2013-06-11 Thread mike . duigou
Changeset: 7f697d028937 Author:mduigou Date: 2013-06-11 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f697d028937 8016213: Convert j2se NetBeans project to use top-level make targets Reviewed-by: chegar ! make/netbeans/common/shared.xml !

Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

2013-06-11 Thread Tim Bell
Erik: Looks good to me. Tim On 2013-06-07 04:08, David Holmes wrote: On 4/06/2013 10:38 PM, David Holmes wrote: On 4/06/2013 9:21 PM, Erik Joelsson wrote: On 2013-06-04 06:56, David Holmes wrote: I think we should add a (configure time?) check to watch for the illegal: BUILD_CRYPTO=no,