Changeset: 8b97fe2b7c98
Author:attila
Date: 2013-07-23 18:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b97fe2b7c98
8021129: Use public lookup again
Reviewed-by: lagergren, sundar
! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/
On 07/24/13 13:53, Anthony Scarpino wrote:
On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote:
263 System.arraycopy(data, 900, data, 0, 100);
264 is.read(data, 0, 900);
Do you really mean to overwrite the data[0..99] that you just copied on
line 263 with l
Changeset: 2fbe77c38802
Author:jjg
Date: 2013-07-24 17:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802
8020556: doclint does not check type variables for @throws
Reviewed-by: mcimadamore
! src/share/classes/com/sun/source/util/DocTrees.java
! src/share/c
Changeset: fd1b5adcfdf0
Author:chegar
Date: 2013-07-24 22:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd1b5adcfdf0
8021261: ProblemList.txt updates (7/2013)
Reviewed-by: alanb, mcimadamore
! test/ProblemList.txt
Changeset: 187a1f2613c0
Author:sjiang
Date: 2013-07-24 15:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/187a1f2613c0
8016221: A unit test should not use a fix port to run a jmx connector
Reviewed-by: jbachorik, dfuchs
!
test/com/sun/management/DiagnosticCommandMBean/Dcm
On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote:
263 System.arraycopy(data, 900, data, 0, 100);
264 is.read(data, 0, 900);
Do you really mean to overwrite the data[0..99] that you just copied on
line 263 with line 264?
Good catch.. I would have though
Changeset: f9224fb49890
Author:juh
Date: 2013-07-24 12:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9224fb49890
8016916: UnstructuredName should support DirectoryString
Reviewed-by: mullan
! src/share/classes/sun/security/pkcs/PKCS9Attribute.java
! src/share/classes/su
DOMUtils.java
=
It might be a little bit better to reuse the node local name checking
with a new private static method.
Otherwise, looks fine.
A minor comment is a very personal preference. I may prefer to return
null instead of throw exception in the new methods of class DOMUtils
Looks good to me.
--Sean
On 07/23/2013 08:35 PM, Jason Uh wrote:
Can I please get a review of this changeset?
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016916
Webrev: http://cr.openjdk.java.net/~juh/8016916/webrev.00/
This change adds PrintableString to the list of ASN.1 tags t
