Looks fine to me.
Just want to make sure, no exception should be thrown if libName is
null, right?
92 if (libName == NULL) {
93 return;
94 }
Xuelei
On 2/14/2014 7:29 AM, Valerie (Yu-Ching) Peng wrote:
>
> Can someone please review the fixes which checks for pending except
AdaptableX509CertSelector.java
==
1. for boolean value checking, I normally use
if (boolean-value) or if (!boolean-value)
2. AdaptableX509CertSelector.match(Certificate)
KID can be used to facilitate the path building. I would suggest
check the SKID and SN at fir
Hi Valerie
Since this is a while loop, it seems for each BuildXXX function, just returning
NULL when an exception is thrown is not enough, because it's not returning to
Java but still inside the native code so another JNI call might run. Do you
think it's OK to add a ExceptionClear call after t
Hi, Max,
Just noticed that there is a JNIEnv->NewObject call on line 378. It
looks like we have to check pending exception there also? This call is
inside a while loop...
Rest looks fine.
Thanks,
Valerie
On 02/13/14 17:49, Wang Weijun wrote:
Updated webrev at
http://cr.openjdk.java.ne
I've updated the webrev, removing the unneeded methods, and also adding
back some rather important pool cleanup code I hadn't noticed the patch
removed.
http://cr.openjdk.java.net/~ascarpino/7107611/webrev.01/
Tony
On 02/13/2014 11:16 AM, Anthony Scarpino wrote:
On 02/11/2014 02:18 PM, Vale
On 2/14/14 7:17 AM, Sean Mullan wrote:
On 02/13/2014 10:04 PM, Jason Uh wrote:
Hi Sean,
Looks good to me, but I'm not an official Reviewer.
I have a couple of questions, though.
Sure.
1. This isn't a part of your change, but shouldn't the comment on line
200 of AdaptableX509CertSelector.ja
On 02/13/2014 10:04 PM, Jason Uh wrote:
Hi Sean,
Looks good to me, but I'm not an official Reviewer.
I have a couple of questions, though.
Sure.
1. This isn't a part of your change, but shouldn't the comment on line
200 of AdaptableX509CertSelector.java read "As for version 3,..." and
not "
On 02/14/2014 01:30 AM, Valerie (Yu-Ching) Peng wrote:
Can someone please review the fixes which checks for pending exceptions
in native code "pcsc.c"?
The fix is straightforward for all except the changes under
Java_sun_security_smartcardio_PCSC_SCardGetStatusChange(...) method
which is somewha
On 14/02/2014 14:01, Wang Weijun wrote:
Unless you put a comment saying this file is a direct copy of another file, the
starting year does not make sense. Of course people really curious about it can
track to this changeset and see its origin.
--Max
Okay, I can just leave it as 2014 so that i
Unless you put a comment saying this file is a direct copy of another file, the
starting year does not make sense. Of course people really curious about it can
track to this changeset and see its origin.
--Max
On Feb 14, 2014, at 21:56, Alan Bateman wrote:
> On 14/02/2014 13:55, Wang Weijun w
On 14/02/2014 13:55, Wang Weijun wrote:
Code change looks good.
Do you really want to use "Copyright (c) 2000, 2014" for the new file?
Thanks Max.
On the copyright date then I wasn't sure. As the code is coming from
TextCallbackHandler (originally 2000 I assume) then I left this as the
star
Code change looks good.
Do you really want to use "Copyright (c) 2000, 2014" for the new file?
Thanks
Max
On Feb 14, 2014, at 20:06, Alan Bateman wrote:
>
> As part of preparing the JDK for modules we need to look at the dependencies
> between Kerberos and JAAS as they are logically separate
As part of preparing the JDK for modules we need to look at the
dependencies between Kerberos and JAAS as they are logically separate
components.
As it stands we have a circular dependency due to the JDK-specific API
to JAAS have API dependencies on Kerberos types, and the JGSS
implementati
13 matches
Mail list logo
