Hi Sean,
After taking another look at the test, I wanted to make one minor
simplification. I've removed the CRL from the test and disabled
revocation because they weren't adding anything important to the test
(which still passes). I'll push if you're okay with that.
If you want to take a loo
Thanks, Sean. I'll push with a set date.
On 3/11/14 2:59 PM, Sean Mullan wrote:
In the test, you should probably call PKIXParameters.setValidity with a
fixed date so that the test won't start failing in 2024. Yes, I know
that's a long time away! Check out other tests to see examples.
Otherwise,
In the test, you should probably call PKIXParameters.setValidity with a
fixed date so that the test won't start failing in 2024. Yes, I know
that's a long time away! Check out other tests to see examples.
Otherwise, fix looks good and you can push without a re-review.
--Sean
On 03/10/2014 08:
OK. Fine to me.
Xuelei
On 3/11/2014 8:27 PM, Wang Weijun wrote:
> I'll add the setter/getter. As for @compile, every test inside krb5/auto
> depends on other files (Context, Action, KDC,...), I don't think it's
> necessary to list them everywhere.
>
> Thanks
> Max
>
>> On Mar 11, 2014, at 19:
I'll add the setter/getter. As for @compile, every test inside krb5/auto
depends on other files (Context, Action, KDC,...), I don't think it's necessary
to list them everywhere.
Thanks
Max
> On Mar 11, 2014, at 19:32, Xuelei Fan wrote:
>
> Do you want to consider Alan's suggestion?
>
> Xuele
Do you want to consider Alan's suggestion?
Xuelei
On 3/11/2014 5:54 PM, Wang Weijun wrote:
> Ping again.
>
> --Max
>
> On Mar 7, 2014, at 15:31, Wang Weijun wrote:
>
>> Hi All
>>
>> Please take a review of
>>
>> http://cr.openjdk.java.net/~weijun/8035963/webrev.00/
>>
>> I've added a ratio
Ping again.
--Max
On Mar 7, 2014, at 15:31, Wang Weijun wrote:
> Hi All
>
> Please take a review of
>
> http://cr.openjdk.java.net/~weijun/8035963/webrev.00/
>
> I've added a ratio variable to these timeout related tests. The ratio is now
> set to 2 (one exception, 3 for BadKdc2). This is
