I'll add the setter/getter. As for @compile, every test inside krb5/auto depends on other files (Context, Action, KDC,...), I don't think it's necessary to list them everywhere.
Thanks Max > On Mar 11, 2014, at 19:32, Xuelei Fan <xuelei....@oracle.com> wrote: > > Do you want to consider Alan's suggestion? > > Xuelei > >> On 3/11/2014 5:54 PM, Wang Weijun wrote: >> Ping again. >> >> --Max >> >>> On Mar 7, 2014, at 15:31, Wang Weijun <weijun.w...@oracle.com> wrote: >>> >>> Hi All >>> >>> Please take a review of >>> >>> http://cr.openjdk.java.net/~weijun/8035963/webrev.00/ >>> >>> I've added a ratio variable to these timeout related tests. The ratio is >>> now set to 2 (one exception, 3 for BadKdc2). This is mainly an experiment >>> to how if they can be more stable when running slower. We will need to do >>> some observation for a period of time. >>> >>> BTW, some of them are placed into ProblemList.txt for solaris-sparc. I >>> remember there was a time when solaris-sparc machines run slow because of a >>> hotspot change. Anyway, they are all liberated at the moment to join the >>> experiment. >>> >>> FYI: The tests run fine on my desktop (Mac Mini) with a ratio of 0.4. >>> >>> JPRT runs fine. The windows-i586 job runs the slowest: >>> >>> -------------------------------------------------- >>> TEST: sun/security/krb5/auto/BadKdc1.java >>> build: 1.594 seconds >>> compile: 1.594 seconds >>> main: 89.433 seconds >>> TEST RESULT: Passed. Execution successful >>> -------------------------------------------------- >>> TEST: sun/security/krb5/auto/BadKdc2.java >>> build: 0.031 seconds >>> compile: 0.031 seconds >>> main: 133.423 seconds >>> TEST RESULT: Passed. Execution successful >>> -------------------------------------------------- >>> TEST: sun/security/krb5/auto/BadKdc3.java >>> build: 0.031 seconds >>> compile: 0.031 seconds >>> main: 73.681 seconds >>> TEST RESULT: Passed. Execution successful >>> -------------------------------------------------- >>> TEST: sun/security/krb5/auto/BadKdc4.java >>> build: 0.031 seconds >>> compile: 0.031 seconds >>> main: 169.443 seconds >>> TEST RESULT: Passed. Execution successful >>> -------------------------------------------------- >>> TEST: sun/security/krb5/auto/MaxRetries.java >>> compile: 0.062 seconds >>> build: 0.0 seconds >>> main: 170.49 seconds >>> TEST RESULT: Passed. Execution successful >>> -------------------------------------------------- >>> TEST: sun/security/krb5/auto/TcpTimeout.java >>> compile: 0.047 seconds >>> build: 0.0 seconds >>> main: 43.192 seconds >>> TEST RESULT: Passed. Execution successful >>> -------------------------------------------------- >>> >>> Thanks >>> Max >
