Please review the fix for the same bug for jdk8u-dev:
http://cr.openjdk.java.net/~weijun/8054817/8u/webrev.00/
We don't have sun.misc.VM.getuid() in jdk8 so the fix is even simpler. The test
is identical though.
Thanks
Max
On Aug 11, 2014, at 22:14, Wang Weijun wrote:
> Please review the f
I don't find it helpful.
Each time I come back reading the codes, I think I understand it a little more.
So maybe I can finally assert the correctness now. But I still think the code
is not easily readable. It will be nice if you reorganize the lines.
--Max
On Aug 20, 2014, at 10:35, zaiyao li
Hi Max,
Sorry for the confuse, how about following chang?
136 boolean enDigest = false;
139 while ((k = dis.read()) != -1) {
144 dos.write(k);
145 if (enDigest == false) { // write data
into baOut when dos and dis
Hi Otávio
I see TABs in the first page of sun_security.diff, too long line in
javax_security.diff.
Also, it's unfortunate that you will need to rename the file names to the new
style with modules. See
http://cr.openjdk.java.net/~chegar/docs/portingScript.html for how to do this.
I can create
Looks fine to me.
--Sean
On 08/13/2014 11:28 AM, Vincent Ryan wrote:
Hello,
Please review this fix to cleanup ECC native code. When returning early from
two methods, some data structures
do not get initialized before use. This fix initializes those structs
explicitly.
Thanks.
Bug: https://
On 08/06/2014 06:25 PM, Amanda Jiang wrote:
Sorry, wrong webrev link, it should be:
http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.01/
Mostly looks good, just a few comments:
* NullPerms
I suggest renaming this test to LimitedDoPrivilegedWithNullPerms
[27-28] Suggest rewording as: "
Am 2014-08-11 um 16:14 schrieb Wang Weijun:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8054817/webrev.00
since we have a new getuid() now for all Unix systems.
It does return -1 on Windows, but I keep the
osname.startsWith("Windows") check to be exactly consistent with the
cur
I am understanding the models now, but still don't grasp the read/write
codes very well. Take the READ example:
136 boolean enDigest = false;
139 while ((k = dis.read()) != -1) {
143 dis.on(enDigest);
144 dos.write(k
I actually don't understand the details in the program. For example,
what does the different ReadModels mean? In each case, what bytes are
actually write into the streams? There are too many on and off and I
don't know what the program is doing.
Thanks
Max
On 08/19/2014 10:05 PM, zaiyao liu w
Hello Simone,
Thanks for re-raising this issue. There are indeed plans to add support for
ALPN in JDK 9 but they’re still at an
early stage so the timing is good.
We would be interested in examining your implementation to explore how it fits
into the current TLS APIs.
Removing the dependency on
Hi Max,
Thanks for review.
testDigestOnOff including following two cases.
* Test digest when set digest function on:
o Set the digest function on both DigestInputStream and
DigestOutputStream
o Perform the update for using all available/possible update
methods, update a
Looks good.
--Sean
On 08/19/2014 04:59 AM, Wang Weijun wrote:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8055373/webrev.00/
Just a typo. I have no idea how I wrote that wrong class name.
Thanks
Max
Fixed, new Webrev:
http://cr.openjdk.java.net/~weijun/8048052/webrev.00/
Thanks!
-Felix
On 8/18/2014 10:17 PM, Wang Weijun wrote:
We don't write "@bug JDK-8048052". Should be "@bug 8048052".
--Max
On Jul 28, 2014, at 17:04, FELIX YANG wrote:
Please review a new test to "setFactory" permiss
Please review the fix at
http://cr.openjdk.java.net/~weijun/8055373/webrev.00/
Just a typo. I have no idea how I wrote that wrong class name.
Thanks
Max
On 08/18/2014 11:59 PM, Anthony Scarpino wrote:
Interesting changes. It's going to take me some time to look over this
as I have a different projects involving GHASH that would cause a
conflict with the code change layout you have posted.
What kind of changes do you plan? Using intrinsics for
15 matches
Mail list logo
