Re: com.sun.crypto.provider.GHASH performance fix

2014-11-24 Thread Florian Weimer
On 11/20/2014 11:37 PM, Tim Whittington wrote: It looks like your GHASH implementation as posted isn’t passing the tests in TestGHASH.java. The existing JDK implementation does, and the Bouncy Castle GHASH produces the same results. I can't reproduce this. I ported the patch to current JDK

Re: RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

2014-11-24 Thread Sean Mullan
On 11/24/2014 03:59 AM, Wang Weijun wrote: On Nov 19, 2014, at 22:10, Sean Mullan wrote: On 11/18/2014 02:47 AM, Wang Weijun wrote: Re-request for code review at http://cr.openjdk.java.net/~weijun/8061253/webrev.01/ * Principal: This should also be included in the @implSpec, is it? You mig

Re: RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

2014-11-24 Thread Wang Weijun
>> On Nov 19, 2014, at 22:10, Sean Mullan wrote: >> >> On 11/18/2014 02:47 AM, Wang Weijun wrote: >>> Re-request for code review at >>> >>> http://cr.openjdk.java.net/~weijun/8061253/webrev.01/ >> >> * Principal: >> >> This should also be included in the @implSpec, is it? You might need anothe