src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java
==
minor comment:
1603 if (!staplingActive) {
1604 fatalSE(Alerts.alert_unexpected_message,
1605 "Unexpected CertificateStatus
Hi Siba
There is one case not covered:
1. sun.security.krb5.principal not set
2. an existing principal set in jaas.conf
In your jaas.conf.principal, a non-existing 1USER principal is used. In
fact, why not add both accounts into the KDC and then check if the login
user is what you expected?
On Jun 29, 2015, at 10:48 AM, Doug Simon wrote:
>
> As I understand it, part of this change is to split intrinsification into one
> method that does the checks that then calls a second method which the VM may
> intrinsify on the assumption all checks have been performed by the first
> method.
Hello,
Please review this fix for 9.
The test uses JAAS authentication over Kerberos. The kerberos5 principal name
can be specified in the configuration entry by using the option principal. The
principal can also be set using the system property
sun.security.krb5.principal. This property
> On Jun 29, 2015, at 12:41 PM, Zoltán Majó wrote:
>
> Hi,
>
>
> On 06/29/2015 11:45 AM, Andrew Haley wrote:
>> Hi,
>>
>> On 29/06/15 10:41, Zoltán Majó wrote:
>>> On 06/27/2015 10:05 AM, Andrew Haley wrote:
On 25/06/15 12:49, Zoltán Majó wrote:
> Problem: There is need to indicate J
> On Jun 29, 2015, at 3:01 PM, Andrew Haley wrote:
>
> On 06/29/2015 01:38 PM, Doug Simon wrote:
>
>> I seems just plain wrong for an intrinsic to not implement the same
>> semantics as the intrinsified method. I would expect an intrinsic to
>> perform all necessary runtime checks and only have
Looks good to me.
--Sean
On 06/26/2015 06:25 PM, Jason Uh wrote:
Please review this fix, which removes the overloaded
sun.security.util.ObjectIdentifier.equals(ObjectIdentifier) method.
webrev: http://cr.openjdk.java.net/~juh/8022444/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8022444
T
Looks good.
--Sean
On 06/26/2015 09:14 PM, Mandy Chung wrote:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8130007/webrev.00/
This patch removes the use of internal API and use Security.getProvider where
appropriate. Valerie and I both contributes to this patch.
Mandy
On 06/29/2015 02:19 PM, David M. Lloyd wrote:
> Out of curiosity, instead of e.g.:
>
>unsigned long *scratch = (unsigned long *)alloca(total_allocation);
>
> Could you not just use e.g.:
>
>unsigned long scratch[longwords * 4];
>
> and avoid alloca altogether?
No. Variable-length arra
On 06/29/2015 02:19 PM, David M. Lloyd wrote:
> Out of curiosity, instead of e.g.:
>
>unsigned long *scratch = (unsigned long *)alloca(total_allocation);
>
> Could you not just use e.g.:
>
>unsigned long scratch[longwords * 4];
>
> and avoid alloca altogether?
No. Variable-length are
On 06/29/2015 04:32 AM, Andrew Haley wrote:
On 29/06/15 09:37, Vladimir Kozlov wrote:
Hi, Andrew
Did you file RFE for this change? 8046943 is JEP.
No; I will do so.
typo? "less" -> "more".
+ * number of ints in the number is less than this value we do not
+ * use the intrinsic.
+
On 06/29/2015 01:38 PM, Doug Simon wrote:
> I seems just plain wrong for an intrinsic to not implement the same
> semantics as the intrinsified method. I would expect an intrinsic to
> perform all necessary runtime checks and only have the compiler omit
> them if it can prove they are unnecessary.
Hi,
On 06/29/2015 11:45 AM, Andrew Haley wrote:
Hi,
On 29/06/15 10:41, Zoltán Majó wrote:
On 06/27/2015 10:05 AM, Andrew Haley wrote:
On 25/06/15 12:49, Zoltán Majó wrote:
Problem: There is need to indicate Java methods that are potentially
intrinsified by JVM.
It's a great idea but is it
Hi,
On 29/06/15 10:41, Zoltán Majó wrote:
>
> On 06/27/2015 10:05 AM, Andrew Haley wrote:
>> On 25/06/15 12:49, Zoltán Majó wrote:
>>> Problem: There is need to indicate Java methods that are potentially
>>> intrinsified by JVM.
>> It's a great idea but is it a good name? HotSpot is not the only
Hi Andrew,
On 06/27/2015 10:05 AM, Andrew Haley wrote:
On 25/06/15 12:49, Zoltán Majó wrote:
Problem: There is need to indicate Java methods that are potentially
intrinsified by JVM.
It's a great idea but is it a good name? HotSpot is not the only Java
VM. Do we expect people from to come a
On 29/06/15 09:37, Vladimir Kozlov wrote:
> Hi, Andrew
>
> Did you file RFE for this change? 8046943 is JEP.
No; I will do so.
> typo? "less" -> "more".
>
> + * number of ints in the number is less than this value we do not
> + * use the intrinsic.
> + */
> +private static fina
On 06/28/2015 09:21 PM, Alan Bateman wrote:
On 26/06/2015 16:43, Zoltán Majó wrote:
I updated the indentation as well.
Here is the updated webrev:
- top: http://cr.openjdk.java.net/~zmajo/8076112/top/webrev.06/
- jdk: http://cr.openjdk.java.net/~zmajo/8076112/jdk/webrev.06/
- hotspot: http:/
Hi James,
thank you for your feedback!
I've implemented the changes you suggested, here is the updated webrev:
- top: http://cr.openjdk.java.net/~zmajo/8076112/top/webrev.07/
- jdk: http://cr.openjdk.java.net/~zmajo/8076112/jdk/webrev.07/
- hotspot: http://cr.openjdk.java.net/~zmajo/8076112/hot
Hi, Andrew
Did you file RFE for this change? 8046943 is JEP.
typo? "less" -> "more".
+ * number of ints in the number is less than this value we do not
+ * use the intrinsic.
+ */
+private static final int MONTGOMERY_INTRINSIC_THRESHOLD = 512;
trailing spaces:
src/java.base/sh
On 06/29/2015 04:02 PM, Alan Bateman wrote:
In any case, the change looks okay to me. Trivially, I think I would use
specific imports rather than changing it a wildcard.
IntelliJ IDEA automatically does this for me:
1. I am typing InitialDirCo and it hints InitialDirContext, I accept it
2.
On 29/06/2015 08:55, Weijun Wang wrote:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8058849/webrev.00
The overridden NamingManager needs to return a Context object whose
getAttributes() method returns hard coded data. Since Context includes
a lot of interface methods, choos
Please review the fix at
http://cr.openjdk.java.net/~weijun/8058849/webrev.00
The overridden NamingManager needs to return a Context object whose
getAttributes() method returns hard coded data. Since Context includes a
lot of interface methods, choosing a non-abstract child and only
overri
22 matches
Mail list logo
