Re: RFR 8056174: New APIs for jar signing

2015-09-21 Thread Weijun Wang
Missing from the webrev, some extra lines needed in modules.xml of the parent repo jdk9/dev: jdk.jartool java.base com.sun.jarsigner + + jdk.security.jarsigner + Thanks Max On 09/22/2015 09:12 AM, Weijun Wang wrote: OK, webrev updated at h

Re: RFR 8056174: New APIs for jar signing

2015-09-21 Thread Weijun Wang
OK, webrev updated at http://cr.openjdk.java.net/~weijun/8056174/webrev.05/ A new method setProperty() is added to JarSigner.Builder (as well as getProperty() in JarSigner) to cover all misc settings. JarSignerX and BuilderX are removed now. Thanks Max On 09/04/2015 04:39 AM, Sean Mullan

Re: RFR for JDK-8048604 : Tests for strong crypto ciphers

2015-09-21 Thread Tristan Yan
Thank you Valerie. Please review the updated version of it http://cr.openjdk.java.net/~tyan/8048604/webrev.02/ Cheers Tristan > On Sep 16, 2015, at 3:24 PM, Valerie Peng > wrote: > > > Can u please make sure

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-09-21 Thread Amanda Jiang
Thank you Max, Could you please sponsor this ? Thanks, Amanda On 9/21/15, 12:01 AM, Wang Weijun wrote: > Great. Everything looks fine now. > > Thanks > Max > >> 在 2015年9月21日,12:54,Amanda Jiang 写道: >> >> Hi Max, >> >> Thanks for reviewing this webrev. I have updated test cases by your comments >

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-09-21 Thread Wang Weijun
Great. Everything looks fine now. Thanks Max > 在 2015年9月21日,12:54,Amanda Jiang 写道: > > Hi Max, > > Thanks for reviewing this webrev. I have updated test cases by your comments > and simplify codes, please check latest webrev below and let me know if there > are any problems: > http://cr.open